C# template files incorrectly identified as pascal about linguist

[vpenades]

Oh, I thought you proposed me to make the PR, my hands are full with several projects.

You can pick any cs.pp from here:

https://github.com/vpenades/CodeSugar/tree/main/src/CodeSugar.System.IO.Sources

[lildude]

If usage is sufficiently high, feel free to submit a PR to add support for this extension to C#. See CONTRIBUTING.md for details. Until then, you can use an override to force the language.

[Alamingazipur]

👍 alamin reacted via Gmail <https://www.google.com/gmail/about/?utm_source=gmail-in-product&utm_medium=et&utm_campaign=emojireactionemail#app> On Tue, 2 Jan, 2024, 12:53 am alamin khan, < ***@***.***> wrote:

…

On Mon, 1 Jan, 2024, 11:15 pm Vicente Penades, ***@***.***> wrote: > Describe the bug > > C# nuget packages allow to include .cs files that can be templated: the > usual extension for this is .cs.pp , where .pp extension tells > nuget that it should treat the file as a .cs template. > Expected behaviour > > nuget .cs template files should be identified as C# > Related discussion Additional notes > > See https://github.com/vpenades/CodeSugar > > — > Reply to this email directly, view it on GitHub > <#6662>, or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BBYRF653GW5B7D3PEV7XEEDYMLVJ7AVCNFSM6AAAAABBJFHUNKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3DCNRXGEZDSNY> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> >

[DecimalTurn]

It seems like the extension cs.pp has already reached the popularity threshold to be added (2.4k files at the moment):
https://github.com/search?q=path%3A*.cs.pp+NOT+is%3Afork&type=code

@vpenades I can help with the PR creation to add cs.pp to the C# if you'd like. The details of how to do it are explained here: https://github.com/github-linguist/linguist/blob/master/CONTRIBUTING.md#adding-an-extension-to-a-language
Note that you'll need a sample file that is representative of cs.pp files (see step 2).

[vpenades]

As suggested by @lildude I was able to fix my repo with an override, so it's fine from my side

[DecimalTurn]

@vpenades The workaround using .gitattributes works for the stats bar, but not for search. See here for instance (the files are still seen as Pascal).

Also, why not take this opportunity to fix this for everyone at the same time? Just let me know if you have a file that would be a good sample in your repo and I can make the PR.

[DecimalTurn]

The issue can now be closed; PR has been merged and is now part of the latest release.