This repository holds the code base of the API to rule them all, the Lord of the Rings api, which provides you with book, character, movie and quotes data.
Home Page: https://the-one-api.dev
Sometimes we monitor bulk registrations on the-one-api.dev, triggered by the same IP within a very short period if time. It would be great to implement a basic security mechanism, that prevents spam registrations like that.
Feel free to create a pull request! 🚀
Currently the book chapters are returned in no particular order and cannot be sorted according to any information that the API contains. The only way to sort them is to already know the correct order and sort against it.
Option 1: The id's are given chronologically to each chapter, so the chapters can be sorted by id.
Option 2: Adding a chapter column, where each chapter receives a number. LotR is divided into several books, so it would have to be non unique, as there will be multiple chapter 1, but could still be sorted, if given a book id as well.
https://the-one-api.dev/v2/ -- Endpoint does not exist error.
Also, when calling from python using response.raise_for_status() I get a 404 Client Error: Not Found for url.
I signed up using a generated 256 character password. I received a positive feedback submitting, but when I tried to log in, a message appeared, informing me, that the password would be incorrect. As I was using a password storage and tried it multiple times, this should not be the case.
Afterwards, I signed up, using another email and a shorter password and everything worked fine.
As backend is done now, I’ll migrate other parts of the app to TypeScript too - this one is for sample app.
The project's current main README is a little bit scarce and not really inviting.
It would be great to have an improved version. This works as inspiration: https://github.com/othneildrew/Best-README-Template
Possible #hacktoberfest task!
Although REST is doing great for The one API, it would be nice to add and expose a GraphQL endpoint in the future.
Any help is appreciated. 🚀
Having a basic CI/CD pipeline for tests and deployments would be beneficial. It would make reviewing PRs easier and help ensure the project is in a stable state.
Something like Travis, CircleCI or GitHub Actions would suffice.
It would be beneficial to migrate existing code base to TypeScript to introduce type safety and other features this language provide.
@gitfrosh please let me know what do you think about it.
I am trying to access the link below and it is returning an "Internal Server Error". I am able to replicate this issue on both Windows machine and Android phone using multiple browsers.
Hello there... this may be silly, but I forgot my login password. I get an error but no "retrieve new password" option. Am I missing it? Thanks!
When you made request to 'quote' API you get a response with quotes which contains a lot of excessive blanks before quote, after quote or in the middle.
Should we handle this situation and remove them before sending to client?
Examples:
{ "_id": "5cd96e05de30eff6ebcce925", "dialog": " It is the road to the Dimholt, the door under the mountain. ", "movie": "5cd95395de30eff6ebccde5d", "character": "5cd99d4bde30eff6ebccfd81" },
{ "_id": "5cd96e05de30eff6ebcce928", "dialog": "My sons are spent! , My line has ended! ", "movie": "5cd95395de30eff6ebccde5d", "character": "5cd99d4bde30eff6ebccfca1" }
It would be interesting if the API included information about the First and Second Age of Middle-earth. I'm curious if I can contribute this information or if it would be limited by copyright.
The The one API documentation website (https://the-one-api.dev) is not yet PWA ready.
Any help is appreciated! 🚀
Just wondering if there were any plans to add Rings of Power content to the API or not?
Backend and sample app are done so it's time to migrate frontend app too.
Not sure if you're interested in accepting Hacktoberfest requests, but I could give this a go.
I am not at all familiar with this language but have been an fullstack dev for five years now :)
This Repo is entirely non-tested. 😭
Pull requests including
are very welcome.
So I can sleep at night.
I'd like to say a BIG thank you for this API (bought you a coffee). I'm a volunteer for a hospice charity that has a geeky fund-raising team - the LOTR API is called from a messenger chatbot. I cut over to the V2 api and I noted a couple of small differences - the JSON now returns with characters with the tag 'Name' instead of 'name', and 'Url' instead of 'wikiUrl'.
Get https://the-one-api.dev/v2/movie/5cd96e05de30eff6ebcce7e9/quote
Response
{
"docs": [],
"total": 0,
"limit": 1000,
"offset": 0,
"page": 1,
"pages": 1
}
Just trying to hit the api after signing up for auth token and after a couple requests I'm getting 429 too many requests.
GET https://the-one-api.dev/v2/book 429 (Too Many Requests)
This issue is related to the way the documentation is displayed on page https://the-one-api.dev/documentation.
Some of the endpoints urls are truncated with elipses which prevents the user from seeing all of it (unless they change the width of the window - works fine in narrow screens).
This should be easy to fix by removing the text-overflow: ellipsis and using overflow-wrap or word-break (not sure which would work best here).
Another option would be to add a tooltip on hover containing the full text when it gets truncated.
Screenshots taken on width of 1440px:
You can retrieve more info from the console log.
Copy: Access to fetch at 'https://the-one-api.herokuapp.com/v1/character/' from origin 'http://localhost:3000' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
As I get it the server response is missing the following property: Access-Control-Allow-Origin: *
The GET request with an API key is not a simple request in Chrome, so the browser blocks it.
I'm creating this issue as I plan to work on it myself, and I'm writing it out as one might in an agile-ish workflow for demo purposes elsewhere. Ignore to your heart's content.
As a consumer of the Lord of the Rings API
I want developers of the API to have a smoother barrier of entry
So that the ongoing maintenance and improvement of the API can have a broader community of contributors
At the moment we allow any password with min 1 character length which is not ideal.
So this needs to be changed and we should allow at least 8 characters long passwords with special characters, numbers, small and capital letters etc.
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
Django
The Web framework for perfectionists with deadlines.
Laravel
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft
Open source projects and samples from Microsoft.
Google
Google ❤️ Open Source for everyone.
Alibaba
Alibaba Open Source for everyone
D3
Data-Driven Documents codes.
Tencent
China tencent open source team.
