giobar00 / ingsw2022-am33 Goto Github PK

In order to avoid forgetting parameters, functionalities of method and so on please write the javadoc comment when you create the method (or the class).
Write them also in the test classes.

I see:

public abstract class GameBuilder {
public static Game getGame(GamePreset preset, GameMode mode) {
GameModel model;
if (preset.equals(GamePreset.FOUR))
model = new GameModelTeams();
else
model = new GameModel(preset);
if (mode.equals(GameMode.EXPERT))
return new GameModelExpert(model);
return model;
}
}

fi lese a bit messy:
you call new and,
if (mode.equals(GameMode.EXPERT))
You allocate again...

ps why you use equals for enum?

in @test
void returnBlocksToHerbalist() {

maybe better ti split in more granula tests.
(only a suggestion)

Upload a "compiled" version (PDF or image) version of the Model UML in the /Deliveries folder.

Please commit your README.md including your names, surnames and polimi email