gilbarbara / is-lite Goto Github PK

I am currently using react-joyride in my current project, and I am facing an issue when starting the tour. The application fails with with error Error: Expected plain objects or array. Upon investigation I found that is.plainObject method of is-lite library is returning false even when both the objects are similar.

Specifically the comparison prototype === Object.getPrototypeOf({}) https://github.com/gilbarbara/is-lite/blob/main/src/index.ts#L233-L235 is returning false.

Issue occurs during react-joyride: step:0 and while comparing previousProps with this.props. Unfortunately I can not share the code where this issue is coming because of company's privacy policy. But please let me know what other information I can provide.

Interestingly if I create a standalone project and use react-joyride there, everything works fine.

Can it be related to polyfills?

Hi! I've installed is-lite library using npm and have an error: Can't resolve '../src/index.ts'. Version 0.7.0.
Updated: I think react-joyride has the dependence problem (third screen). React-floater has same problem.

It would be nice to put a note somewhere, that IE is not supported by this library, because of these lines:

Number.isNaN is not supported by IE.

Hi, came from react-joyride and it throws on IE11, which traced back to is.nan:

https://github.com/gilbarbara/is-lite/blob/v0.6.0/src/index.ts#L163-L165

Number don't have the isNaN function defined in legacy browsers.

Question

Are you willing to support legacy browsers? Guess that might against your intention of having this package.