Coder Social home page Coder Social logo

get-sheet-done's People

Contributors

giladaya avatar kaufmanhenry avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

get-sheet-done's Issues

Google sheets API v3 is now depracated

Google sheets API v3 (which this library utilizes), is now deprecated. Unless the maintainer plans on updating to v4, then the project docs should state as much, and probably refer people to a newer library like google-spreadsheet.

If new people start to use this for their new projects, then they'll run into some frustrating behavior.

It's unfortunate, but the new API requires a GCP account and an API Token.

labeledColsRows breaks with comma in cell

As an example, using labeledColsRows on the table:

column1 column2
a b, c

returns the following data:

{
  a: {
    c: undefined
    column2: "b"
  }
}

labeledCols works as expected:

{
  0: {
    column1: "a"
    column2: "b, c"
  }
}

ReferenceError: window is not defined

> (node:29026) UnhandledPromiseRejectionWarning: ReferenceError: window is not defined
    at /home/sub/ghubby/crave/surveilly/node_modules/fetch-jsonp/build/fetch-jsonp.js:57:7
    at new Promise (<anonymous>)
    at fetchJsonp (/home/sub/ghubby/crave/surveilly/node_modules/fetch-jsonp/build/fetch-jsonp.js:53:12)
    at /home/sub/ghubby/crave/surveilly/node_modules/get-sheet-done/dist/GetSheetDone.js:111:30
    at new Promise (<anonymous>)
    at fetchAndParse (/home/sub/ghubby/crave/surveilly/node_modules/get-sheet-done/dist/GetSheetDone.js:110:10)
    at Object.raw (/home/sub/ghubby/crave/surveilly/node_modules/get-sheet-done/dist/GetSheetDone.js:195:10)
    at repl:1:14
    at Script.runInThisContext (vm.js:65:33)
    at REPLServer.defaultEval (repl.js:244:29)

labeledColsRows fails when a colon followed by a space is present

GetSheetDone.labeledColsRows is returning an empty object for cells where there is a colon followed by a space.

:

Code:

GetSheetDone.labeledColsRows('[KEY]', 1).then(sheet => { 
        this.setState({
          debug: ctxValue.debug,
          task: ctxValue.task,
          locale: ctxValue.locale,
          data: sheet.data
        });
    });

Spreadsheet:
image

Console:
image

If done as a GetSheetDone.raw(), the data returns as expected. The network request also returns the data as expected.

image

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.