gibber-cc / tidal.pegjs Goto Github PK

Hello, first of all, thanks for this fantastic port of tidal syntax to JS!
I am currently implementing a little live coding playground with it, and realized that when I create a pattern and start querying from a non zero start, the result has the wrong phase.

This works:

const values = (e) => e.value;
const pattern = Pattern('[A <B C>]')
expect(pattern.query(0, 1).map(values)).toEqual(['A', 'B']);
expect(pattern.query(1, 1).map(values)).toEqual(['A', 'C']);

This does not work

const values = (e) => e.value;
const pattern = Pattern('[A <B C>]')
// expect(pattern.query(0, 1).map(values)).toEqual(['A', 'B']);
expect(pattern.query(1, 1).map(values)).toEqual(['A', 'C']); // yields ['A', 'B']

I think I can work around the problem, but it would be much easier if query had no side effects.
FYI I also wrote a little post about this lib.

see https://tidalcycles.org/index.php/Tutorial#Polymeters

console.log(parser.parse('[bd,hh]'))

outputs

{ '0': { '0': { type: 'string', value: 'bd' }, type: 'group' },
  '1/2': { '0': { type: 'string', value: 'hh' }, type: 'group' },
  type: 'layer' }

instead of

{ '0': { '0': { type: 'string', value: 'bd' }, type: 'group' },
  '0': { '0': { type: 'string', value: 'hh' }, type: 'group' },
  type: 'layer' }

Is this expected that this sequence works fine
'<0.5 .5/*2>'
but this one doesn't
'<.5/*2>'

( at least in gibber v2 ) ?

Note that I put a forward slash before the '*' so that it is displayed correctly in GitHub but it shouldn't be there in reality.

It looks like the parser doesn't expect the first atom to have a multiplier ?

title says it all. The same pattern will work as follows:

{kd, ch(3,8)} {sd, kd(5,9)}

... but it'd be better if the [] worked for this.

Current issues seem to be:

1. When you npm install tidal.pegjs, there is no ./dist/tidal.js because pegjs tidal.pegjs has not been run.
2. If you manually ensure tidal.js exists and do import {Pattern} from 'tidal.pegjs' you get 'Pattern' is not exported by node_modules/tidal.pegjs/src/pattern.js.
3. If you do import * as Tidal from "tidal.pegjs" you get Uncaught ReferenceError: util is not defined.