ghedeon / awsinterceptor Goto Github PK

Hi, coming from stackoverflow I gave a look at your implementation.

Your awsDummyRequest in your interceptor assume only 1 call to the interceptor is performed at the same time. This is wrong assumption.

If multiple Http calls are perfomed in parallel they all work on the same instance of Request (the awsDummyRequest).

You should either create a new request every time or build a pool of reusable request, you create a new one if the others are busy and put the used one in the pool to reuse the objects.

More of a question but when I try to add the example gradle snippet to my build.gradle file it errors with:

Error:Could not find com.android.support:support-annotations:25.3.0.
Required by:
    my-project:0.0.1
    my-project:0.0.1 > com.ghedeon:aws-interceptor:0.3

Please install the Android Support Repository from the Android SDK Manager.

I don't use the Android SDK as I'm developing a Java application and I can't import this due to project constraints. Is there no way round this?

Occurs for POST method, GET methods are working fine though.
@POST("getfixtures") fun getFixtures(@Body fixturesRequestPOJO: FixturesRequestPOJO): Call<List<FixturePOJO>>

FATAL EXCEPTION: OkHttp Dispatcher Process: net.test.app, PID: 22550 com.amazonaws.AmazonClientException: Unable to reset stream after calculating AWS4 signature at com.amazonaws.auth.AWS4Signer.calculateContentHash(AWS4Signer.java:360) at com.amazonaws.auth.AWS4Signer.sign(AWS4Signer.java:113) at com.ghedeon.AwsInterceptor.sign(AwsInterceptor.java:72) at com.ghedeon.AwsInterceptor.intercept(AwsInterceptor.java:53) at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92) at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67) at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:185) at okhttp3.RealCall$AsyncCall.execute(RealCall.java:135) at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588) at java.lang.Thread.run(Thread.java:818) Caused by: java.io.IOException: Mark has been invalidated. at java.io.BufferedInputStream.reset(BufferedInputStream.java:336) at com.amazonaws.auth.AWS4Signer.calculateContentHash(AWS4Signer.java:358) at com.amazonaws.auth.AWS4Signer.sign(AWS4Signer.java:113)  at com.ghedeon.AwsInterceptor.sign(AwsInterceptor.java:72)  at com.ghedeon.AwsInterceptor.intercept(AwsInterceptor.java:53)  at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)  at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67)  at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:185)  at okhttp3.RealCall$AsyncCall.execute(RealCall.java:135)  at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)  at java.lang.Thread.run(Thread.java:818) 

repositories {
    maven {
        url "https://dl.bintray.com/ghedeon/maven"
    }
}

Works as well :)

This is a runtime dependency, not only a debug one.

Also latest gradle needs "implementation" instead of "compile"

Please explain variables:

    String authUrl = ""; //AUTH URL
    String userName = ""; //USERNAME
    String password = ""; //PASSWORD

What is authURI and which username and password we have to give in here.

I am downloading audio/wav file using AWS APIGateway with authorization but the file downloaded is corrupted and does not downloads more then 660B.

if interceptor throw an exception that is not child of IOException app will crash

FIX: wrap AmazonClientException with IOException

https://github.com/square/okhttp/blob/e1af67f082027dd7811c88434749b7b8f807ceca/okhttp/src/main/kotlin/okhttp3/internal/connection/RealCall.kt#L535

https://github.com/xanscale/AwsInterceptor/commit/de62271956717d2b4dcf48a84267230ee0372845

Just curious if I can use this library to do HTTP post requests to AWS IoT. How can we modify this to actually do MQTT publish over websockets using Dagger/Retrofit?

Url:
https://www.aws.com/api

Once the request is signed using the interceptor -

Excepted:
https://www.aws.com/api

Current:
https://www.aws.com/api/

Solution:

private fun Request.sign(): Request {
    val canonicalUrl = url.canonicalized()
    val awsDummyRequest = DefaultRequest<Any>(serviceName).apply {

        ****endpoint = url.host
        resourcePath = url.resource****  //separate out the host and resource

        httpMethod = HttpMethodName.valueOf(method)
        setQueryParams(canonicalUrl)
        setBody(body)
    }
    signer.sign(awsDummyRequest, credentialsProvider.credentials)
    return newBuilder()
        .url(canonicalUrl)
        .applyAwsHeaders(awsDummyRequest.headers)
        .build()}