getporter / gh-action Goto Github PK

GitHub Actions supports build agents running Linux, Windows, or MacOS.

We can detect the OS using process.platform and install the correct build of Porter for the OS.

Currently, the new prohibition against GH actions setting env vars and paths is blocking the action, resulting in this error:

Error: Unable to process command '::add-path::/home/runner/.porter' successfully.
Error: The `add-path` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

A moderate security vulnerability has been identified in the GitHub Actions runner that can allow environment variable and path injection in workflows that log untrusted data to STDOUT. This can result in environment variables being introduced or modified without the intention of the workflow author.
To allow us to address this issue and maintain the ability for you to dynamically set environment variables we have introduced a new set of files to manage environment and path updates in workflows.

We'll need to update the action to work properly.

It would be useful to expose the required version of Porter as an input to the action (defaulting to latest) and substitute this value into the install URL to install said version.

Want the Github action to install a specific mixin or multiple mixins so that the bundle can be installed and tested by the GH action prior to being merged or published.

It would be great if the Github action could install plugins prior to running porter install so the bundle can be better tested.

When people use github actions they specify the name of the repo to pick the github action. Right now our repo name is very vague, "getporter/gh-action" and it doesn't tell people what it does. Other actions are named things like "docker-login" which makes it clear what the action does.

I propose that we change this repo to something like getporter/install-porter to better match the naming convention for github actions. Not sure if it needs a suffix to say it's an action, doesn't seem like it though?