gernott / mask Goto Github PK

From: Walter Kruml
Old Link: https://forge.typo3.org/issues/82331
Details:
It is not possible to set the date fields under access.
After saving the field changed to the current date.

If you use a Mask element inside a powermail form, it delivers an "Internal Server error" in the frontend.

The error occurs, when using a contentelement with the TYPO3-regular header-field with an own label, and a second field with nested content.
When using this Mask-element, the header has the given label - fine. After adding a subcontent in the nested field (e.g. the 'text' element), then the label is the same one as given in the parent (Mask-)element.

See also:
https://forge.typo3.org/issues/78593
https://forge.typo3.org/issues/76562

In my current project I have this setup :
Typo3 CMS 7.6 LTS
mask 1.1.2
and basic pre installed extension.

when i create content from the Mast backend plugin, i can create it and use it to show in frontend as well, but after a time i again edit the content and create new i have seen the old one was automatically removed itself,. or some times file does not found in content directory or some times whole keyfield got missed. i have tried to encontered the issue but doesnot succeeds , can anyone having same issue. and resolved it? i am no longer able to use Mask for template mapping.

Preview images must have the filename like ce_[elementkey].png
The original idea was to difference them with the prefix from the backend-layout images. but this is not a good idea, because all other filenames don't use this prefix. So simply remove the prefix to the filename [elementkey].png

From: Benjamin Butschell
Old Link: https://forge.typo3.org/issues/83022
Details:
Infos in EMail

On entering a fieldname, there is a new validation, to prevent - in DB-names.
But:

• the TAB key don't work.
• copy&paste of bullshit is possible.

Hey Gernot, we discussed this with Jo Hasenau and Kay Strobach at the T3CMD18.

Mask currently saves all generated files into a "fileadmin" folder. This is discouraged by the core. Instead all template files should be stored in a sitepackage, which is a simple wrapper extension for the configuration of a TYPO3 installation (since any folders like "fileadmin" should contain user uploads only).

This means, that is should be configurable that the generated files should be stored in an extension path. Of course following the official conventions for filenames etc..

Maybe you have some notes about the structure we scribbled.

From: Benjamin Butschell
Old Link: https://forge.typo3.org/issues/77583
Details:
When extending tt_content with new text fields, use mediumtext instead of text

When creating a new content element in an workspace as a content manager, the own created fields have no titles.

After saving the element the titles appear.

From: Philip Heidenreich
Old Link: https://forge.typo3.org/issues/79528
Details:
when I create repeating elements, translate them and edit the translation in a workspace, then the translated element is saved correctly in database but the input field in the backend shows the origin text again.

From: Gernot Ploiner
Old Link: https://forge.typo3.org/issues/80955
Details:
If you change the path in the Mask-Extension settings to a TYPO3 path like 'EXT:myext' ist doesn't work. Mask generates the folder /EXT:myext/ in the website root directory.

In my current project I encountered following problem:
setup:
Typo3 CMS 7.6 LTS
fluidcontent 7.6
flux, vhs, fluidcontent_core etc
mask 1.1.1

Problem:
I created a gridelement with flux and some content elements with mask. When I created a new CE inside a grid the ce disappeared. So I started tracking the cause of this problem.
Inside maskutility.php I changed the following:
(setElementsTca)
line 408 :
$defaultTabs = ",--div--;LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:tabs.access,--palette--;LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:palette.visibility;visibility,--palette--;LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:palette.access;access,--div--;LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:tabs.extended,--div--;LLL:EXT:lang/locallang_tca.xlf:sys_category.tabs.category,categories,--div--;LLL:EXT:flux/Resources/Private/Language/locallang.xlf:tt_content.tabs.relation, tx_flux_parent, tx_flux_column, tx_flux_children;LLL:EXT:flux/Resources/Private/Language/locallang.xlf:tt_content.tx_flux_children";

Now everything works fine for me :)

I want to access a page variable inside mask to add a fluid partial to render a social menu which is set via dataProcessing.

Anyone has an idea how to do that?

From: Marcel Marty
Old Link: https://forge.typo3.org/issues/82925
Details:
Description

Steps to reproduce the error:

FE-Output:

1. Create FLUID-Template with <f:cObject typoscriptObjectPath="lib.content "/>
2. Integrate output with lib.content < styles.content.get

Mask Element Template:

1. Create new mask element "TEST"
2. Add "Repeating" Element
3. Add "Content" Element into Repeating
4. Save

Mask in Frotend

1. Add Mask Element "TEST"
2. Add one or multiple content elemtents

FE output works if cache is empty or cleaned. On second page view, the lib.content is empty until next cache clean. Seems that lib.tx_mask.content conflicts with styles.content.get

Installed version is 3.0.2
TYPO3 8.7.8

From: Gernot Ploiner
Old Link: https://forge.typo3.org/issues/79704
Details:
It appears, when there exists no CE or no backend_layout.
And debug mode must be turned on.

From: Heiko Bihlmaier
Old Link: https://forge.typo3.org/issues/81977
Details:
I get after saving and closing the following error message, when I use a wizard into a content element in mask

Oops, an error occurred!
Empty context string given

The following steps I do for this error:

create mask element with a content element inside
add this to a page
add a plugin like powermail or table into this content element
use the wizard from table element or press "edit powermail form
click "save and close"
you will get this error
changes will be stored, but the redirect back is not working.

Can u help here asap?

Versions:

TYPO3 8.7.4
Mask 3.0.1

Note: In TYPO3 8.7.2 and 8.7.3 the same error.

Don't know why. Missing version?

If you use preview images instead of font-awesome icons, they are very small in the "new contentelement wizard". Please make them bigger.
Idea: rename the images from e.g. ce_text.png to text.png. Remove 'ce_' prefix - earlier it was the idea to store contentelement previewimages and page previewimages in the same folder...

From: Heiko Bihlmaier
Old Link: https://forge.typo3.org/issues/81149
Details:
I have a mask element with a content element. When I try to translate this in copy mode, the field in the foreign language is empty.
The checkbox "Localize Records when Content Element is localized" worked, but then I have the content element twice in the page. one time in the mask element and one time in the page.

From: Sergio Catalá
Old Link: https://forge.typo3.org/issues/82236
Details:
Using latest EXT:mask version (3.0.1).
Localization features are currently applied to repeated elements.
"Localization mode" (l10n_mode) is only applied to them now.
However, if "prefixLangTitle" option is applied to the field through the EXT:mask configuration module, this has no effects over possible nested text and input elements inside the repeated element ("[Translate..]" prefixes are not applied to them).
Does this option have sense inside repeated elements?
Shouldn't it be applied only to text and input elements?
Editing by hand my .json configuration file, and adding the "l10n_mode = prefixLangTitle" to the TCA section for the input/text field fixes this issue.
Is this a new feature or a bug?

I get a lot of missing images, when selecting the content element:

my.dev/typo3/icon%20=%20../fileadmin/MaskIcons/ce_myelement.png not found.

its with Maskt 1.1.2 and TYPO3 6.2.17

In TYPO3 7LTS and 6.2, when I am in a workspace, if I change the value of a IRRE field in a mask content, the old value is previewed, I must publish the content to see the new value. But if I add a new item in the workspace, the new item is visible on the workspace preview. The problem seems to exist only when I change the value of a live existing item.

The issues has been rejected in the forge today, the answer was "This is a core Issue. TYPO3 7.6 has some problems with workspaces."

But I'm sorry to insist : I did exactly the same test with a not mask content and IRRE field before sending the issue, and there is no problem at all, with TYPO3 6.2, TYPO3 7LTS and TYPO3 8lts.

In addition, I did the same test today with an 8LTS version and here are the errors I get when I try to modify an IRRE item of mask content:

2: SQL error:'' Incorrect integer value:'' for column'' l10n_parent' at row 1'' (tx_mask_accordeon: NEW5a8d4aa988a79008952330)
1: Could not be edited in offline workspace in the branch where found (failure state:' Online record was not in versionized branch!'). Auto-creation of version failed!

So in the 6.2 (mask version 1.1.4) and 7LTS version (mask version 2.1.1), we can save the modification but the preview don't show the modifications, we have to publish to see them. In 8LTS (mask version 3.0.2), we can't save the modifications, and we get error messages.

Did we misconfigure the IRRE fields in our mask content?

Thank you in advance for your answers.
Rachel Foucard

I am using 7.6, when I copy a Mask element, in default the system offers to make a copy of the element, or - make a reference..

When I do a reference, I get an Mask rendering error:

"MASK ERROR: Content Element type "shortcut" has no rendering definition! Have you cleared TYPO3 cache?"

At my presentaion at T3C Dresden with the current Git-Master (new clear cache included), it doesn't worked all the time.

From: Jasper Topütt
Old Link: https://forge.typo3.org/issues/80847
Details:

When I create a select box with data from a foreign_table it first seems to work correctly.
I can choose the Records I need and it is saved correctly to the database.
But when I reopen the content element in the typo3 backend, allways the first value of the listbox is selected.
(typo3 7.6.16, mask 2.1.1)

If there are about 30 Contentelements with nested content (and some content inside) on one page, the frontend loads about 15 seconds.
Tested on hades (mask-internal).

Updated by Walter Kruml
I have the same problem on different servers!
Only pages with nested content elements inside mask are slow.
All other sites are fast!

From: Stefan Schoner + Walter Kruml
Old Link: https://forge.typo3.org/issues/78157 + https://forge.typo3.org/issues/82895
Details:

1. When I translate a mask element no custom backend preview is shown.. I have used a repeating section and a custom preview template.
2. I have a mask CE with sections. CEs inside the sections are not shown in the backend layout on translated sites.
   
   

From: Manfred Mirsch
Old link: https://forge.typo3.org/issues/77230
Details:
I created two mask content elements:

1. Am element "tile" having "image" as one of the fields for usage as content elements
2. An element "tiles" having one element of type "content" allowing "tile" as element

I inserted a content element on a page of type tiles and inserted some subcontent elements of type tile.

The data-array of subcontent elements do not have the filereference objects assigned.

In code I foud, that the method \MASK\Mask\Helper\InlineHelper->addFilesToData does not handle this special case.

The variable $table has in this case "tx_mask_tiles" as value which doesnt work here.
$storage has "tt_content" as only element, so line 78 will allways fail:
#78 if ($storage[$table]["tca"]) {

also $fieldHelper->getFormType($fieldKey, "", $table) will allways result in "String" as the table "tx_mask_tiles" is not existing in $GLOBALS["TCA"].

Ia am adding a patch, that works for my problem, but did not test, if it interferes, when subcontent is inserted via repeating of elements.

A further discussion about tihs is available here: https://forge.typo3.org/issues/77230

Working with TYPO3 8.7.10 and have problems with MASK 3.0.2 while translating nested Content Elements (although 'Localize Records when Content Element is localized' is enabled): In the backend I can see nested Content Elements if Localization Mode 'Keep the value or data from original language' is enabled, but not in the frontend. If Localization Mode 'Create Copy' is enabled, I can see nested Content Elements neither in backend nor in the frontend. Mask with e.g inline Richtext are working fine when i translate them.

It looks to me that the issue https://forge.typo3.org/issues/81182 is still open.
Changing line 166 in FieldHelper.php
from
if (is_array($tca["config"]["wizards"]["link"]) || $tca["config"]["renderType"] == 'inputLink') {
to
if (isset($tca["config"]["renderType"]) && $tca["config"]["renderType"] === "inputLink") {
should solve the issue.

From: Georg Ringer
Old Link: https://forge.typo3.org/issues/83681
Details:
The following line https://github.com/Gernott/mask/blob/master/Classes/Helper/InlineHelper.php#L149

$GLOBALS['TSFE']->cObj->enableFields($childTable);

throws an exception because somehow TSFE is initialized but not fully (don't ask me why) and therefore no cObj is filled.

I propose to change if (isset($GLOBALS['TSFE']->sys_language_uid)) { to if (TYPO3_MODE !== 'BE')

From: Gernot Ploiner
Old Link: https://forge.typo3.org/issues/78828
Details:
All fields of the pages table should be automatically added to this two values from the installtool

From: Gernot Ploiner
Old Link: https://forge.typo3.org/issues/79095
Details:
The following 3 warnings are in the TYPO3-Log in the Backend.
To reproduce: Clear all cache in the Installtool and load the websites home page.

Core: Error handler (BE): PHP Warning: implode(): Invalid arguments passed in /html/typo3/typo3conf/ext/mask/Classes/CodeGenerator/TcaCodeGenerator.php line 494

Core: Error handler (BE): PHP Warning: implode(): Invalid arguments passed in /html/typo3/typo3conf/ext/mask/Classes/CodeGenerator/TcaCodeGenerator.php line 493

Core: Error handler (BE): PHP Warning: implode(): Invalid arguments passed in /html/typo3/typo3conf/ext/mask/Classes/CodeGenerator/TcaCodeGenerator.php line 492

From: Jan Viehweger
Old Link: https://forge.typo3.org/issues/79649
Details:
i try to create a related content functionality without luck.

i have a mask element (key item) which contains a "selectbox" (key related). the foreign_table field is set to tt_content and the foreign_table_where is set to AND tt_content.CType="mask_item" AND tt_content.uid != ###THIS_UID###

all possible entries are shown correctly in the item's backend form, no problem.
but when trying to save the item record, all uid's of the selected related items are stored in the tx_mask_related field but are not rendered as selected.

using the same principle with another table (e.g. pages), everything works as expected.

As with temp.mask.page, I would like (or rather, need) to define a custom template location for temp.mask.content items in TypoScript.

That's possible, isn't it?

I expected something like

content < temp.mask.content
content.select.where = colPos=1
content.settings.file = path/to/content-template.html

but that doesn't work, obviously.

I saw there is some PHP related to that in Resources/Private/Mask/setup.ts (settings.file = ###PATH###) but I'm not sure if that's it...

Following that lead, I tried setting tried mask.tt_content.mask_elementkey.settings.file = path/to/elementtemplate.html, no luck either.

I know this isn't stackoverflow, but I'd really appreciate hint. I feel like I'm missing a basic puzzle piece...

From: Tim Tilch
Old Link: https://forge.typo3.org/issues/82302
Details:
For now a content element of type mask has the icon for content element of type text.
You could change it to the same icon as in the admin tools

When I use an existing Field with a custom label, the default label still appear:

        "video": {
            "label": "Video",
            "key": "video",
            "shortLabel": "Video",
            "description": "",
            "icon": "fa-youtube-play",
            "color": "#000000",
            "columns": [
                "header",
                "subheader",
                "image"
            ],
            "labels": [
                "",
                "Youtube Link",
                "Cover"
            ]
        }

I use T3 7.6. and Mask 2.0.1

From: Björn Heggemann
Old Link: https://forge.typo3.org/issues/81567
Details:
TYPO3 8.7.1 mask 3.0.1

Coping mask content element with IRRE element produces

"SQL error: 'Incorrect integer value: '' for column 'l10n_parent' at row 1"

Can be solved by adding l10n_parent default value for IRRE element:

                array(
                    'displayCond' => 'FIELD:sys_language_uid:>:0',
                    'exclude' => 1,
                    'label' => 'LLL:EXT:lang/locallang_general.xlf:LGL.l18n_parent',
                    'config' =>
                        array(
                            'type' => 'select',
                            'renderType' => 'selectSingle',
                            'items' =>
                                array(
                                    0 =>
                                        array(
                                            0 => '',
                                            1 => 0,
                                        ),
                                ),
                            'foreign_table' => 'tx_nnphaenoce_workshop',
                            'foreign_table_where' => 'AND tx_nnphaenoce_workshop.pid=###CURRENT_PID### AND tx_nnphaenoce_workshop.sys_language_uid IN (-1,0)',
                            'showIconTable' => false,   
                            'default' => 0  // add this !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
                        ),
                ),```

From: Philip Heidenreich
Old Link: https://forge.typo3.org/issues/79527
Details:
When I create repeating elements, they won't show up in workspace preview.
The workspace overlays are created correctly in the database, but i can't see them on the frontend page.

Possible fix: InlineHelper.php -> getInlineElements()

// and recursively add them to an array
while ($element = $GLOBALS["TYPO3_DB"]->sql_fetch_assoc($sql)) {
    $GLOBALS['TSFE']->sys_page->versionOL($childTable,$element);
    if (is_array($element)) {
        $this->addIrreToData($element, $name, $cType);
        $this->addFilesToData($element, $name);
        $elements[] = $element;
    }
}

From: Gernot Ploiner
Old Link: https://forge.typo3.org/issues/66568
Details:
Validator Bug:
First create a new field and save the element totally.
Now you want to change the field-type (example: text to rte). The only way ist to delte the field and create a new one.
But you cannot use the same fieldname like before, because the validator finds it in TCA.
Temporary solution: save the element after field-deleting. Then edit again and it works.

An exception appears.

I've created an Element with an IRRE repeatable section. If a user deletes an IRRE element it doesn't show up in the frontend as expected. But the collection for the backend preview does still contain the deleted elements.

Example:

<f:for each="{data.tx_mask_teaserbereich}" as="data_item" iteration="it">
...
</f:for>

The tx_mask_teaserbereich collection does contain the deleted elements. I think this behaviour should be changed if possible, so that the result is as expected: deleted elements should not be shown.

From: Jürgen Venne
Old Link: https://forge.typo3.org/issues/83221
Details:
The line

return $this->cObj->RECORDS($conf);

throws error: RECORDS is undefined

I suggest using the following code as described in http://blog.teamgeist-medien.de/2014/01/extbase-fluid-viewhelper-fuer-tt_content-elemente-mit-namespaces.html:

namespace MASK\Mask\ViewHelpers;

/** * ViewHelper for rendering any content element * @author Paul Beck * @link http://blog.teamgeist-medien.de/2014/01/extbase-fluid-viewhelper-fuer-tt_content-elemente-mit-namespaces.html Source *
*/

use TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper;
use TYPO3\CMS\Frontend\ContentObject\RecordsContentObject;

class ContentViewHelper extends AbstractViewHelper {

/**
 * Parse content element
 *
 * @param integer $uid uid of the content element
 * @return string parsed content element
     */
    public function render($uid)
{
        $conf = array(
            'tables' => 'tt_content',
            'source' => $uid,
            'dontCheckPid' => 1
        );
        return $this->objectManager->get(RecordsContentObject::class)->render($conf);
    }
}

From: Tobias Pfender
Old link: https://forge.typo3.org/issues/75437
Details:
Currently it isn't possibily to drop mask elements from the gridelements drag-in wizzard to page columns.
I use
TYPO3 7.6.4
mask 1.1.4
gridelements 7.0.5

On IRRE and FAL fields, the checkbox for traslating child elements should be activated by default.

Idea from Fabian Galinski: it would be great, if we could set the defaults of all Mask options for new elements. That could be done via TypoScript. :)

Make the same Listview at Backend Layouts as at Contentelements:

• show the icon
• show the HTML icon for the example Fluid Tags

From: Rafal Brzeski
Old Link: https://forge.typo3.org/issues/80259
Details:
This behaviour appears only on workspace module,
Content-Fields tab (added by Mask) is not visible in page edit until publishing the page.

To reproduce this bug, do the following:

1. Open Draft mode in Workspace module
2. Add new page in draft mode
3. Try to edit something in Tab Content-Fields from page edit
4. There is no Tab Content-Fields...
5. Publish that new created page
6. Try to edit something in Tab Content-Fields,
7. Tab Content-Fields is visible

From: Benjamin Butschell
Old Link: https://forge.typo3.org/issues/76420
Details:
Originally created by werkraum-admin on Github:

In my current project I encountered following problem:
setup:
Typo3 CMS 7.6 LTS
fluidcontent 7.6
flux, vhs, fluidcontent_core etc
mask 1.1.1

Problem:
I created a gridelement with flux and some content elements with mask. When I created a new CE inside a grid the ce disappeared. So I started tracking the cause of this problem.
Inside maskutility.php I changed the following:
(setElementsTca)
line 408 :
$defaultTabs = ",--div--;LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:tabs.access,--palette--;LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:palette.visibility;visibility,--palette--;LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:palette.access;access,--div--;LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:tabs.extended,--div--;LLL:EXT:lang/locallang_tca.xlf:sys_category.tabs.category,categories,--div--;LLL:EXT:flux/Resources/Private/Language/locallang.xlf:tt_content.tabs.relation, tx_flux_parent, tx_flux_column, tx_flux_children;LLL:EXT:flux/Resources/Private/Language/locallang.xlf:tt_content.tx_flux_children";

Now everything works fine for me :)

Validate the content in the form to prevent errors with spaces or zero.
See also: https://forge.typo3.org/issues/71711