The use-feathers from geprog

Prevent find from being executed

It would be nice if we could set the ref-value of a useFind query to something like null to prevent the find from searching. As soon as the query changes to undefined or some value it should start searching similar to the id behavior of useGet.

Support feathers pagination

Currently we expect all the responses from feathers to be an array of items. But feathers also have pagination in its adapter-commons. So we need to support this as well.

zeros in paginated meta info is evaluated incorrectly

E.g. if skip is set to 0 the response is not evaluated correctly as paginated data.

Test

ci: add workflow

build
lint
test
~~publish~~

onItemChanged filtering

Looking at:

use-feathers/src/useFind.ts

Lines 32 to 33 in c3f8a7d

    
           // remove item from the list if they have been on it before 
        
           data.value = data.value.filter((item) => getId(item) !== getId(changedItem));

and the corresponding test:

use-feathers/test/useFind.test.ts

Line 380 in c3f8a7d

    
           it('should listen to "patch" & "update" events and remove item from list when query is not matching anymore', () => {

This seems like a case that can not happen. When the query changes find is called and overrides data.value completely.

I stumbled across this because the test title mentions "when query is not matching anymore", but the test does not simulate a no longer matching query.
Additionally adding await nextTick(); before emitting the updated event breaks the test. That should not happen.

Expose unload function

It would be nice to export a function called unload which can be used to unload the event listeners manually.

invalid data after query updated

When you have a request like

const params = ref({ query: {} });
const { data } = useFind(service, params)`;

Then this request might take a while to respond.
When the params get updated while the first request is not yet finished e.g. by setting ref.value = { query: { _id: 123 } }
then a second request with the updated params is performed.

This second request is probably much faster than the first request which causes data to be [{ _id: 123, ...rest }].
When the first requests finishs afterwards data will be set to [...aLotOfItems] which means that the data is not fitting to the query anymore.

Pending Approval

These branches will be created by Renovate only once you click their checkbox below.

Detected dependencies

github-actions

.github/workflows/lint-pr.yml

amannn/action-semantic-pull-request v3.4.0

.github/workflows/release.yml

actions/checkout v2

actions/setup-node v2

actions/cache v2

pnpm/action-setup v2.0.1

.github/workflows/tests.yml

actions/checkout v2

actions/setup-node v2

actions/cache v2

pnpm/action-setup v2.0.1

actions/checkout v2

actions/setup-node v2

actions/cache v2

pnpm/action-setup v2.0.1

actions/checkout v2

actions/setup-node v2

actions/cache v2

pnpm/action-setup v2.0.1

actions/checkout v2

actions/setup-node v2

actions/cache v2

pnpm/action-setup v2.0.1

npm

package.json

sift ^15.0.0

@feathersjs/adapter-commons 5.0.0-pre.15

@feathersjs/errors 5.0.0-pre.15

@feathersjs/feathers 5.0.0-pre.15

@geprog/eslint-config 1.1.0

@geprog/semantic-release-config 1.0.0

@vue/test-utils 2.0.0

c8 7.11.3

eslint 8.8.0

jsdom 20.0.0

prettier 2.5.1

semantic-release 19.0.3

tsup 5.11.13

typescript 4.5.5

vite 3.0.3

vitest 0.19.1

vue 3.2.37

@feathersjs/adapter-commons ^5.0.0-pre.3

@feathersjs/feathers ^5.0.0-pre.3

vue ^3.0.11

pnpm 7

Check this box to trigger a request for Renovate to run again on this repository

	// remove item from the list if they have been on it before
	data.value = data.value.filter((item) => getId(item) !== getId(changedItem));

geprog / use-feathers Goto Github PK

use-feathers's People

Contributors

Stargazers

Watchers

Forkers

use-feathers's Issues

Pending Approval

Detected dependencies

Recommend Projects

Recommend Topics

Recommend Org