KS test gives incorrect test_statistic about pyextremes

[eastjames]

@georgebv Thanks for the nudge. Pull request submitted.

[georgebv]

@eastjames good catch. Based on my review, the test itself is implemented correctly but fit_parameters passed to it in the EVA class are indeed incorrect (must be both fixed and free (aka fit) parameters). We need to provide a merged dict of fixed and free parameters in the EVA.test_ks method. Would you like to submit a pull request with this fix? I would appreciate a contribution, especially since you found the error and solution already.

[eastjames]

@georgebv apologies for my delay. Yes -- if it is not immediately urgent, I would be glad to submit a pull request with a fix in the next few weeks.

[georgebv]

@eastjames absolutely, no rush, contributions are welcome any time. Please ping me here whenever you prepare the PR

[georgebv]

@eastjames I know that you likely moved on, but reminding in case you are still interested in contributing to the project. If not, no worries - let me know and I will close the issue.