silence city data warning during startup about node-geoip

[bluesmoon]

wanna submit a patch? ;)

[defunctzombie]

would it be a problem if I just removed the warning altogether? Another alternative is to use a method in place of a direct require:

var geoip = require('geoip-lite').db( ... options ... );

This has the added benefit of letting users specify locations for db files. If the user specifies a city file then they would get that. Obviously there would be defaults for options to load the currently available files.

Thoughts? If this seems like something you would merge in I will gladly write the patch for it.

[bluesmoon]

yep, this would be a good way forward.

[bluesmoon]

Might be better to use an init() method on the geoip object which takes a config object as a parameter.

The init method loads up the database based on its config options:

db: city -> loads default city database
db: country -> loads default country database
db: path/to/file -> loads specified file

For every specified db, it should try to load both the ipv4 and ipv6 versions.

A second parameter can specify whether to turn on warnings or not. This will throw a warning if the specified db was not available/readable and we had to fall back.

[defunctzombie]

I think the warnings would be implied if you specified a file but it was not found. node.js file readers will fail and we could probly let them do that and just send the error to the user.

[reneretz]

Have you implemented it?

[bluesmoon]

I don't believe this has been implemented yet.

[jordanj77]

+1

[bluesmoon]

Ok, I've decided to just drop the warning altogether.