Incorrect geolocation for non-geolocated IPs about node-geoip

[davide-scola]

hello @bluesmoon,
do you have any news on this, please?

Currently, several users connecting, for example, via VPN or over the Tor network are geolocated in the Islamic Republic of Iran, which, besides being incorrect, raises a number of issues for financial service providers being that country a prohibited jurisdiction.

May I know if you are interested in fixing this issue, please? (using proposal #255 or any other solution)

Thanks,
davide

[bluesmoon]

I think the problem is far simpler.

For a non-existent location, the parseInt returns NaN, and when we lookup cityLookup, it returns undefined. When we do undefined >>> 0, we get 0. The fix is simply to initialize cityLookup = {NaN: -1} which will get us a value of INT32_MAX.

I'll make an MR for it.

[davide-scola]

hello @bluesmoon,
first of all, thank you for acknowledging this issue, much appreciated.

Personally, I don't think that exploiting an overflow to UINT32_MAX and having NaN as an object key is preferable to starting the line count from 1 but, in any case, thank you very much for fixing it.

Could you please release the new version (1.4.8) so that it can also be installed from the registry?

Thanks,
davide

[bluesmoon]

Unfortunately npm publish is not working at the moment due to a 404 on the authentication page.

[davide-scola]

hello @bluesmoon,
thank you for the quick response; is npm publish still broken for you?

Thanks,
davide

[bluesmoon]

Yes. npm just throws a 404 when trying to authenticate.

[bluesmoon]

ok, got it published.

[davide-scola]

thank you, @bluesmoon, much appreciated 🖖