Outside ipv4 range about node-geoip

[lloydchang]

Hi Dave (btmdave), thanks for reporting this. While I agree with you that error messages are helpful, I believe design choices of geoip-lite (speed over accuracy, speed over features, when compared to geoip package) intentionally forgoes transaction overhead of error messages processing. Lets see what Philip (bluesmoon) says when he chimes in. In the meantime, Dave, what are your thoughts on geoip-lite's design choices?

[bluesmoon]

Hi @btmdave, my design choices were influenced pretty much what @lloydchang says. I use node-geoip to lookup several million IPs a day and cannot afford to throw in any conditions that would slow down the majority case (ie, valid IPs).

Secondly, there's not much I can do about an invalid IP regardless of why it's invalid.

Lastly, the current design makes it simpler from the caller's point of view. A caller simply needs to check if the return value is truthy or not, and if it's truthy, then use it. If I were to return an error, or throw an exception on a bad IP, this would make callers more complicated without any benefit (at least none that I see).

[btmdave]

@bluesmoon, thank you for the response. I wasn't necessarily criticizing the design choice, it's just I was receiving the same problem for all valid IP's that I tested.

[btmdave]

@bluesmoon , Just did a fresh install and it worked perfectly. I probably didn't have the correct data files. Thanks so much.

Is there any example of using the converter for the full maxmind db?

[bluesmoon]

I don't have the full maxmind db, so don't know if the format is the same or not. The conversion scripts both print usage information if run without arguments. city data only works with IPv4 (since MaxMind doesn't have IPv6 data for cities). country converter detects whether it's looking at v4 or v6 and does the right thing.