geodacenter / jsgeoda Goto Github PK

View Code? Open in Web Editor NEW

23.0 23.0 4.0 9.45 MB

jsgeoda is a javascript library for spatial data analysis using webAssembly

JavaScript 100.00%

jsgeoda's People

Contributors

Stargazers

Watchers

Forkers

nofurtherinformation lixun910 houxieyu lanselin

jsgeoda's Issues

Linting Errors and Naming Conventions

This is definitely a great library! Unfortunately it will fail on most JavaScript projects, because the method names are using underscores. The syntax is also hard to read because it borrows concepts from Python.

It would be way better to use the default camelCase style. And it is also quite common to prevent abbreviations.

Examples:

queen_weights should be queenWeights or even better getQueenWeights.
get_col should be getCol or even better getColumns
read_geojson should be readGeoJSON

See: https://eslint.org/docs/rules/camelcase.html

Fix missing `</script>` closing tag in the doc

It seems it's at gitbook.io level doc not in the repo.

In https://xunli.gitbook.io/jsgeoda/user-guide/hello-jsgeoda#pure-js, you provides the following

<html>
<head>
</head>
<body>
<script type="module">
import jsgeoda from 'https://cdn.skypack.dev/-/[email protected]/dist=es2020,mode=imports/optimized/jsgeoda.js';
jsgeoda.New().then((geoda)=> {
    console.log('Hello jsgeoda', geoda.version);
});
</body>
</html>

whereas it should be

<html>
<head>
</head>
<body>
<script type="module">
import jsgeoda from 'https://cdn.skypack.dev/-/[email protected]/dist=es2020,mode=imports/optimized/jsgeoda.js';
jsgeoda.New().then((geoda)=> {
    console.log('Hello jsgeoda', geoda.version);
});
</script>
</body>
</html>

Been aware of the issue as Chrome was working with this unclosed tag whereas Firefox was not auto-fixing the unbalance tag and failing

get_colnames() missing from WASM

Problem: Following the Load Spatial Data tutorial get_colnames() is not available in the WASM. See steps to reproduce here in cell ~6.

Remove from tutorial for short term and add function in next version?

geodacenter / jsgeoda Goto Github PK

jsgeoda's People

Contributors

Stargazers

Watchers

Forkers

jsgeoda's Issues

Linting Errors and Naming Conventions

Fix missing `</script>` closing tag in the doc

get_colnames() missing from WASM

Update: add type declaration d.ts file

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent