gelassen / government-rus Goto Github PK

User story

As an engineer I want to use modern API in Android development

Tech details

Navigation over explicit launch of intents is old fashioned and outdated. Navigation component should be used instead

User story

As a developer I want a consistent and up to date with modern standards navigation within the app

Tech description

Currently app has a mix of traditional operations with fragments over fragmentManager and modern NagGraph operations. Also app is not single page (Activity) application. The right way to integrate it into NavGraph requires more investigation.

Steps to reproduce

1. Enter the app
2. Enter some word in search field like 'медицина'
3. Wait for result screen
4. Open another tab, e.g. deputies
5. Switch back to bills fragment
6. Enter some word in search field

Expected behaviour

Screen with search result is shown

Observed behaviour

Screen is empty or app doesn't respond on changes in input field

Additional details

The issue likely lies in mix of traditional operations via fragment manager and navigation graph. Here is related choir task #3

User story

As a user I want smooth navigation across tabs

Tech details

Originally data wasn't cached. It was an extra overhead on codebase maintenance and bills always updating which made sense to pull from server on each launch. However, when user go through tabs each request to server makes him to wait which is not convenient.

There are several options to do this:

• cache data in db
• make fragment as retain fragment
• cache data in the view model

Retain fragment is a deprecated option and in current architecture it might lead to bugs. Cache data in view model is a right option, but requires more work with dagger custom injections. Current work on it is not satisfying all requirements.

User story

As a user I want to have consistent UX across all my mobile apps

Tech details

Many modern application stops using circle progress indicator for long running operations and use a tool which is called a shimmer

User story

As a user I want app to follow modern UX practices

Tech details

Many apps uses shimmer as a placeholder when app loads data from cache or internet. It is already added in the deputies screen, but in the rest its implementation requires consideration:

• load of data is quite quick
• shimmer on this pages looks dirty
• even Facebook aka Meta put this library in the archive
• implementation requires Meta license declaration in code
• integration tests becomes more complex

Steps to reproduce

1. Open app's start screen
2. Open an item (a bill)
3. Tap on the start icon to add item to the tracker
4. Select two more items this way (add two more items to the tracker)
5. Open a tracker screen
6. Select an item
7. Go to votes tab
8. Click 'discussions' options menu item
9. Return back to the tracker tab

Expected behaviour

Tracker screen shows three items

Observed behaviour:

Tracker screen shows four items, one of them is a duplicate

Additional details

Tracker items are downloaded concurrently by using experimental kotlin API. Likely it is not used correctly - a good start point for investigation.

As a user I want to export bill into pdf from law overview screen in mobile app.

Tech:
I didn't saw bill as pdf on public API. As a developer I do not control server side, it provides as is and all attempts to communicate with server side team so far doesn't have feedback. It might be possible to look over site and find not public API for this, another option is to search the web about html to pdf converter.

Note:
This feature request came from google play store.