ebmedart doesn't seem to work about beets-alternatives

[JOJ0]

Hi y'all, I'm actually enjoying a kind of beets coding break as well haha. Thanks for your replies and pointers. Also I found a way to suit my current needs without this plugin. Still I think it would be an essential feature. I might pick it up in the future if need be.

Thanks for maintaining a great plugin to you both!

[JOJ0]

@geigerzaehler just a quick one: Before I have to start reading this plugins' code: See my bulletpoints. Is that the reason embedding art does not work?

[wisp3rwind]

Yes, I'm pretty sure that this is the problem:

beets-alternatives/beetsplug/alternatives.py

Lines 320 to 330 in 288299e

	def sync_art(self, item, path):
	""" Embed artwork in the destination file.
	"""
	album = item.get_album()
	if album:
	if album.artpath and os.path.isfile(syspath(album.artpath)):
	self._log.debug("Embedding art from {} into {}".format(
	displayable_path(album.artpath),
	displayable_path(path)))
	art.embed_item(self._log, item, album.artpath,
	itempath=path)

[geigerzaehler]

As @wisp3rwind has pointed out this plugin only actively embeds album art if the art is stored as a file on disk. Otherwise, as in your case, the plugin relies on the convert plugin to extract the art and embed it in the transcoded target file. You’ve seemed to have configured convert correctly. This means that either this plugin is not using convert correctly or there is an issue with convert itself. (Maybe also a combination of both.)

@JOJ0: I’m not actively committing fixes to this project anymore. Maybe @wisp3rwind is interested in providing a fix. But I would also like to encourage you to dig into the code yourself and see if you can’t find the problem and provide a fix. I’m happy to support your contribution, answer questions and provide reviews.

[wisp3rwind]

@JOJ0: I’m not actively committing fixes to this project anymore. Maybe @wisp3rwind is interested in providing a fix. But I would also like to encourage you to dig into the code yourself and see if you can’t find the problem and provide a fix. I’m happy to support your contribution, answer questions and provide reviews.

Same here: I don't think I'll be able to look into this myself anytime soon (it's also not a problem that I personally encounter in my usage of beets). Happy to review a PR, though!