Comments (3)
Yeah, embed
should really be a per-alternative option. Maybe, for backwards compatibility, it could default to convert.embed
if not set, i.e.
self._embed = config.get(dict).get(
'embed',
convert_plugin.config["embed"].get(bool)
)
In fact, the _embed
handling should probably be moved to the External()
class rather than ExternalConvert()
: You're actually correct that art embedding is not handled consistently. ExternalConvert()
checks convert
s embed option when initially adding items to the library, but it inherits External()
s methods which will embed the art anyway on the next alt update
.
I'll see if I can find some time to fix this, which could then serve as a starting point for your other PR. I won't be able to do so before the weekend, however.
Another approach to the configuration might be to add an alternatives.<name>.sync-art = ["no"|"embed"|"copy"]
option.
from beets-alternatives.
I think the convert.embed option is considered when a song is added to the alternative directory:
https://github.com/geigerzaehler/beets-alternatives/blob/master/beetsplug/alternatives.py#L339
So yes, my expectation is that also beet alt update considers the convert.embed config option.
Stepping back a little, I think it would be better (and easier to implement) to have a separate alternatives.name.embed option. Similar to the copy_album_art option I propose in #58.
from beets-alternatives.
Stepping back a little, I think it would be better (and easier to implement) to have a separate alternatives.name.embed option
For me this seems to be the right way forward, too.
from beets-alternatives.
Related Issues (20)
- Copy album art to destination folder (without embedding) HOT 2
- Create m3u for newly imported tracks HOT 2
- beet alt update doesn't always remove obsolete links HOT 3
- Remove external items when the corresponding item is removed from beets
- Update performance for SymlinkViews
- `beet alt update foo`: FileNotFoundError HOT 1
- Crashes when the destination file exists, but wasn't created by this plugin HOT 1
- Symlink artwork in SymlinkViews?
- Drop Python 2.7 support HOT 3
- Hard link untranscoded files when copied within filesystem HOT 9
- Can't upgrade to 0.10.2 with pip HOT 2
- File exists during link of paths using symlink mode HOT 5
- Failure on case insensitive filesystem when case changes HOT 2
- Encoded files in alt are encoded again during `alt update` HOT 7
- custom paths with inline plugin broken? HOT 2
- ebmedart doesn't seem to work HOT 5
- Every album re-copied on each update HOT 10
- beet alt ballons memory, may lead to OOM HOT 1
- Feature request: update all HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from beets-alternatives.