gdtiti / alembic Goto Github PK

the pickups only support the prefix names "fluid", "smoke", or "particle".  
They should support generic names.

Make IObject usable


jeffs                         -- 2010/09/10 14:38:53
Joe and I think this is done.

Enough documentation to satisfy a .9 release

What steps will reproduce the problem?
1. run the cmake command as recommended
2. It found boost and later say it found the wrong boost version
3.

What is the expected output?
That if finds the Boost library easily

What do you see instead?
It complains that the wrong Boost version was found

What version of the product are you using?
Trunk

On what operating system?
Ubuntu 10.04 x86_64


Please provide any additional information below.

-- Using BOOST_ROOT: /opt/boost/v1.42.0
-- Boost version: 1.42.0
-- Found the following Boost libraries:
--   program_options
--   thread
-- BOOST_VERSION: 0
CMake Error at build/AlembicBoost.cmake:145 (MESSAGE):
  FOUND INCORRECT BOOST VERSION: 1_42
Call Stack (most recent call first):
  CMakeLists.txt:186 (INCLUDE)


-- Configuring incomplete, errors occurred!

[deleted issue]

valgrind reveals a serious problem in AbcCoreAbstract



jeffs                         -- 2010/09/14 15:35:16
==1052== Invalid read of size 4
==1052==    at 0x493229: ReadTestArchive(std::string const&) 
(CoreAbstractPropertyTests.cpp:317)
==1052==    by 0x494C0D: main (CoreAbstractPropertyTests.cpp:487)
==1052==  Address 0x4D469C0 is 0 bytes inside a block of size 8 free'd
==1052==    at 0x4A05130: operator delete(void*) (vg_replace_malloc.c:244)
==1052==    by 0x4C3874: __gnu_cxx::new_allocator<unsigned 
char>::deallocate(unsigned char*, unsigned long) (new_allocator.h:94)
==1052==    by 0x4C38A6: std::_Vector_base<unsigned char, 
std::allocator<unsigned char> >::_M_deallocate(unsigned char*, unsigned long) 
(stl_vector.h:133)
==1052==    by 0x4C3C51: std::_Vector_base<unsigned char, 
std::allocator<unsigned char> >::~_Vector_base() (stl_vector.h:119)
==1052==    by 0x4C3CA8: std::vector<unsigned char, std::allocator<unsigned 
char> >::~vector() (stl_vector.h:272)
==1052==    by 0x4C3CCD: 
Alembic::AbcCoreAbstract::v1::ArraySampleBytes::~ArraySampleBytes() 
(ArraySampleBytes.h:54)
==1052==    by 0x4C3D00: 
boost::detail::sp_ms_deleter<Alembic::AbcCoreAbstract::v1::ArraySampleBytes>::de
stroy() (make_shared.hpp:52)
==1052==    by 0x4C3D22: 
boost::detail::sp_ms_deleter<Alembic::AbcCoreAbstract::v1::ArraySampleBytes>::op
erator()(Alembic::AbcCoreAbstract::v1::ArraySampleBytes*) (make_shared.hpp:75)
==1052==    by 0x4C3D46: 
boost::detail::sp_counted_impl_pd<Alembic::AbcCoreAbstract::v1::ArraySampleBytes
*, boost::detail::sp_ms_deleter<Alembic::AbcCoreAbstract::v1::ArraySampleBytes> 
>::dispose(
) (sp_counted_impl.hpp:144)
==1052==    by 0x494E29: boost::detail::sp_counted_base::release() 
(sp_counted_base_gcc_x86.hpp:145)
==1052==    by 0x494E6F: boost::detail::shared_count::~shared_count() 
(shared_count.hpp:217)
==1052==    by 0x4AC434: 
boost::shared_ptr<Alembic::AbcCoreAbstract::v1::ArraySampleBytes>::~shared_ptr()
 (shared_ptr.hpp:169)

tbd how but need string props

I just cloned the head revision, got all the dependencies setup, tried to build 
and it fails:

error: no matching function for call to 
âAlembic::Asset::OPropertyTrait<Alembic::Asset::OTypedMultiProperty<Alembic::As
set::TypedPropertyTraits<Imath::Vec3<float>, 
(Alembic::Util::PlainOldDataType)10u, 3ul> >, 
Alembic::TraitsGeom::PositionsStrait>::set(const Alembic::Asset::V3d*, 
size_t&)â

Is this a known issue, or is it a problem with my setup?

--
Jeremy

Purpose of code changes on this branch:
No code changes, just trying to explore the tools for doing reviews.

When reviewing my code changes, please focus on:

The comments in:
http://code.google.com/r/millerlucas-dev/source/detail?r=cbc83a524b7bab280b4651e
3d8e01e76ba40d634


After the review, I'll merge this branch into:
Nowhere, it's already been merged into trunk.

This works:
   mass.set( mm,  OSampleSelector(tt) );  // write sample # tt at time 0 + dt*tt
This dies:
  mass.set( mm,  OSampleSelector(tt, 400.0 + tt*dt ) );
with:
terminate called after throwing an instance of 'Alembic::Util::Exception'
  what():  Invalid rank in timeSamples attr read

In Util/Dimensions.h the following assert
    BOOST_STATIC_ASSERT( sizeof( MySizeT ) == sizeof( T ) );
prevents us from compiling Alembic on 32 bit architectures. This may only be 
the beginning of the difficulties.

Samples look as if they are written out with starting times other than zero, 
but they are not.

Right now, on the alembic.io page, and on the front page of the Google Code 
site, there's not indication as to who Rob and Richard are.

Also, on the alembic.io page, it looks like the message was truncated, as 
there's no indication that the line that says "Richard Kerris and Rob Bredow" 
is supposed to be a signature.

[ 30%] Building CXX object 
lib/Alembic/AbcCoreHDF5/CMakeFiles/AlembicAbcCoreHDF5.dir/AprImpl.cpp.o
cd 
/Users/shaegler/Documents/procedural/libs/alembic_build/lib/Alembic/AbcCoreHDF5 
&& /usr/bin/c++   -DNDEBUG=1 -DPLATFORM_DARWIN -DPLATFORM=DARWIN -Wreturn-type 
-Werror -O3 -DNDEBUG -I/opt/local/include -I/opt/local/include/OpenEXR 
-I/Users/shaegler/Documents/procedural/libs/hdf5-1.8.5-patch1-macosx64-static/in
clude -I/Users/shaegler/Documents/procedural/libs/Alembic_0.9.0/lib   -UDEBUG 
-O3 -o CMakeFiles/AlembicAbcCoreHDF5.dir/AprImpl.cpp.o -c 
/Users/shaegler/Documents/procedural/libs/Alembic_0.9.0/lib/Alembic/AbcCoreHDF5/
AprImpl.cpp
In file included from 
/Users/shaegler/Documents/procedural/libs/Alembic_0.9.0/lib/Alembic/AbcCoreHDF5/
AprImpl.h:41,
                 from /Users/shaegler/Documents/procedural/libs/Alembic_0.9.0/lib/Alembic/AbcCoreHDF5/AprImpl.cpp:37:
/Users/shaegler/Documents/procedural/libs/Alembic_0.9.0/lib/Alembic/AbcCoreHDF5/
SimplePrImpl.h: In member function ‘virtual void 
Alembic::AbcCoreHDF5::SimplePrImpl<ABSTRACT, IMPL, 
SAMPLE>::getSample(Alembic::AbcCoreAbstract::v1::index_t, SAMPLE)’:
/Users/shaegler/Documents/procedural/libs/Alembic_0.9.0/lib/Alembic/AbcCoreHDF5/
SimplePrImpl.h:343: error: there are no arguments to ‘H5Aexists’ that 
depend on a template parameter, so a declaration of ‘H5Aexists’ must be 
available
/Users/shaegler/Documents/procedural/libs/Alembic_0.9.0/lib/Alembic/AbcCoreHDF5/
SimplePrImpl.h:343: error: (if you use ‘-fpermissive’, G++ will accept your 
code, but allowing the use of an undeclared name is deprecated)
/Users/shaegler/Documents/procedural/libs/Alembic_0.9.0/lib/Alembic/AbcCoreHDF5/
SimplePrImpl.h:372: error: there are no arguments to ‘H5Gopen2’ that depend 
on a template parameter, so a declaration of ‘H5Gopen2’ must be available
/Users/shaegler/Documents/procedural/libs/Alembic_0.9.0/lib/Alembic/AbcCoreHDF5/
SimplePrImpl.h: In member function ‘void 
Alembic::AbcCoreHDF5::SimplePrImpl<ABSTRACT, IMPL, 
SAMPLE>::getSample(Alembic::AbcCoreAbstract::v1::index_t, SAMPLE) [with 
ABSTRACT = Alembic::AbcCoreAbstract::v1::ArrayPropertyReader, IMPL = 
Alembic::AbcCoreHDF5::AprImpl, SAMPLE = 
Alembic::AbcCoreAbstract::v1::ArraySamplePtr&]’:
/Users/shaegler/Documents/procedural/libs/Alembic_0.9.0/lib/Alembic/AbcCoreHDF5/
AprImpl.cpp:78:   instantiated from here
/Users/shaegler/Documents/procedural/libs/Alembic_0.9.0/lib/Alembic/AbcCoreHDF5/
SimplePrImpl.h:343: error: ‘H5Aexists’ was not declared in this scope
/Users/shaegler/Documents/procedural/libs/Alembic_0.9.0/lib/Alembic/AbcCoreHDF5/
SimplePrImpl.h:370: error: ‘H5Gopen2’ was not declared in this scope
make[2]: *** 
[lib/Alembic/AbcCoreHDF5/CMakeFiles/AlembicAbcCoreHDF5.dir/AprImpl.cpp.o] Error 
1
make[1]: *** [lib/Alembic/AbcCoreHDF5/CMakeFiles/AlembicAbcCoreHDF5.dir/all] 
Error 2
make: *** [all] Error 2


this looks like an include issue, but i am not familiar with hdf5 at all to fix 
this easily on my own...

[deleted issue]

[deleted issue]

Sony running tests adequate for .9

Hey gang, I'm trying to build the source based on the readme and there seems to 
be a function error, here's the error output.

http://pastebin.com/sXC66Yh8

Test bug - please ignore

valgrind reveals a serious problem in AbcCoreAbstract

==18956== Invalid read of size 8
==18956==    at 0x4AD989: 
Alembic::AbcCoreAbstract::v1::TimeSampling::getSampleTime(long) const (in 
/home/jeffs/src_alembictako/alembic_build/lib/Alembic/AbcNice/Tests/AbcNice_Prop
ertyTests)
==18956==    by 0x447751: void 
reportTimeSampling<Alembic::AbcNice::ITypedScalarProperty<Alembic::AbcNice::Type
dPropertyTraits<double, (Alembic::Util::PlainOldDataType)11, 1l> > 
>(Alembic::AbcNice::ITypedScalarProperty<Alembic::AbcNice::TypedPropertyTraits<d
ouble, (Alembic::Util::PlainOldDataType)11, 1l> >&) (in 
/home/jeffs/src_alembictako/alembic_build/lib/Alembic/AbcNice/Tests/AbcNice_Prop
ertyTests)
==18956==    by 0x44516E: readSimpleProperties(std::string const&) (in 
/home/jeffs/src_alembictako/alembic_build/lib/Alembic/AbcNice/Tests/AbcNice_Prop
ertyTests)
==18956==    by 0x445E26: main (in 
/home/jeffs/src_alembictako/alembic_build/lib/Alembic/AbcNice/Tests/AbcNice_Prop
ertyTests)
==18956==  Address 0x4DC56E8 is 0 bytes inside a block of size 8 free'd
==18956==    at 0x4A05130: operator delete(void*) (vg_replace_malloc.c:244)
==18956==    by 0x484BF5: 
boost::detail::sp_counted_impl_pd<Alembic::AbcCoreAbstract::v1::ArraySampleBytes
*, boost::detail::sp_ms_deleter<Alembic::AbcCoreAbstract::v1::ArraySampleBytes> 
>::dispose() (in 
/home/jeffs/src_alembictako/alembic_build/lib/Alembic/AbcNice/Tests/AbcNice_Prop
ertyTests)
==18956==    by 0x445FAE: boost::detail::shared_count::~shared_count() (in 
/home/jeffs/src_alembictako/alembic_build/lib/Alembic/AbcNice/Tests/AbcNice_Prop
ertyTests)
==18956==    by 0x481FA5: 
Alembic::AbcCoreHDF5::ReadTimeSamples(boost::shared_ptr<Alembic::AbcCoreAbstract
::v1::ReadArraySampleCache>, Alembic::HDF5::Group&, std::string const&, 
Alembic::AbcCoreAbstract::v1::ReadArraySampleID&) (in 
/home/jeffs/src_alembictako/alembic_build/lib/Alembic/AbcNice/Tests/AbcNice_Prop
ertyTests)
==18956==    by 0x499BFC: 
Alembic::AbcCoreHDF5::SimplePrImpl<Alembic::AbcCoreAbstract::v1::ScalarPropertyR
eader, Alembic::AbcCoreHDF5::SprImpl, unsigned char*>::getTimeSampling() (in 
/home/jeffs/src_alembictako/alembic_build/lib/Alembic/AbcNice/Tests/AbcNice_Prop
ertyTests)
==18956==    by 0x4476B8: void 
reportTimeSampling<Alembic::AbcNice::ITypedScalarProperty<Alembic::AbcNice::Type
dPropertyTraits<double, (Alembic::Util::PlainOldDataType)11, 1l> > 
>(Alembic::AbcNice::ITypedScalarProperty<Alembic::AbcNice::TypedPropertyTraits<d
ouble, (Alembic::Util::PlainOldDataType)11, 1l> >&) (in 
/home/jeffs/src_alembictako/alembic_build/lib/Alembic/AbcNice/Tests/AbcNice_Prop
ertyTests)
==18956==    by 0x44516E: readSimpleProperties(std::string const&) (in 
/home/jeffs/src_alembictako/alembic_build/lib/Alembic/AbcNice/Tests/AbcNice_Prop
ertyTests)
==18956==    by 0x445E26: main (in 
/home/jeffs/src_alembictako/alembic_build/lib/Alembic/AbcNice/Tests/AbcNice_Prop
ertyTests)

Corresponding time samples for acyclic and cyclic types do not store properly.

Need to use the http data api, as outlined here:

http://code.google.com/p/support/wiki/IssueTrackerAPI#Retrieving_all_issues
http://code.google.com/p/support/wiki/IssueTrackerAPI#Creating_issues
http://code.google.com/p/support/wiki/IssueTrackerAPI#Modifying_an_issue_or_crea
ting_issue_comments

Our assumption is that we'll be writing most of the docs. We'd like to have 
Sony review, edit, and approve as necessary.

Make OObject usable


jeffs                         -- 2010/09/10 14:39:02
Joe and I think this is done.

Cannot write properties of the with the following POD types:
 Alembic::Util::kBooleanPOD
 Alembic::Util::kFloat16POD
 Alembic::Util::kCStringPOD

Make IScalarProperty usable


jeffs                         -- 2010/09/22 14:12:41
Some templated functions may need to be written by the user to use 
IScalarProperty most efficiently

BoundArraySampleDeleter's operator() class (which deletes allocated Array 
Sample memory) is never called.

valgrind reveals what may be a bug in AbcCoreHDF5


==19711== 26 errors in context 1 of 1:
==19711== Source and destination overlap in memcpy(0x4D0F138, 0x4D0F138, 11)
==19711==    at 0x4A07073: memcpy (mc_replace_strmem.c:116)
==19711==    by 0x5AEF34: H5O_attr_write_cb (in 
/home/jardent/alembic_build/lib/Alembic/AbcCoreAbstract/Tests/AbcCoreAbstractTes
ts)
==19711==    by 0x5C2FDD: H5O_msg_iterate_real (in 
/home/jardent/alembic_build/lib/Alembic/AbcCoreAbstract/Tests/AbcCoreAbstractTes
ts)
==19711==    by 0x5AE5FD: H5O_attr_write (in 
/home/jardent/alembic_build/lib/Alembic/AbcCoreAbstract/Tests/AbcCoreAbstractTes
ts)
==19711==    by 0x50C9F7: H5Awrite (in 
/home/jardent/alembic_build/lib/Alembic/AbcCoreAbstract/Tests/AbcCoreAbstractTes
ts)
==19711==    by 0x4EED7B: 
Alembic::HDF5::Attribute::writeAll(Alembic::HDF5::Datatype const&, void const*) 
(Attribute.cpp:269)
==19711==    by 0x4C6F73: 
Alembic::AbcCoreHDF5::WriteString(Alembic::HDF5::AttributedObject&, std::string 
const&, std::string const&) (WriteUtil.cpp:111)
==19711==    by 0x4C7097: 
Alembic::AbcCoreHDF5::WriteMetaData(Alembic::HDF5::Group&, std::string const&, 
Alembic::AbcCoreAbstract::v1::MetaData const&) (WriteUtil.cpp:157)
==19711==    by 0x4B9747: 
Alembic::AbcCoreHDF5::OwImpl::init(Alembic::HDF5::Group&) (OwImpl.cpp:110)
==19711==    by 0x4B9BBB: 
Alembic::AbcCoreHDF5::OwImpl::OwImpl(boost::shared_ptr<Alembic::AbcCoreAbstract:
:v1::ArchiveWriter>, Alembic::HDF5::Group&, 
Alembic::AbcCoreAbstract::v1::MetaData const&) (OwImpl.cpp:81)
==19711==    by 0x4A9283: 
Alembic::AbcCoreHDF5::AwImpl::getTop(Alembic::AbcCoreAbstract::v1::MetaData 
const&) (AwImpl.cpp:95)
==19711==    by 0x499CC2: Alembic::AbcCoreHDF5::WriteArchive(std::string 
const&, Alembic::AbcCoreAbstract::v1::MetaData const&) (ReadWrite.cpp:71)

Make OCompoundProperty usable

Just a general issue being tracked here to collect all the steps required to 
get this building on Windows.

To start, you need:

1) a 64-bit compiler, preferably one that was used to build Maya (VC++ 9.0?)

2) The following Boost libraries, static and multi-threaded, 64-bit:
   - libboost_program_options
   - libboost_thread

3) hdf5.lib and hdf5_hl.lib (static, thread-safe, C-only, 64-bit)

4) 64-bit zlib (need this for HDF5)

5) 64-bit ilmbase libs, statically linked.

6) CMake 2.8

Once these things are done, we can start trying to build Alembic itself :)

What steps will reproduce the problem?
1. Follow instructions to build Alembic via bootstrap method
    python ../build/bootstrap/alembic_bootstrap.py
2. During bootstrap set paths accordingly

What is the expected output? What do you see instead?
Expected to successfully bootstrap the build process

Instead the following error appears:
CMake Error at CMakeLists.txt:187 (MESSAGE):
  Boost version 1.42.0 found.  Require 1.42.0.  Check your BOOST_ROOT
  environment variable.

What version of the product are you using? On what operating system?
Alembic 0.9.0 on Centos 5.3 x86_64

Please provide any additional information below.
It would appear that in CMakeLists.txt the boost check cannot pass unless 
ALEMBIC_BOOST_FOUND is true. If BOOST_FOUND is true, regardless of what version 
of Boost is found, it will error.

ILM to run tests as well simultaneously with Sony

[deleted issue]

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.

These methods were calling the ?Object constructors with an invalid argument 
set.  I've fixed them both in my dev repo:

http://code.google.com/r/ardent-embic/source/detail?r=e470fe4cc3261a30c478a703dc
1672584308846b

Purpose of code changes on this branch:


When reviewing my code changes, please focus on:
WriteSampleID improvements done here:
http://code.google.com/r/millerlucas-dev/source/detail?r=3d72463d0e36f5841c272f6
31d30ae0af6917dff

The rest of the changes should be relatively uncontroversial as they are some 
low risk HDF5 usage cleanups.

After the review, someone will merge this branch into:
/default
/point9

Hey Brian, I changed the wording a little on the Feedback page; can you look 
them over?

Make IArchive usable

jeffs                         -- 2010/09/10 14:38:32
Joe and I think this is done.

[deleted issue]

What steps will reproduce the problem?
1. Export an abc file from Maya using supplied exporter
2. Specify frame range 1-24, all else default
3. Attempt to open saved abc file with SimpleAbcViewer

What is the expected output? What do you see instead?
I get the following error:
Beginning to open archive: /tmp/alembictest.abc
HDF5-DIAG: Error detected in HDF5 (1.8.5-patch1) thread 0:
  #000: H5F.c line 1509 in H5Fopen(): unable to open file
    major: File accessability
    minor: Unable to open file
  #001: H5F.c line 1300 in H5F_open(): unable to read superblock
    major: File accessability
    minor: Read failed
  #002: H5Fsuper.c line 324 in H5F_super_read(): unable to load superblock
    major: Object cache
    minor: Unable to protect metadata
  #003: H5AC.c line 1597 in H5AC_protect(): H5C_protect() failed.
    major: Object cache
    minor: Unable to protect metadata
  #004: H5C.c line 3333 in H5C_protect(): can't load entry
    major: Object cache
    minor: Unable to load metadata into cache
  #005: H5C.c line 8177 in H5C_load_entry(): unable to load entry
    major: Object cache
    minor: Unable to load metadata into cache
  #006: H5Fsuper_cache.c line 469 in H5F_sblock_load(): truncated file
    major: File accessability
    minor: File has been truncated
EXCEPTION: IArchive::IArchive( iFileName )
ERROR: EXCEPTION:
Could not open file: /tmp/alembictest.abc

What version of the product are you using? On what operating system?
0.9.0 Linux Centos 5.3

Please provide any additional information below.
Example file attached

./Sven

Lots of the uploaded files seem to be incomplete eg

http://code.google.com/p/alembic/source/browse/lib/Alembic/AbcCore/StaticScalarP
roperty.h
http://code.google.com/p/alembic/source/browse/lib/Alembic/AbcCoreHDF5/BasePrope
rtyReaderMixin.h

-Drew

Make ICompoundProperty usable

Make OScalarProperty usable

ArrayProperties should handle empty samples

Make OArrayProperty usable

[deleted issue]

Make IArrayProperty usable

Make OArchive usable

jeffs                         -- 2010/09/10 14:38:44
Joe and I think this is done.

Basically, we just need to add the following methods:

OTypedArrayProperty::setRank()
OTypedArrayProperty::getRank()
ITypedArrayProperty::getRank()

See Util/Dimensions.h and 
http://code.google.com/p/alembic/source/browse/lib/Alembic/Util/Tests/Dimensions
TestJeffs.cpp for examples of manipulating this.

Then, in the OTypedArrayProperty::set() method, we just need to set up the for 
loops to properly interleave the data, and do the right thing in 
ITypedArrayProperty::get() to read it correctly.

I *think*.  This may require a bit of smartness/changes in 
Abc::TypedArraySample as well.

[deleted issue]