gdotdesign / cr-dotenv Goto Github PK

View Code? Open in Web Editor NEW

94.0 4.0 11.0 51 KB

Loads ".env" files

License: MIT License

Crystal 100.00%

crystallang dotenv

cr-dotenv's People

Contributors

Stargazers

Watchers

Forkers

neovintage bonyiii tmilewski chipper1 rodrigopinto onyxframework washu jwoertink bcardiff jgaskins kalinon

cr-dotenv's Issues

Not override existing variables

Now it override existing variables, it should by default not load variable from .env if variable already defined. Other implementations works in this way.

ruby https://github.com/bkeepers/dotenv#why-is-it-not-overriding-existing-env-variables

nodejs https://www.npmjs.com/package/dotenv#what-happens-to-environment-variables-that-were-already-set

Ignore Quotes

Quotes should be handled

now

NAME="value"

loaded as in code as

ENV["NAME"] == "\"value\""

it should be

ENV["NAME"] == "value"

Overriding a loaded env

Is there a way to override the ENV once it's loaded?

#.env
DB_URL=postgres://localhost:5432/dev

#.env.test
DB_URL=postgres://localhost:5432/test

require "dotenv"

Dotenv.load
Dotenv.load ".env.test"

puts ENV["DB_URL"]? #=> postgres://localhost:5432/dev

Shards update broken on Crystal 1.0

Currently on doing shards update, I am getting a missing version warning;

rishav@rishav-sbook:~/digglu$ shards update
Resolving dependencies
Fetching https://github.com/will/crystal-pg.git
Fetching https://github.com/gdotdesign/cr-dotenv.git
Fetching https://github.com/crystal-community/jwt.git
Fetching https://github.com/evanhahn/crystal-helmet.git
Fetching https://github.com/crystal-lang/crystal-db.git
Fetching https://github.com/spider-gazelle/openssl_ext.git
Unable to satisfy the following requirements:

- `crystal (>= 0.35.0, < 2.0.0)` required by `pg 0.23.2`
- `crystal (>= 0.34.0, < 2.0.0)` required by `dotenv 1.0.0`
- `crystal (>= 0.36.1)` required by `jwt 1.5.1`
- `crystal (< 1.0.0)` required by `helmet 0.2.2`
- `crystal (>= 0.35.0, < 2.0.0)` required by `db 0.10.1`
- `crystal (>= 0.36.1)` required by `openssl_ext 2.1.4`
Failed to resolve dependencies, try updating incompatible shards or use --ignore-crystal-version as a workaround if no update is available.

There more info here https://forum.crystal-lang.org/t/weird-shards-outdated-output-crystal-1-0-0/3065
Essentially this is an explicit check to ensure that a library works with Crystal 1.0

Releases

Please add GitHub releases regarding to crystal-lang/shards#161.

error with crystal 0.34

I get this compile error with crystal 0.34

Unhandled exception: Parse error on line 2:5 (Dotenv::Parser::Error)
  from lib/dotenv/src/parser.cr:33:11 in 'parse'
  from lib/dotenv/src/dotenv.cr:24:5 in 'parse'
  from lib/dotenv/src/dotenv.cr:114:7 in 'load'

File descriptor leak

I noticed in the code you do File.open but never close the file. That file descriptor will be forever occupied for the rest of the program.

cr-dotenv/src/dotenv.cr

Line 99 in ca17a9b

File.open(File.expand_path(filename))

Please consider using the block form, File.open(filename) { do_something_here } to make sure the file is closed after you use it.

gdotdesign / cr-dotenv Goto Github PK

cr-dotenv's People

Contributors

Stargazers

Watchers

Forkers

cr-dotenv's Issues

Not override existing variables

Ignore Quotes

Overriding a loaded env

Shards update broken on Crystal 1.0

Releases

error with crystal 0.34

File descriptor leak

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent