gchq / concoursetools Goto Github PK

There are a few use cases where strings passed by users within the pipeline should be populated with build metadata values. A convenience function in the BuildMetadata class would be a great way of doing this, provided we take care to avoid remote code execution and other gotchas. The build url should also be made available this way.

Currently the base image is always python3.8-alpine, but should be set to python3.11-alpine if the user runs python3.11 -m concoursetools . --docker.

It is possible to have a resource with no source, and this should be treated as an empty source configuration. However, Concourse currently passes this as None, which means that concoursetools.parsing.parse_check_payload fails on line 41. Instead of

try:
    unsafe_source_config = payload["source"]
except KeyError as error:
    raise RuntimeError("Could not extract source from payload") from error
else:
    source_config = {str(key): value for key, value in unsafe_source_config.items()}

we should do:

try:
    unsafe_source_config = payload["source"]
except KeyError as error:
    raise RuntimeError("Could not extract source from payload") from error
else:
    try:
        source_config = {str(key): value for key, value in unsafe_source_config.items()}
    except AttributeError:
        if unsafe_source_config is not None:
            raise
        source_config = {}