Comments (3)
alexlafroscia
commented on May 23, 2024
Maybe it should only re-focus the button on ESC (once #54 is fixed)? Or if the element clicked on is not itself interactive?
from ember-headlessui.
achambers
commented on May 23, 2024
Maybe it should only re-focus the button on
ESC(once #54 is fixed)? Or if the element clicked on is not itself interactive?
Both reasonable suggestions to me. Which do you prefer @alexlafroscia ?
from ember-headlessui.
alexlafroscia
commented on May 23, 2024
#58 fixes this by allowing a focus-trap on the Menu::Items element (which should have a focus trap and currently does not) handle re-focusing the previous element, so the behavior becomes "whatever focustrap.js does by default", which is probably good enough! It seems to work nicely from what I can tell but I haven't tried multiple menus adjacent to each other where we bounce between them. Could you try pulling that PR and seeing if the way it handles things feels good in the example that you showed here?
from ember-headlessui.
Related Issues (20)
- Remove unused `@key` from `ListBox` sample code
- Implement `<RadioGroup>` component HOT 4
- Error in Embroider enabled apps using `@tagName` with `<Menu>` HOT 4
- Document Testing Best-Practices
- Some tests fail after upgrading `ember-auto-import` HOT 6
- Not compatible with ember 4 HOT 1
- Closing issue when using powerselect inside a dialog HOT 3
- Docs for using Tailwind HOT 4
- Implement Disclosure component HOT 7
- Bump `@embroider/macros` HOT 5
- Feedback welcome
- Transitions are throwing errors in Fastboot
- Move menu focus trap to containing element
- Implement <ComboBox> component HOT 2
- Build is broken due to external dependency hell HOT 10
- release config broken: Could not infer "repo" from the "package.json" file. HOT 2
- Click on `dialog.Overlay` does not close the modal HOT 1
- TypeError: can't convert value to string
- BUG: click outside <Dialog /> should be allowed HOT 6
- `<Transition>` with `<Dialog>` breaks clicking the overlay to close HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-headlessui.