Comments (10)
yeah, octokit (or release-it) needs to fix that -- nothing we can really do here
from ember-headlessui.
Indeed. I guess no harm here unless someone is using ember-headlessui@latest
yeah, octokit (or release-it) needs to fix that -- nothing we can really do here
We cannot release new version of ember-headlessui
until that is fixed.
from ember-headlessui.
We cannot release new version of ember-headlessui until that is fixed.
correct.
@octokit/rest
- https://github.com/octokit/rest.js/blob/master/package.json#L36- specified
@octokit/core
v4 on the line above - latest https://github.com/octokit/plugin-paginate-rest.js/blob/master/package.json#L31 has correct peer.
- specified
So why do we have 3.6.0?
❯ pnpm -r why @octokit/core
[email protected] /home/nullvoxpopuli/Development/NullVoxPopuli/ember-headlessui/ember-headlessui
devDependencies:
release-it 14.14.3
└─┬ @octokit/rest 18.12.0
├── @octokit/core 3.6.0
├─┬ @octokit/plugin-paginate-rest 2.21.1
│ └── @octokit/core 3.6.0 peer
├─┬ @octokit/plugin-request-log 1.0.4
│ └── @octokit/core 3.6.0 peer
└─┬ @octokit/plugin-rest-endpoint-methods 5.13.0
└── @octokit/core 3.6.0 peer
release-it-lerna-changelog 3.1.0
└─┬ release-it 14.14.3 peer
└─┬ @octokit/rest 18.12.0
├── @octokit/core 3.6.0
├─┬ @octokit/plugin-paginate-rest 2.21.1
│ └── @octokit/core 3.6.0 peer
├─┬ @octokit/plugin-request-log 1.0.4
│ └── @octokit/core 3.6.0 peer
└─┬ @octokit/plugin-rest-endpoint-methods 5.13.0
└── @octokit/core 3.6.0 peer
latest release-it is 15.1.1, we are not using that -- so maybe the problem is release-it. Let's upgrade that
from ember-headlessui.
I upgraded release-it, but release-it-lerna-changelog has not been updated
ember-headlessui
├─┬ release-it
│ └─┬ @octokit/rest
│ └─┬ @octokit/plugin-paginate-rest
│ └── ✕ unmet peer @octokit/core@>=4: found 3.6.0 in @octokit/rest
└─┬ release-it-lerna-changelog
└── ✕ unmet peer release-it@^14.0.0: found 15.1.1
from ember-headlessui.
There is already an issue: release-it-plugins/lerna-changelog#203
But rwjblue is on vacation, I think
from ember-headlessui.
ah ok, so release-it is using @octokit/rest v18, instead of v19
from ember-headlessui.
This should resolve : #161
from ember-headlessui.
Nice one! I went down that road but wasn't sure on our "policy" on using forks.
from ember-headlessui.
it's a dev-time tool, so it's not going to affect our users
from ember-headlessui.
resolved by: #163
from ember-headlessui.
Related Issues (20)
- Remove unused `@key` from `ListBox` sample code
- Implement `<RadioGroup>` component HOT 4
- Error in Embroider enabled apps using `@tagName` with `<Menu>` HOT 4
- Document Testing Best-Practices
- Some tests fail after upgrading `ember-auto-import` HOT 6
- Not compatible with ember 4 HOT 1
- Closing issue when using powerselect inside a dialog HOT 3
- Docs for using Tailwind HOT 4
- Implement Disclosure component HOT 7
- Bump `@embroider/macros` HOT 5
- Feedback welcome
- Transitions are throwing errors in Fastboot
- Move menu focus trap to containing element
- Implement <ComboBox> component HOT 2
- release config broken: Could not infer "repo" from the "package.json" file. HOT 2
- Click on `dialog.Overlay` does not close the modal HOT 1
- TypeError: can't convert value to string
- BUG: click outside <Dialog /> should be allowed HOT 6
- `<Transition>` with `<Dialog>` breaks clicking the overlay to close HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-headlessui.