gandag / pynxm Goto Github PK

Hey Ganda :)

We'll eventually want Wrye Bash to either depend on this or to merge it into the Wrye Bash codebase. Unfortunately, the Apache 2.0 license used for pynxm currently makes this impossible since Wrye Bash uses the GPLv2:

Despite our best efforts, the FSF has never considered the Apache License to be compatible with GPL version 2, citing the patent termination and indemnification provisions as restrictions not present in the older GPL license. The Apache Software Foundation believes that you should always try to obey the constraints expressed by the copyright holder when redistributing their work.

So the best solution would be to either switch the license to something that's compatible with GPLv2 (MIT/BSD/LGPLv2.1/GPLv2) or to dual-license under one of those.

Granted, we've technically been violating libloot-python's license (GPLv3) for years by packaging it with a GPLv2 program - thankfully Ortham is highly unlikely to complain about that :P. Still, I don't exactly want to violate more licenses now.

Thanks!

First thanks for the package!

FWIW:

Traceback (most recent call last):
  File ".\pynxm_test.py", line 9, in <module>
    print(nexus.game_list())
  File "D:\git\skyrim-builder\venv\lib\site-packages\pynxm.py", line 190, in game_list
    "get", "games.json", payload={"include_unapproved": include_unapproved}
  File "D:\git\skyrim-builder\venv\lib\site-packages\pynxm.py", line 117, in _make_request
    raise RequestError("Status Code {} - {}".format(status_code, msg))
pynxm.RequestError: Status Code 422 - Invalid parameter 'include_unapproved' value "False": Must be one of: <code>true</code>, <code>false</code>, <code>1</code>, <code>0</code>.

Looks like values get cast to strings and if a word boolean needs to have lower case first letter.

Reproducible with latest pip install pynxm (0.1.0)