games50 / pokemon Goto Github PK

Issue:

The game crashes after running away when the player keeps pressing enter during the transition from the battle state to the play state.

Repro:

1 Start game
2 Dismiss introduction message
3 Go to the tall grass and start a fight
4 Select Run from the battle menu
5 Keep pressing enter while the transition is happening
6 Crash: Error

src/states/StateStack.lua:16: attempt to index a nil value

Traceback

src/states/StateStack.lua:16: in function 'update'
main.lua:85: in function 'update'
[C]: in function 'xpcall'

Fix:

In BattleMenuState.Lua line 38 the closing parenthesis is in the wrong position so the flag for user input is not properly turned off
change function() end), false) to function() end, false))