Coder Social home page Coder Social logo

Comments (7)

Rabadash8820 avatar Rabadash8820 commented on August 22, 2024 1

Hey @webbertakken, sorry for the radio silence! It looks like #10 is indeed the change that I requested, however its still not working for me because I am trying to build for Android, and your Actions don't yet support Android. That's beyond the scope of this Issue though.

I hope to do more troubleshooting of the Android build failures soon; I just haven't been super motivated to recently because Unity Cloud Build has been meeting my project's CI needs (I only started exploring GitHub Actions when Cloud Build didn't have the Unity Version that I needed, and now it does).

from unity-test-runner.

webbertakken avatar webbertakken commented on August 22, 2024

Hi @Rabadash8820,

Thank you. Yes, this is planned. The implementation will probably be based on builder. I was going to wait for builder to become stable before starting it, but do feel free to send a PR if you feel up for it.

The reason for working with the with keyword is that it's simpler for end users and that there's a JavaScript api in actions to convert INPUT_* to variables. Manually providing INPUT_* felt awkward to me and sticking with ENV too.

from unity-test-runner.

Rabadash8820 avatar Rabadash8820 commented on August 22, 2024

@webbertakken Thanks for the reply! Sounds good. I'm still quite new to GitHub Actions (the repo to which I just added your actions is actually my first use of them), but I'm getting more familiar with it, and would certainly rather than help on an already established project than build my own actions from scratch 😛

Regarding with vs env, does that mean you will probably migrate your other actions besides Builder to with also?

from unity-test-runner.

webbertakken avatar webbertakken commented on August 22, 2024

@Rabadash8820 sounds great!

Regarding with vs env, does that mean you will probably migrate your other actions besides Builder to with also?

That would be goal if it works well (which it seems to do for now). Multi platform and multi version actions are highest priority for now. The with part we can do as part of moving to multi version/platform or after. I was thinking of not doing it before, in order to keep the older versions consistent.

from unity-test-runner.

Rabadash8820 avatar Rabadash8820 commented on August 22, 2024

Ok, thanks for the info. I'll leave it up to you whether you want to close this Issue now or wait til different version support is added.

from unity-test-runner.

webbertakken avatar webbertakken commented on August 22, 2024

@Rabadash8820 this is fixed in #10 and released in test runner v1.2

Please let me know if you can work with this.

from unity-test-runner.

webbertakken avatar webbertakken commented on August 22, 2024

@Rabadash8820 good to hear from you again! I'm happy to hear you've found a suitable CI for your project! Of course feel free to share any information that might help us implement proper android support for Unity Actions.

from unity-test-runner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.