Coder Social home page Coder Social logo

Comments (6)

jsm174 avatar jsm174 commented on August 22, 2024 1

Sounds good. Thanks!

I will create a separate repo that pulls everything in with the correct directory structure and see what happens.

from unity-test-runner.

webbertakken avatar webbertakken commented on August 22, 2024

Hi @jsm174 and thank you for posting about your issue with Test-runner.

So you are getting the artifact as you expected, it's just that in your workflow it doesn't upload it because the upload job never runs:

image

See Github Actions docs for conditional job to solve your issue.

from unity-test-runner.

jsm174 avatar jsm174 commented on August 22, 2024

Thank you. I apologize. I didn't really think about that since I was just following the example.

I did add an if condition, but it's still failing. I'll need to research it some more.

 - uses: actions/upload-artifact@v1
        if: ${{ always() }}
        with:
          name: Test results for ${{ matrix.testMode }}
          path: ${{ steps.tests.outputs.artifactsPath }}

Screen Shot 2020-06-27 at 11 22 59 AM

from unity-test-runner.

webbertakken avatar webbertakken commented on August 22, 2024

After you added the if condition, the upload job started triggering when the test job failed, as expected.

Currently you need to correctly configure path

image

There is a working example of this in the readme and in the workflow of this repository.

from unity-test-runner.

jsm174 avatar jsm174 commented on August 22, 2024

I did follow all your documentation.

So just to make sure I'm not crazy, I just made the file match up exactly with the one from your repo:

https://github.com/jsm174/vpe_net_standard/blob/48e6c4a6e2773c58b16c265502882d1c9930fbb9/.github/workflows/main.yml

Same error

https://github.com/jsm174/vpe_net_standard/runs/814289122?check_suite_focus=true

from unity-test-runner.

webbertakken avatar webbertakken commented on August 22, 2024

Great! Then you should be close to getting it working, as the docs seem to work for many people. See also the recommendations in the other ticket to get the package to work.

I just made the file match up exactly with the one from your repo:

With the two major differences that your project path is both nested and considered hidden within Unity.

As discussed here in your other issue, using temporary or hidden folders as your project folder is not supported in Unity itself, so it will also be impossible to support it in this project.

The workflow from this repository also does not take those two things into account, so naturally it wouldn't work out of the box.

I will close this issue as both your questions have been answered, but please feel free to create a new ticket if you find that there is indeed something broken in Test runner.

from unity-test-runner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.