Coder Social home page Coder Social logo

Comments (13)

litefeel avatar litefeel commented on August 22, 2024 1

Fix it #112

from unity-test-runner.

pixelpax avatar pixelpax commented on August 22, 2024 1

Thank you for your help and patience, I'm 99% sure it's something incorrectly configured, but I'm struggling to debug. I will ask more in discord if I still can't figure it out.

from unity-test-runner.

webbertakken avatar webbertakken commented on August 22, 2024

This literally means that the file is not there in the docker container. Note that only some paths are mounted in the container.

from unity-test-runner.

pixelpax avatar pixelpax commented on August 22, 2024

If not what litefeel proposed, @webbertakken , what's the correct solution to this problem? This is preventing my team from using game-ci, unfortunately. Thanks for your help and for maintaining this awesome project.

Is there a different path we should be storing the file to to make sure the container has access?

from unity-test-runner.

webbertakken avatar webbertakken commented on August 22, 2024

The recommended and documented way is to copy the contents of your license file into the UNITY_LICENSE variable.

Note that since we've started GameCI, I've not heard any remotely convincing arguments as to why users would need to push around licenses as files. But that doesn't mean it doesn't work. So if you must use a file, then the path obviously has to be one of the paths that is mounted into the container.

We're open for merge requests if you feel test-runner is lacking in a way. However it should not break existing workflows, like the one above does.

from unity-test-runner.

litefeel avatar litefeel commented on August 22, 2024

@pixelpax
Now, github action can store multiline strings to GITHUB_ENV, So you can use the UNITY_LICENSE variable.
like this.

# Set env
- name: Set env UNITY_LICENSE
  run: |
     echo 'UNITY_LICENSE<<EOF' >> $GITHUB_ENV
     cat UnityLicense/${{ matrix.unityVersion }}.ulf >> $GITHUB_ENV
     echo '' >> $GITHUB_ENV
     echo 'EOF' >> $GITHUB_ENV

https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#multiline-strings

from unity-test-runner.

webbertakken avatar webbertakken commented on August 22, 2024

While that would work, this is a workaround that makes setting up your workflow much harder.

We might also be able to help others if one or both of you could explain why the regular way doesn't work for you, and maybe also what didn't work about passing the file and providing a path to that.

from unity-test-runner.

pixelpax avatar pixelpax commented on August 22, 2024

Ah, thank you for your help, both of you! I agree it would it would be preferred to use string file contents froma github secret. Unfortunately when I try to use github secrets they come out as empty strings.

Your point is a good one; I can't come up with a good reason for spending anyone's energy supporting files except for github secrets misbehaving. Even this is resolvable by just putting the file contents in as a multiline string just as well.

from unity-test-runner.

pixelpax avatar pixelpax commented on August 22, 2024

When I've worked with secrets before they usually show up as **** if present
image
image

from unity-test-runner.

webbertakken avatar webbertakken commented on August 22, 2024

Note that hundreds of people were successful getting it to work following our documentation at game.ci.
Also note that it's intended behaviour that your secrets don't show up in your logs, they're supposed to show up as ***.

If you have found an actual bug in GitHub secrets, it would be very important to report this to GitHub.
That said, in my experience secrets have been working perfectly fine all the time.

from unity-test-runner.

davidmfinol avatar davidmfinol commented on August 22, 2024

@pixelpax did you find out what was wrong?

from unity-test-runner.

pixelpax avatar pixelpax commented on August 22, 2024

I was using an .alf where a .ulf was supposed to go, I believe. Still not sure why gh secrets weren't populating.

from unity-test-runner.

davidmfinol avatar davidmfinol commented on August 22, 2024

Ok, closing this issue since this doesn't seem to be an issue with Unity Test Runner.

from unity-test-runner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.