Documentation inconsistencies about bioblend

[hexylena]

• bioblend.galaxy.folders delete_folder() that sort of thing looks like it could raise an exception when the ID doesn't start with 'F'. How do bioblend devs feel about adding exceptions to those sort of things that do validation before hitting the Galaxy server? Is that less desirable than letting Galaxy handle it?

[nsoranzo]

bioblend.galaxy.libraries upload_file_from_server() here it's specified that if folder_id is empty, then the root folder will be used. Is this true everywhere? Should this be an optional param with None as a default? What does roles do?

It is true for all library upload_*/copy_from_dataset methods. It is already an optional param with None as default. I don't know that roles do.

upload_file_from_server/upload_from_galaxy_filesystem are confusingly similar, but that's not bioblend's fault.

Indeed, the main difference is that for upload_file_from_server() files should be in library_import_dir, while for upload_from_galaxy_filesystem() they may be everywhere in the server filesystem.

bioblend.galaxy.folders delete_folder() that sort of thing looks like it could raise an exception when the ID doesn't start with 'F'. How do bioblend devs feel about adding exceptions to those sort of things that do validation before hitting the Galaxy server? Is that less desirable than letting Galaxy handle it?

No, in previous releases Galaxy was returning and accepting folder ids without the initial 'F', so if there is a specific bug we should fix it, otherwise let's leave it as it is.

[hexylena]

@nsoranzo Thanks for the feedback, I appreciate it.

Good to know about all of those little idiosyncracies of the galaxy API.