Check spelling!

section about paramaters an arguments - @gaand

Line 16.

xdescribe('collections lab', () => {

should be

describe('collections lab', () => {

1. The for-statement syntax is new to students, and they are using it wrong in their diagnostic.
2. The existence of both uniqueWords and keys seems completely redundant. Unless there is a mistake, and they are meant to be used differently?

// The keys pulled out into a list
let uniqueWords = [];

let keys = [];
let k = 0;
for (keys[k++] in uniqueWordsAsKeys); //jshint ignore:line

uniqueWords = keys;

@gaand from @jrhorn424. Thanks.

Lesson should be completely "refactored" to follow the: you do, I do, we do model - @gaand

• @gaand

• @gaand

I believe that was our conclusion in a long discussion issue somewhere, but I don't remember where.

So, change that in this repo, e.g.

-const fullName = function fullName(given, family, east) {
+const fullName = function (given, family, east) {
   if (east) {
     return `${family} ${given}`;
   else {
     return `${given} ${family}`;
   }
 };

example when talking about args:

let three = function three(arg1, arg2, arg3){....

change these to params

self explanatory, see below.

fibonacci[i] = fibonacci[i-1] = fibonacci[i-2];

Was not completed for delivery for this iteration.

Some possible resources:

https://regex.alf.nu/
http://regexone.com/
http://scriptular.com/
http://www.regular-expressions.info/tutorial.html

don't need colon.

foo : foo

Where/when possible. - @gaand

Question:
// 3. Write a function that returns the count of words in a string.
// Provid the option to count unique words instead of total words.

The option part of question three says to count UNIQUE words instead of total words. That leads me to believe the amount of words that only appear once, so the count for a string of 'this a this' would be 1 as 'a' appears only once. Better phrasing for what is actually intended would be a count of all words not including repeating words, so the count of 'this a this' would be 2, as 'this' repeats twice and 'a' appears once.

(lib/collections.js has a similar ambiguity, which might be worth fixing as well)

lab.js starts with "We the people..." text, but lab.spec.js test tests our code against the collections.js text ("When in the Course of human events...").

Array and Associative Array in fundamentals.

List and Dictionary in lesson (the conceptual model, not the specific implementation - Array and Object).

Feedback from a student during 1-on-1.

For code along and lab.

Create and invoke functions with argument-dependent return values should probably just be Create and invoke functions.

Argument-dependent return values are not covered, or I'm confused about what argument-dependent means. @gaand care to discuss?

And in source files.

e.g.

-const bob = function() {};
+const bob = function () {};

We discuss arguments and optional arguments. Is the lesson the one to introduce arguments?

To enhance code along understanding

"return" is missing from

let add = function...
a +b;

Use standard-js. Not sure if the scripts and grunt files are standardized, but the README definitely isn't.

Remove . and make car['make']. via @payne-chris-r

Jumping from Reference Types and Assigment examples to Functions then to Arrays and Objects seems unintuitive to deliver. I would suggest going from Reference Types and Assignments to Arrays and Objects and then Functions.

Currently the order of delivery is:

1. Reference Types / Assignment
2. Functions
3. Collections (arrays/objects)
4. Lab

Recommended change to move Functions to before Lab.

1. Reference Types / Assignment
2. Collections (arrays/objects)
3. Functions
4. Lab

• under reference types header, confusing and distracting to students to see constructor functions mentioned and not really told what they do and are.

• under the demo:arguments and return values section, we lost a good amount of time because an arrow function was randomly shown but not explained in the lesson plan. If at this point, we're just trying to show them how to properly make a basic function, we don't need to distract them with arrow functions. It was also unclear to us as instructors why it was there. where we supposed to teach that? Ultimately, I stepped in for a few minutes to talk to them high level about what an arrow function is because they were already going down the rabbit hole, but it was a bit disruptive.

Missing semi-colon after each function declaration at line 130; via @payne-chris-r

let instructor = {'given name':'Antony', 'surname':'Donovan','occupation':'WDI Instructor'};

Estimate vs actual for deliveries have led the planning team to discuss de-scoping this talk.

Match parentheses:

 ### Function information

--   [Function](https://en.wikipedia.org/wiki/Function_(mathematics)
+-   [Function](https://en.wikipedia.org/wiki/Function_(mathematics))
 -   [Subroutine](https://en.wikipedia.org/wiki/Subroutine)
 -   [Variable shadowing](http://en.wikipedia.org/wiki/Variable_shadowing)
--   [Parameter](https://en.wikipedia.org/wiki/Parameter_(computer_programming)
+-   [Parameter](https://en.wikipedia.org/wiki/Parameter_(computer_programming))

 ### Collection information

--   [List](https://en.wikipedia.org/wiki/List_(abstract_data_type)
+-   [List](https://en.wikipedia.org/wiki/List_(abstract_data_type))
 -   [Array](https://en.wikipedia.org/wiki/Array_data_structure)
 -   [Dictionary](https://en.wikipedia.org/wiki/Associative_array)
 -   [Hash](https://en.wikipedia.org/wiki/Hash_table)

People are confused by the hyperlink pointing to the 'meta' repo during the 'Fork and clone' this repository, and are forking and cloning the 'meta' repo instead of the THIS repo.

Summary

Functions, collections, reference literals.

Prerequisites

• Fundamentals, Chapter 5
• Fundamentals, Chapter 6

talk-template

Make clearer that it's suppose to be hard.

Why did I have to open this issue?