fython / biometricpromptcompat

A Thrid-party BiometricPrompt compat library.

燒餅（Siubeng）

• Communication language: 💬Cantonese, Mandarin, English. Learning Japanese
• Most used: Golang, TypeScript, Rust, Kotlin
• Interest: DevOps, Music, Anime & Games, Android

Recent works / 最近工作

For past works see here.

If you like my projects, you can buy me a coffee at afdian.net <3

biometricpromptcompat's Issues

Biometric dialog not dismiss when Too many attempts error occured.

I think it's better to cancel Biometric dialog when onAuthenticationError method called. e.g:- when user try more than 5 wrong fingerprint, an error occured Too many attempts, Fingerprint Sensor disabled. At this time Biometric dialog should be dismiss instead of showing error.

Getting error when trying to use the library with minSupport to android 16

I should be able to use the library on a project with android support level set to 16. The check for supported devices should be chosen by us.

Accept fingerprint even after cancel the dialog

After click on USE PASSWORD Biometric dialog disappears and show you requested password Toast but accept fingerprint at the same time.
Bug reproduce steps : -
1- click on USE PASSWORD
2- Biometric Dialog disappears
3- Now touch fingerprint senser Its accept fingerprint and show Success Toast.
Tested on Nexus 6P, Android version 8.1.0

No way to create CryptoObject compat to pass into authenticate

The negative button is not visible in landscape mode

This library is pretty cool, but when I try to run the demo in landscape mode, the negative button is not visible on my Samsung S9:

Compat dialog shows previously cancelled error

To replicate:

1. Show dialog, but hit cancel.
2. Show dialog again (on a device that needs compat, like API27 emulator), will see the cancelled error from the previous invocation.

Here's a video that demonstrates what we see:

Creation code looks like:

val prompt = BiometricPromptCompat.Builder(context)
                .setTitle(context.getString(R.string.biometrics_enroll_title))
                .setDescription(context.getString(R.string.biometrics_enroll_subtitle))
                .setNegativeButton(context.getString(R.string.biometrics_cancel)) { dialogInterface, _ ->
                    dialogInterface?.let {
                        dialogInterface.cancel()
                        dialogInterface.dismiss()
                    }
                    emitter.onError(DomainException(DomainError.BIOMETRICS_CANCELLED_BY_USER))
                }
                .build()

Maybe it's my negative button handling there, which calls cancel and then dismiss?

Dialog will dismiss after rotating screen (Api23Impl)

Dialog cannot keep its state after rotating screen. Most of time, we use DialogFragment to solve this problem. But it will break original-like API style (Need developers to add Fragment to FragmentManager by themselves.).

I have implemented a simple version of DialogFragment for BiometricPromptApi23Impl which is still undocumented: AbstractBiometricPromptDialogFragment. I think I should make it easier to use before releasing it.

If you have any idea, welcome to comment here.

---

中文：

Dialog 不能在旋转屏幕后保持它的状态。大多时候我们会使用 DialogFragment 来解决这个问题，但它会破坏类原生接口的风格（需要开发者自行将 Fragment 加入 FragmentManager）。

我已经为 BiometricPromptApi23Impl 实现了一个未记入文档的简单版本 Fragment ——AbstractBiometricPromptDialogFragment。我想我应该让它更易于使用再发布。

如果你有任何点子，欢迎在此发表评论。

Leaked window DecorView

I'm getting this error:

2018-06-27 16:03:38.323 27998-27998/com.mypossibleself.app E/WindowManager: android.view.WindowLeaked: Activity com.example.SecurityEntryActivity has leaked window DecorView@1635e7a[Security] that was originally added here
        at android.view.ViewRootImpl.<init>(ViewRootImpl.java:572)
        at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:331)
        at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:97)
        at android.app.Dialog.show(Dialog.java:419)
        at moe.feng.support.biometricprompt.BiometricPromptApi23Impl.authenticate(BiometricPromptApi23Impl.java:133)
        at moe.feng.support.biometricprompt.BiometricPromptCompat.authenticate(BiometricPromptCompat.java:107)

It's triggering when trying to call biometricPrompt.authenticate.

It's only on some phones and only occasionally.

Marked as deprecated but have not official compat library jet

Do we have it?