futurepaul / address-factory Goto Github PK

There should probably be some nice fallback where we point them at a resource so they know how to set up GPG and create a key.

Here's a comparison of build time / binary overhead: https://github.com/RazrFalcon/pico-args

Might be nice to quickly just purge the config file & any generated databases?

For instance, it stores the config dir right now (not really necessary just the lazy thing). If you move it from Linux to Mac that config dir will be incorrect. How do we want to handle portable address-factory.json. Should we have an export flag?

When a user is entering the path in the wizard they can't use autocompletion or ls to browse to the file. They also can't go back and edit part of the path. For example if the user enters the path as /home/files/example.json and the user wants to go back and edit this to be /home/coldcard-files/example.json they have to delete the string from the trailing end (they can't go left with the cursor).

Solution: The fix already made to allow the dragging of files into the terminal helps this immensely. I don't know if there is a better way long term to allow the user to select files using a pop-up file select menu. For terminal users it feels like it's annoying to have to remember a path or use a separate terminal / file explorer to do this.

Maybe we could make a .addressfactory directory in the home folder which is where the address-generator.json files are stored. This way they would be easy to keep track of, and could be called from various versions of the software.

If they match they don't need to be shown, if they don't match then something has gone wrong and the actual addresses won't help debug.

Blocked on bitcoindevkit/bdk#305

When I run the first time and import the coldcard json it works fine. When I run a second time immediately after and enter n (no changes) the following happens:

✔ Do you want to make any changes? · no
Checking address
Derived: REDACTED
Expected: REDACTED
Skipping addresses...
Error: table entries already exists

Caused by:
Error code 1: SQL error or missing database

I think we need to include the time in the name TO THE >SECOND<

This is a great alt-chat

Might be helpful for tracking down an address later, but is this a privacy leak akin to sharing the xpub?

User may have never moved the address-factory.json file that was generated when initialising. In this case, they don't know where the address-factory.json file is.

Suggestion:

• [] Look in the root directory of program for any address-factory.json files and present to the user for selection
• [] Have a folder of address-factory.json files rather than storing in the root of the program

We're converting everything to descriptors anyway.

This way the user doesn't have to have gpg installed. Also should speed up signing because we can run rpgp in parallel.

Blocked on rpgp/rpgp#122

When setting up a new address factory the user is prompted for the path to the .json file

If a user drags a file into the terminal the path is specified like this /home/....json which causes the script to end with Error: No such file or directory (os error 2).

Solution: Remove leading and trailing ' from the entered path?

Currently a new address factory always gets named address-factory.json and is saved in the root directory of the program files.

Suggestions:

• Prefix with date of creation (as used when generating the signed_addresses.db)
• Let user specify name of address-factory and add as a suffix (before .json)
• Let user specify whether to save file in root of program, in same directory as imported .json or on another location (complex to implement)

E.g. 2021-02-22_address-factory_coldcardtest.json