fustrate / baseballbot.io Goto Github PK
View Code? Open in Web Editor NEWWIP rewrite of /u/BaseballBot
WIP rewrite of /u/BaseballBot
See title.
I think the issue is that the game_status_ind
value sometimes includes a character denoting the reason for a delay. For example 'DR' may translate to 'Delayed due to Rain'.
Here's a potential fix:
# lib/baseballbot/template/sidebar/calendar.rb
# Line 234
# Old
return 'Delayed' if game[:status_code] == 'D'
# New
return 'Delayed' if game[:status_code].start_with? 'D'
Found the issue when looking at the calendar on /r/CHICubs and noticing that the April 5th game hadn't been updated.
There is an issue in the Game Graph
and Strikezone Map
links.
The date parameter in the URL is a date value based on UTC time, so a 7PM CDT start time will pass tomorrow's date and that results in an error when visiting the link.
You can see what I am talking about if you look at today's game thread here, the links are:
http://www.fangraphs.com/livewins.aspx?date=2021-05-15&team=Astros&dh=0&season=2021
http://www.brooksbaseball.net/pfxVB/zoneTrack.php?month=05&day=15&year=2021&game=gid_2021_05_14_texmlb_houmlb_1%2F
The correct links are:
http://www.fangraphs.com/livewins.aspx?date=2021-05-14&team=Astros&dh=0&season=2021
http://www.brooksbaseball.net/pfxVB/zoneTrack.php?month=05&day=14&year=2021&game=gid_2021_05_14_texmlb_houmlb_1%2F
At game time the correct link will yield the expected content, but the bad link will return the error page.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.