fusionjs / eslint-config-fusion

Migrated to https://github.com/fusionjs/fusionjs

FUSION.JS

Modern framework for fast, powerful React apps

What is it?

fu·sion — noun

The process or result of joining two or more things together to form a single entity.

Fusion.js, Uber’s open source universal web framework, represents the fusion of the client and the server. It's geared for server-side rendering out of the box, and its plugin-driven architecture allows for complex frontend and backend logic to be encapsulated in a single plugin:

import App from 'fusion-react';
import Router from 'fusion-plugin-react-router';

export default () => {
  const app = new App(<div>...</div>);

  /*
  One line of code sets up everything you need for routing:
  - Server rendering
  - React Providers on both server and browser
  - Bundle splitting integration
  - Hot module reloading support
  */
  app.register(Router);

  return app;
}

We initially built Fusion.js to make our own websites easier to maintain, but were so impressed with the benefits that we decided to offer it to the community as an open source project!

Try it out

If you're interested in giving Fusion.js a shot, Overview and Core Concepts are great places to start.

Contributing

This is a monorepo of all open source Fusion.js packages maintained using Yarn v2. Take a look at CONTRIBUTING.md for info on how to develop in this repo.

License

MIT

eslint-config-fusion's Issues

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Preset name not found within published preset config (monorepo:angularmaterial). Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

Remove import/first[absolute-first] in favor of import/order

Type of issue

Feature request

Description

Remove https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/first.md in favor of https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/order.md.

This will allow for more fine-grained control over import ordering and consistency everywhere.

We should enable import extensions, except for packages.

We should enable import extensions, except for packages. We need to wait until eslint-plugin-import publishes a version which includes ignorePackages.

Use buildkite for CI

Initial implementation

We need to add the initial implementation to this repository.

See if we can remove the import rules

Now that we require flowtype annotations on files, we may be able to remove eslint import rules as long as flow types provide the same level of security.

Add import rules

For earlier error detection and improved code quality.

Delete this repo

I don't see the point of having this repo differ from https://github.com/uber-web/uber-eslint/tree/next/packages/eslint-config-uber-universal-stage-3. Should we just delete this one and make the uber-eslint config match what we use here?

suggest adding plugin-jsx-a11y

Type of issue

Feature request

Description

Add eslint-plugin-jsx-a11y to the config to automatically flag accessibility problems. This could be implemented here in this repo or in eslint-config-uber-universal-stage-3

Current behavior

Fusion.js does not automatically flag accessibility problems in my apps. Of course, I can still extend this config to add jsx-a11y linting, but I have to remember to do this each time I scaffold a new repo. Moreover, I feel having it in the default configuration would help everyone build more accessible websites using Fusion.js.

Expected behavior

Fusion.js could use eslint-plugin-jsx-a11y to automatically detect accessibility problems and fail the build if one was detected.

Additional notes

This would be a breaking change, since code exists out in the wild using eslint-config-fusion that would not pass eslint-plugin-jsx-a11y.

Build failing due to new peerDependency for eslint-config-jest

Hello, I'm using eslint-config-fusion outside of a FusionJS project. The latest patch to add eslint-config-jest is breaking our builds due to the absence of that dependency. To resolve, I've added it manually, but I would consider patch fixing it, and rolling this out on a minor/major instead.

Commit causing issue: cb2bb24