fusionjs / eslint-config-fusion

Migrated to https://github.com/fusionjs/fusionjs

eslint-config-fusion

eslint-config-fusion is an eslint config recommended for use with Fusion.js.

Usage

Extend eslint-config-fusion in your .eslintrc.js:

module.exports = {
  extends: [
    require.resolve('eslint-config-fusion')
  ]
};

eslint-config-fusion's Issues

We should enable import extensions, except for packages.

We should enable import extensions, except for packages. We need to wait until eslint-plugin-import publishes a version which includes ignorePackages.

Delete this repo

I don't see the point of having this repo differ from https://github.com/uber-web/uber-eslint/tree/next/packages/eslint-config-uber-universal-stage-3. Should we just delete this one and make the uber-eslint config match what we use here?

Build failing due to new peerDependency for eslint-config-jest

Hello, I'm using eslint-config-fusion outside of a FusionJS project. The latest patch to add eslint-config-jest is breaking our builds due to the absence of that dependency. To resolve, I've added it manually, but I would consider patch fixing it, and rolling this out on a minor/major instead.

Commit causing issue: cb2bb24

Add import rules

For earlier error detection and improved code quality.

Remove import/first[absolute-first] in favor of import/order

Type of issue

Feature request

Description

Remove https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/first.md in favor of https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/order.md.

This will allow for more fine-grained control over import ordering and consistency everywhere.

Initial implementation

We need to add the initial implementation to this repository.

suggest adding plugin-jsx-a11y

Type of issue

Feature request

Description

Add eslint-plugin-jsx-a11y to the config to automatically flag accessibility problems. This could be implemented here in this repo or in eslint-config-uber-universal-stage-3

Current behavior

Fusion.js does not automatically flag accessibility problems in my apps. Of course, I can still extend this config to add jsx-a11y linting, but I have to remember to do this each time I scaffold a new repo. Moreover, I feel having it in the default configuration would help everyone build more accessible websites using Fusion.js.

Expected behavior

Fusion.js could use eslint-plugin-jsx-a11y to automatically detect accessibility problems and fail the build if one was detected.

Additional notes

This would be a breaking change, since code exists out in the wild using eslint-config-fusion that would not pass eslint-plugin-jsx-a11y.

See if we can remove the import rules

Now that we require flowtype annotations on files, we may be able to remove eslint import rules as long as flow types provide the same level of security.

Use buildkite for CI

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Preset name not found within published preset config (monorepo:angularmaterial). Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.