furtrader / overkillsolarbms Goto Github PK

Since installing version 3.1.1026, I am unable to set the cell over voltage release voltage parameter. When to try to type in a number e.g. 3.5 (or any other value), it sets to 3.600000. If you try to clear the value, the app crashes right out.

The file bms.cpp contains several errors in calls to the OverkillSolarBms::write() method.

The data and length arguments are reversed from the definition in bms.h. It will cause no end of trouble.

These errors are at lines 310, 354, 475, 501, & 523 of the code I cloned.

Also, the calls to min() compare defined values to uint8_t (unsigned char) type. MACROS are treated as int by default, and the min() declaration is min(int, int), so the uint8_t values should be cast as (int) to prevent warnings or the 'no overload found' errors that I saw.

With those changes, it builds silently and does ... something (completely untested so far) on the Espressif ESP32 boards.

I'm working on a project that uses your library (patched) a counter and SN74LV4052A 4-way UART muxes so I can monitor/control lots of BMSes from a web page served up by the same ESP that's doing the monitoring. I think I can do that mux stuff outside of this library, using only Serial1, so having the corrections on here will make future pulls easier there, wink wink.

Thanks for taking the time to make this available!

Observing that the apk available to download / sideload install marked as v1.4.0 from 9th April 2023 #32.41MB is displaying in the running app as v1.3.13.

Also it seems the Google Play 6th April 11.72MB update which is depicted as v1.3.12 within the Google Play about app section also displays as v1.3.13 within the running app.

I do noticed that within various system files contained within the apk, a variety of version numbers are contained.
Within; META-INF / androidx.activity_activity.version as androidx.activity_activity-ktx.version both shows as 1.4.0

But within assets / app.config reports;

{"name":"Overkill Solar","slug":"overkill-solar","version":"1.3.12",

Please can you also publish SHA or MD5 checksums with your releases so we can confirm they have not been altered. Thank you.

There is only one temp.-display, but at least two sensors. And the App seems to switch and compare internally and displays only the sensor with the higher temp. value. That is, regarding undertemperature monitoring, not helpful.
A better solution could be:
Showing both sensor values at the same time (preferred)
or
Fixed selection of the sensor which should be displayed.