Coder Social home page Coder Social logo

basicminimap's People

Contributors

bluenightsky avatar bullsei avatar caelivs avatar eke00372 avatar funkydude avatar lackofcodexp avatar malikoth avatar manicow avatar tborlee avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

basicminimap's Issues

Buff/debuff + boss frames anchoring improvement

Describe the problem

When using basicminimap, buff/debuff and boss frame windows need to be adjusted with a different addon (if you use a bigger minimap, it will be on top of these frames.

because of this issue - i either have to use additional addons like moveanything that spam errors (boss frames cant be moved properly without causing UI errors nonstop)
I would suggest if possible to allow anchoring the buff and boss frames to BasicMinimap map so that no matter what happens to your UI (such as changing UI scale % or by changing monitors which I do a lot) everything will always be in correct location. Having to readjust everything and deal with multiple addons for something like this is unfortunately why I had to delete the addon..

What steps will reproduce the problem?

  1. make a minimap big at top right corner, all frames will be hidden behind..

What version of the addon are you using? (Stating 'latest' is not useful)

v9.0.5

Do you have an error log of what happened?

no errors

Thank you so much

Can't hide unread mail icon

This addon is almost a complete replacement for Chinchilla in my particular setup on Classic. The only thing I can't do that I want to is hide the unread mail icon, which I have a libdatabroker addon (Aanye Mail) for.

image

Thanks for this sweet addon!

Class Hall button

Any plans for creating a function to hide the Class Hall/whatever BFA brings to replace it-button and add in a keybind command? Basically exactly like the calendar and tracking works right now.

Thank you for creating and maintaining this addon btw.

Option: Clock Position

image

I would really like to have the option to move and position my clock as on my screenshot. I needed to modify your LUA file and now I need to do it everytime I am going to update your addon :)

Sidenote: Thank you so much for doing this!

Clock text no longer displays

Curious if you have seen any addon conflicts as after the most recent update my clock text stopped appearing on addon load.

Feature Request: Add minimap-fading functionality

As a World of Warcraft player that values screen real estate, I would like to have a minimap that fades in or fades out depending on various basic criteria (see below). This will help me (and others like me) maintain a cohesive aesthetic with other faded-out UI elements while also improving my play experience by allowing more of the higher-value aspects of the game to be visible (e.g. the game world, entities on the ground when walking/running/riding, etc.)

Basic Criteria :

  1. if minimap-fading is desired, it must be enabled via (at least) the "Interface > Addons > Other" configuration UI
  2. if minimap-fading is disabled, the minimap is not faded out
  3. If minimap-fading is enabled, the minimap is faded-out
  4. if minimap-fading is enabled, the amount of fade is configurable (perhaps via a slider/percentage configuration)
  5. if minimap-fading is enabled, the minimap itself fades in on mouseover (and fades out again while no mouseover)

Additional Considerations:

  • Since the primary fade-in/fade-out trigger may be based on mouse hover, the minimap's frame strata may need to be made adjustable in a future iteration. BasicMinimap on its own seems to inherit/use the default frame strata equivalent to the Blizzard/native minimap frame, and therefore may be fine to leave as-is until a future iteration.
  • Initial configuration options have the opportunity to be kept basic/simple, allowing for additional iterative development if further feedback is presented (e.g. it may be desirable, in a future iteration, to introduce a "fade-in/fade-out delay" configuration option - or to only fade out during combat, etc.)
  • With the advent of OLED-based displays becoming available on the market (e.g. LG OLED48CX), and those displays being touted as ideal gaming "monitors", it is increasingly important that static elements on the screen are mitigated or kept to an absolute minimum (to avoid burn-in)

What version of the addon are you using?

Addon: 9.0.4
Game Client: 9.0.1

Any additional information?

I have always used BasicMinimap and I love it for it's simplicity and "get right to it"-ness. Having checked many other minimap-related addons, none seem to contain this functionality (if they do, they were very... robust... and thus this basic feature was left undiscovered)

Classic compatibility?

Can this be updated to work with Classic? There is another square map out there (DejaMinimap) but it has zero configuration ability other than size and location.

Changing scale changes icon sizes

I'm having an issue where if I change the scale of the minimap all the minimap icons get super big too (such as quests, flightpath, battle pets, mining nodes).

Is there any way to change the size of the map without touching the size of these icons, or changing the size of them?

Thank you in advance :)

Mail & Calendar Icon

Hey, is there a Way to move Mail & Calendar Icon pls? I cant put the map in the right corner, because i cant see the icons than. :(

image

Using Version v9.0.3

Possible to move it independently of quest tracker?

Thank you for the update!

Might it be possible to move it independently of the quest tracker window?

Currently when I drag the minimap to the bottom right corner of the screen, the quest tracker window comes with it. I actually don't remember it doing this before? which is why I ask. <3

New size is too small

I'm playing at 2560x1440, and with the minimap set to its maximum size, it's still far smaller than is comfortable for me, and now I have to lean way closer to my screen to discern any detail from the minimap. The size option is great, but I do not think it should have replaced scaling, just supplemented it. Just my $0.02. :) Great, simple, functional, elegant addon. Thanks!

Feature Request: Sliders for Compass scale and alpha

When you change the size of the minimap and you have rotate on, it can cause the compass to no longer be along the outside of the minimap. It would be nice to have some options to scale it up to fit the new size. Maybe it could be done automatically, but I think whether one likes the marks and the "N" to be inside or outside is a matter of taste, so having a slider and letting people adjust to taste might be the best option here. And while we're at it, have an alpha slider for if one wants the "N" and notches to the somewhat see-through (this also helps with the fact that at full opacity, upscaled, the compass texture looks a bit naff).

fwiw, I threw these lines into a quick addon to adjust it myself, so this is kinda what I'm thinking, except without the values being hardcoded, of course:

MinimapCompassTexture:SetScale(1.75)
MinimapCompassTexture:SetAlpha(0.5)
local point, relativeTo, relativePoint, x, y = MinimapCompassTexture:GetPoint()
MinimapCompassTexture:SetPoint(point, relativeTo, relativePoint, 0, 0)

This fits my size 320 minimap pretty well. The last bit with SetPoint was needed because, for some reason the compass is offset a bit by default, and it's really obvious when you blow it up from its default (0.7) scale.

Instance difficulty text

Would it be possible to get a simple text indicator for instance difficulty similar to bdMinimap (bottom right)?

image

Offset of zone text

Hi funkydude,

thanks for this great minimap addon. I really like.
Could you change the line
self.SetPoint(MinimapZoneTextButton, "BOTTOM", backdrop, "TOP", 0, 2)
to
self.SetPoint(MinimapZoneTextButton, "BOTTOM", backdrop, "TOP", 0, 3)
to make the offset of both texts even? I know it's just a pixel but I'd really appreciate it.

Offset

Thanks in advance!

Compass Points

(New to GitHub, so sorry if this is the wrong place to post this).
Is there a way to add an option to hide the compass points, the "N" for North and the South, West and East art around the minimal.

Many thanks in advance.

Missions (Garrison/Covenant) button position gets overwritten by Blizzard in Shadowlands

The GarrisonLandingPageMinimapButton button (called "Missions" button in the config; in SL this is the Covenant Sanctum button) in 9.0 gets delayed SetPoint calls by Blizzard and reverts to a hardcoded anchor. As a result it doesn't appear in the correct place.

Offending FrameXML code:

Workaround is to post-hook GarrisonLandingPageMinimapButton_UpdateIcon to force it back:

hooksecurefunc("GarrisonLandingPageMinimapButton_UpdateIcon", function(self)
        self:ClearAllPoints()
        self:SetPoint(...)
end)

Feature request: coordinates toggle

Unless I missed it (and that does tend to happen), I don't think there's an option to hide the new coordinates display, if you would consider it.

Font shadow issue for zone, clock, and coordinates

BasicMinimap does text shadow a bit different from stock UI behavior, the only option addon provides is to add a shadow that is too thick (even on thin opion)
Is there any possibility to add another option to match blizzard UI text shadow? Current shadow offset is way too thick, and the "no shadow" option makes text unreadable at times
Some chat addons like Prat have this option too I believe

I hope you will find this worth implementing as it would go a long way to make my UI more neat :)
Thank you, and love the addon!

P.S. the quest tracker in screenshot is Kaliel's tracker in case it is relevant

Example:
image

What version of the addon are you using? (Stating 'latest' is not useful)

v9.0.11

Do you have an error log of what happened?

n/a

Possible to scale map smaller?

With the latest change I noticed that the minimap has gotten larger, even when set at the lowest scale (140).

Is it possible to allow it go lower than that? I've used BMM for years because it is just what I need without all the extras.

The blank square is where BMM sat prior to the latest patch.
image

Movable Minimap buttons...??

This addon is ‘almost’perfect, the ability to scale and sizethe map is fantastic unlike others.
However for me the number 1 glaring issue is the fact you cannot move some of the buttons around the map such as the mail box, mission button, lfg button, in other words the blizzard ones. almost every other map addon lets you do this, which is so aggravating.

Two other more minor points would be the ability to move the position of the clock and zone name. and the ability for a flashing node option that addons like sexymap and mappy use.

Text color

I have set the text color of Zone, Clock and Coordinates to be ClassColor, but they do not update to the right color when on another character. The border does change color as intended.

Paladin Sense Undead Icon

Can we place have control of the Paladin Sense Undead Icon on the minimap? It is always displayed and no way to move it.

Thanks!

Minimap occasionally moves itself when /reload is used

I have been having a couple of problems with addons recently. This is one of them, and then I got two others also throwing errors too. When I am trying to fix the other addon errors I sometimes do a /reload.

One of the issues I have been having with Basic Minimap lately besides the other one I posted below is that when I do a /reload to try and fix another addon, Basic Minimap occasionally moves itself to the top-left corner of the screen and I have to keep moving it back to the right side where I want it.

It does not throw an error when it decides to move itself, but it gets frustrating when it happens. I don't know why it's doing that. The other two addons I am having issues with have nothing to do with maps/minimaps or even minimap buttons so I don't know why the minimap moves itself.

Compatibility with FarmHud

On enable FarmHud the backdropFrame from BasicMinimap is difficult to catch.
Please use the following function to help for a better cooperation between our addons. ;-)

if FarmHud then
    FarmHud:RegisterForeignAddOnObject( backdropFrame, "BasicMinimap")
end

For testing i've added this lines into Login( ) function.

Greetings
Hizuro

Lua errors...

Didnt have any problems yesterday but actually redid ui and got a bunch of errors now..

Message: Interface\AddOns\BasicMinimap\BasicMinimap.lua:305: Attempt to register unknown event "CALENDAR_UPDATE_PENDING_INVITES"
Time: Sat Aug 10 11:44:51 2019
Count: 1
Stack: Interface\AddOns\BasicMinimap\BasicMinimap.lua:305: Attempt to register unknown event "CALENDAR_UPDATE_PENDING_INVITES"
[C]: in function `RegisterEvent'
Interface\AddOns\BasicMinimap\BasicMinimap.lua:305: in main chunk

Locals: (*temporary) = BasicMinimap {
 0 = <userdata>
 HideButtons = <function> defined @Interface\AddOns\BasicMinimap\BasicMinimap.lua:36
 ADDON_LOADED = <function> defined @Interface\AddOns\BasicMinimap\BasicMinimap.lua:41
 CALENDAR_UPDATE_PENDING_INVITES = <function> defined @Interface\AddOns\BasicMinimap\BasicMinimap.lua:297
 PLAYER_LOGIN = <function> defined @Interface\AddOns\BasicMinimap\BasicMinimap.lua:94
 CALENDAR_ACTION_PENDING = <function> defined @Interface\AddOns\BasicMinimap\BasicMinimap.lua:297
 blizzButtonPositions = <table> {
 }
}
(*temporary) = "CALENDAR_UPDATE_PENDING_INVITES"
Time: Sat Aug 10 11:44:56 2019
Count: 1
Stack: Interface\AddOns\BasicMinimap\BasicMinimap.lua:298: attempt to index global 'C_Calendar' (a nil value)
Interface\AddOns\BasicMinimap\BasicMinimap.lua:298: in function `CALENDAR_UPDATE_PENDING_INVITES'
Interface\AddOns\BasicMinimap\BasicMinimap.lua:98: in function `?'
Interface\AddOns\BasicMinimap\BasicMinimap.lua:32: in function <Interface\AddOns\BasicMinimap\BasicMinimap.lua:31>

Locals: self = BasicMinimap {
 0 = <userdata>
 HideButtons = <function> defined @Interface\AddOns\BasicMinimap\BasicMinimap.lua:36
 CALENDAR_UPDATE_PENDING_INVITES = <function> defined @Interface\AddOns\BasicMinimap\BasicMinimap.lua:297
 db = <table> {
 }
 CALENDAR_ACTION_PENDING = <function> defined @Interface\AddOns\BasicMinimap\BasicMinimap.lua:297
 blizzButtonPositions = <table> {
 }
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index global 'C_Calendar' (a nil value)"
frame = BasicMinimap {
 0 = <userdata>
 HideButtons = <function> defined @Interface\AddOns\BasicMinimap\BasicMinimap.lua:36
 CALENDAR_UPDATE_PENDING_INVITES = <function> defined @Interface\AddOns\BasicMinimap\BasicMinimap.lua:297
 db = <table> {
 }
 CALENDAR_ACTION_PENDING = <function> defined @Interface\AddOns\BasicMinimap\BasicMinimap.lua:297
 blizzButtonPositions = <table> {
 }
}

Both when logging in, but a bunch more once I go to the options menu like this one (addon not usable right now)

Time: Sat Aug 10 11:46:11 2019
Count: 1
Stack: Interface\AddOns\BasicMinimap_Options\Options.lua:108: attempt to index field 'mask' (a nil value)
Interface\AddOns\BasicMinimap_Options\Options.lua:108: in function <Interface\AddOns\BasicMinimap_Options\Options.lua:100>
[C]: ?
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:51: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:49>
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:843: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:664>
[C]: ?
...ace\AddOns\TheClassicRace\libs\AceGUI\AceGUI-3.0.lua:72: in function <...ace\AddOns\TheClassicRace\libs\AceGUI\AceGUI-3.0.lua:70>
...ace\AddOns\TheClassicRace\libs\AceGUI\AceGUI-3.0.lua:287: in function `Fire'
...icRace\libs\AceGUI\widgets\AceGUIWidget-DropDown.lua:442: in function <...icRace\libs\AceGUI\widgets\AceGUIWidget-DropDown.lua:433>
[C]: ?
...ace\AddOns\TheClassicRace\libs\AceGUI\AceGUI-3.0.lua:72: in function <...ace\AddOns\TheClassicRace\libs\AceGUI\AceGUI-3.0.lua:70>
...ace\AddOns\TheClassicRace\libs\AceGUI\AceGUI-3.0.lua:287: in function `Fire'
...s\AceGUI-3.0\widgets\AceGUIWidget-DropDown-Items.lua:351: in function <...s\AceGUI-3.0\widgets\AceGUIWidget-DropDown-Items.lua:341>

Locals: <none>```

Option: Bring in the date

image

Yes, again the same screenshot. At the moment I placed a broker below my map. It would be awesome to have the option to turn the actual date on or off and position it freely (like in the screenshot). If I am pressing the button, the actual calendar is opening.

Much love <3

Some errors maybe

I'm having a lot of alert about incompatibility with "some blizzard" functions asking for disable addons. Most of time when i'm flying. When i accept the game disables just BasicMinimap. What i tried:

  • keep it disabled for some time and watch behavior.
  • Disabled Carbonite (because a lot of libs and easy to cause issues) and watch again.
  • Use another square and nice minimap too and see what happen.

Every test in case of BMinimap was disabled, i get no alert asking for disable addons.
Do we have some known incompatibility with another add on?

Clock text looses color on loging out.

Hello. I ve changed the color of the clock on the default profile so i can use same settings on all characters but the problem is that the color keeps reseting to the black default one when i logout login... Can you fix it please?

calendar option on minimap

Hey - firstly thanks a lot for the addon. I was wondering if it would be possible to add an option in to enable/disable the calendar in WoW? Would be good if you could add that along with the option to re-position the icon anywhere on the minimap.

Thanks!

BMM for Classic Not Saving Settings

BMM for Classic not Retaining Settings through /reload or relogs.

I see a post where another user was having the same issue, which he said was caused by another addon but didnt specify which. If it is, what would your insights be on what another addon would have to be doing to reset BMM settings between /reloads?

Cannot open settings dialogue after upgrading to 8.2.1

I receive the following error when I try to open the settings dialogue using /bm:

1x BasicMinimap_Options\Options-Options.lua:474: bad argument #1 to 'type' (value expected)
[C]: in function `type'
BasicMinimap_Options\Options-Options.lua:474: in main chunk
[C]: in function `LoadAddOn'
BasicMinimap\BasicMinimap-v8.2.1.lua:21: in function `?'
FrameXML\ChatFrame.lua:4836: in function `ChatEdit_ParseText'
FrameXML\ChatFrame.lua:4497: in function `ChatEdit_SendText'
FrameXML\ChatFrame.lua:4533: in function `ChatEdit_OnEnterPressed'
[string "*:OnEnterPressed"]:1: in function <[string "*:OnEnterPressed"]:1>

Locals:

And, as a result:

1x BasicMinimap\BasicMinimap-v8.2.1.lua:22: BasicMinimap isn't registed with AceConfigRegistry, unable to open config
[C]: ?
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-78.lua:1861: in function `Open'
BasicMinimap\BasicMinimap-v8.2.1.lua:22: in function `?'
FrameXML\ChatFrame.lua:4836: in function `ChatEdit_ParseText'
FrameXML\ChatFrame.lua:4497: in function `ChatEdit_SendText'
FrameXML\ChatFrame.lua:4533: in function `ChatEdit_OnEnterPressed'
[string "*:OnEnterPressed"]:1: in function <[string "*:OnEnterPressed"]:1>

Locals:
(*temporary) = "BasicMinimap isn't registed with AceConfigRegistry, unable to open config"

It looks like GetZonePVPInfo might not return anything (not even nil) and type raises when not given a value. If you have war mode off in a non-PVP zone, this is exactly what will happen. The following fixed it for me:

@@ -471,7 +471,7 @@ local acOptions = {
                                                        end,
                                                },
                                                colorDesc = {
-                                                       name = L.currentZone:format(type(GetZonePVPInfo()) == "string" and L[GetZonePVPInfo()] or L.normal),
+                                                       name = L.currentZone:format(type(GetZonePVPInfo() or nil) == "string" and L[GetZonePVPInfo()] or L.normal),^M
                                                        order = 9.5, type = "description", width = "full",
                                                },
                                                colorNormal = {

Moving minimap buttons

Addon buttons are already movable, but a lot of people would like to see the default Blizzard buttons be movable.

If you want to see this functionality you can thumbs up this post.

Error after reloading UI in Oribos Inn

Following Lua Error after reloading UI when in the new Inn in Oribos. It doesn't occur on a fresh login, only after reloading UI. Haven't tested in other locations.

1x BasicMinimap\BasicMinimap-v9.0.9.lua:352: attempt to call a nil value
[string "@BasicMinimap\BasicMinimap-v9.0.9.lua"]:352: in function update' [string "@BasicMinimap\BasicMinimap-v9.0.9.lua"]:356: in function <BasicMinimap\BasicMinimap.lua:280> [string "@BasicMinimap\BasicMinimap-v9.0.9.lua"]:707: in function ?'
[string "@BasicMinimap\BasicMinimap-v9.0.9.lua"]:721: in function <BasicMinimap\BasicMinimap.lua:720>

Locals:
self = {
0 =
}
text = "The Idyllia"
pvpType = "sanctuary"
(*temporary) = nil
(*temporary) = "attempt to call a nil value"
GetMinimapZoneText = defined =[C]:-1
zoneTextFont = {
0 =
}
GetZonePVPInfo = defined =[C]:-1
frame = BasicMinimap {
0 =
PET_BATTLE_CLOSE = defined @BasicMinimap\BasicMinimap.lua:679
ADDON_LOADED = defined @BasicMinimap\BasicMinimap.lua:684
mask = {
}
backdrop = {
}
blizzButtonPositions =

{
}
coords = {
}
LOADING_SCREEN_DISABLED = defined @BasicMinimap\BasicMinimap.lua:702
CALENDAR_ACTION_PENDING = defined @BasicMinimap\BasicMinimap.lua:663
PET_BATTLE_OPENING_START = defined @BasicMinimap\BasicMinimap.lua:674
db =
{
}
clock = {
}
HideButtons = defined @BasicMinimap\BasicMinimap.lua:34
CALENDAR_UPDATE_PENDING_INVITES = defined @BasicMinimap\BasicMinimap.lua:663
}

Option: Disable Clock/Location/etc

image

I would really like to have the option to disable the Location and clock or (as the other issue), move them around as I want to :)

I needed to modify your LUA file and now I need to do it everytime I am going to update your addon :)

Again, thank you! <3

[not a bug] Appreciation

Obviously this is not an issue, but the lack of a forum on the add-on’s curseforge homepage forces me to post this here:

This add-on is insanely great, and does everything I expect – without all the Chinchilla/SexyMap bloat. Keep up the great work!

– Tom

Basic Minimap No Longer Respects Mouse-button Assignments

This has been going on for little more than a week now. I think I first noticed it after the last game update where Blizzard was planning on fixing the AH issue.

Basic Minimap no longer accepts my chosen mouse-button assignment. No matter what I assign it to it ignores it. I want the Calendar to open on middle-mouse button click but it opens on your default right-click. I want the Tracking set to right-mouse button click but it opens on your default middle-button click.

It shows my correct assignment for the mouse-buttons in the config window but actually clicking on the minimap with the mouse it's using your default assignments.

Zone text hidden by other addons?

For some reason when you use Bartender4 and this addon at the same time the Zone Text above the map disappears? Bartender4 doesn't use the zone text for anything so I'm not totally sure why this happens.

Class Color border

Before the one of the last update, was able to have border match the class that I was playing. Now will only do the same color for the border for all character.

Find Herb / Find Minerals Icon not showing up on minimap

Describe the problem

it does not show Find Herbs or Find Minerals in the newest version

What steps will reproduce the problem?

  1. click the spells and it should show up on your minimap top left somewhere, but right now it does not show up

Consider attaching a screenshot below to help describe your issue (Attach directly, do not link to other websites)

What version of the addon are you using? (Stating 'latest' is not useful)

Do you have an error log of what happened?

Any additional information? (example: WoW language if not English)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.