funkwerk-mobility / cogito Goto Github PK

funkwerk/cogito#9

Problem

Assuming I have overloaded functions with different complexity:

module g.h;

import std.stdio;

void f(char x)
{
}

void f(bool x)
{
    if (x)
    {
        bool y = !x;

        if (y)
        {
            writeln("x, y: true");
        }
        else
        {
            writeln("x: true, y: false");
        }
    }
    else
    {
        bool y = !x;

        if (y)
        {
            writeln("x: false, y: true");
        }
        else
        {
            writeln("x, y: false");
        }
    }
}

The complexity of the empty function is 0, the other one 8.

I have a configuration file as well:

[g.h]
f = 10

Cogito fails with the error code 6:

test.d:5: function f: 0 (this symbol shouldn't be excluded anymore)

Possible solution

If the exclusion rule applies to (excludes) at least one function overload, ignore the others.

Methods of the form

int foo() => 3;

are currently not understood by Cogito. In DMD this is enabled by preview=shortenedMethods, but Cogito doesn't understand the DMD flags.

This can be fixed by setting global.params.shortenedMethods = true; after initializing DMD, and since it's a strict syntax addition, there shouldn't be any problem from having it always on.