funcx-faas / funcx-forwarder Goto Github PK

See

Bad boolean logic there

The commit linked below added some bogus env vars to the CI workflow definition to get the tests passing. The handling around these env vars will be updated in funcx-common, and once that is done, these changes should be reverted.
31b3c02

Currently, we have the default forwarder server key baked into the funcx-endpoint. However, this creates a couple of issues:

1. Cycling keys means you have to roll out a new funcx-endpoint release with the updated key.
2. If the user has to connect to a private/dev funcx deployments, they have to manually copy server keys to the certificates dir.

Alternatively, we could have the web-service return the forwarder-service key upon endpoint registration. This would allow each individual forwarder to have its own local server key generated at the service start and passed back to the endpoint.

There's an active vulnerability in the tornado 6.1 library that's being caught and reported by the vulnerability check in our github actions. The dependency comes through funcx->parsl and through nbsphinx. The first case is being fixed and won't be a dependency in parsl 1.1.0. nbsphinx is a test-dependency and shouldn't affect the package.

This test failure also blocks container builds necessary to test deployments. I believe suspending these tests for now, and addressing this over the next couple of weeks is the best course of action.

@BenGalewsky @joshbryan-globus please let me know what you think.

Exceptions are not appearing in JSON format, and also there are many print statements which don't use the logger.