Coder Social home page Coder Social logo

runesreformed's People

Contributors

code-apprentice avatar fumi24 avatar secretdataz avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

runesreformed's Issues

How do i run this?

How do i run this program? On the reddit post there is a "see it in action" video where it opens as a little window where you can choose the champion but when i try to open it, it opens in microsoft visual studio.

HttpClient causes memory leak(s)

You create a new client every time someone clicks the button to assign runes, but you don't dispose it.
I'd advice you to use it like this:
using (var httpClient = new HttpClient()) { ... }

to automatically dispose it after usage.
(You also create multiple HttpClients when you only need one, maybe you want to create one at the start of your program and keep it until your program ends!)

Some smaller things I also noticed:

  • File names are partly mismatching with class names
  • Multiple classes per file

If you want to scale your program to become much bigger some day, let's say on a scale like Championify + your Rune function, it would make sense to split things a bit more up.

I hope that helped a bit,
have a wonderful day and thanks for your tool!

Issue

Still not working for me

Runeforge gg

I just want to ask where are the runeforge gg sets. I miss them so much, while using webpage my computer is lagging, so only your program is the best way for me to set the best runes before the match. I appreciate your hard work and thank you for this great program. (sorry for my bad english)

Mitigate missing API feed data

Some champion's sub-pages are missing at the moment I write this because champion.gg does not have data for them. This could be mitigated a few ways but adding alternative supplying APIs could be a solution and likely the easiest to implement.
missing
notmissing
image

Can't open RR!

When I follow instructions and try to open RunesReformed I get the info that I can't open the runesreformed.rar as an archive file.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.