ftrrtf / ftrrtfrollbarbundle Goto Github PK

PR #12

Is there any reason why twig extension is commented out from services?

Attempted to load class "Twig_Function_Method" from the global namespace.
File "/vendor/ftrrtf/rollbar-bundle/Twig/RollbarExtension.php" line 47
becose: https://github.com/ftrrtf/FtrrtfRollbarBundle/blob/master/composer.json#L23

It would be great to provide such functionality. I.e. in my case rollbar notifies about expired/broken api tokens (error 401 - \Component\Security\Core\Exception\InsufficientAuthenticationException).

I think this might be read from config, i.e. like this:

exclude:
   'Symfony\Component\Security\Core\Exception\InsufficientAuthenticationException': true
   'Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException': true
   'AppBundle\Exception\MustChangePasswordException': true

Is there a way to manually report an exception?

Like:

try {
    // do something that may thrown an exception
} catch (Exception $e) {
    $this->rollbar->reportException($e);
    $this->session->getFlashBag()->add('error','Message to user');
}

Currently I can't use vendor/ftrrtf/rollbar-notifier/src/Ftrrtf/Rollbar/Notifier.php because it's not registered as a valid Symfony service. Any workaround?

Now RollbarListener catches all exceptions. I use the Monolog\Handler\GroupHandler for recording Rollbar and local files. Now will be recorded to a file only logs the error but did not get there because caught only RollbarListener.
What can be done?

RollbarListener::__construct (... Ftrrtf\Rollbar\ErrorHandler
...) https://github.com/ftrrtf/FtrrtfRollbarBundle/blob/master/EventListener/RollbarListener.php#L62

Are you planning to use semantic versioning and to release beta/stables soon?

We found that bundle installation under Symfony3.x crashes the app.

Error message:
PHP Warning: Declaration of Ftrrtf\RollbarBundle\Rollbar\Environment::setDefaultOptions(Symfony\Component\OptionsResolver\OptionsResolverInterface $resolver) should be compatible with Ftrrtf\Rollbar\Environment::setDefaultOptions(Symfony\Component\OptionsResolver\Options $resolver) in /ftrrtf/rollbar-bundle/Rollbar/Environment.php on line 13

We did not have time to investigate it any further so sorry, but this is all we got.

It's a rough plan of what to do for the v1.0.0 release.
If you have some suggestions or comments — you are welcome!

• PHP 5.5.9 as minimum version. #23
• Symfony 2.7 as minimum version #23
• Option to set up custom checkIgnore function #23
• Integration test
• NullLoger/DebugLogger for notifier
• Update docs
• ???

When trying to install rollbar-bundle tries to resolve its dependecy on rollbar-notifier using ^1.0 version.

This constraint makes composer try to resolve 1.01, 1.02, 1.03 and each one of them requires symfony/options-resolver >=2.1,<3.0 while on rollbar-notifier:dev-master the constraint is correct meaning symfony/options-resolver" : "~2.6|~3.0".

Could you release rollbar-notifier with updated constraint?

Please, update Your code to avoid such notifications.

• The Symfony\Component\Security\Core\SecurityContext class is deprecated since version 2.6 and will be removed in 3.0:
  ./vendor/ftrrtf/rollbar-bundle/EventListener/RollbarListener.php
  ./vendor/ftrrtf/rollbar-bundle/spec/Ftrrtf/RollbarBundle/EventListener/RollbarListenerSpec.php

v0.15.2
Thank You