fsgmodding / fsg_mod_assistant

Farming Simulator 22 Mod Manager.

Hi there 👋

fsg_mod_assistant's Issues

[FEATURE] Real symLink Support

Add ability to make new symlinks in the app.

Desired behavior:

• Move Mod that is a Link -> Move link reference
• Copy Mod that is a Link -> Create copy of the real file
• Link Mod that is a Link -> Create a new link to original file

[BUG] Progress bar not working

The new progress bar is a nice feature but not working accurately. The progress bar shows complete even when scanning is still in process.

[FEATURE] ZIP Export

It'd be nice to be able to ZIP up all or a part of a collection for sending to a friend - for instance, just the nonModHub parts for servers with download off.

[BUG] Starting App in Parallels Running Windows 11

The app won't start up. Uncaught rejection - quitting

Caught rejection: Error: no such file or directory, watch 'C:\Users{USERNAME}\log.txt'

Origin: [object Promise]

To Reproduce
Steps to reproduce the behavior:

1. Start Parallels Version 18.1.1 (53328)
2. Open FSModAssistant-..any version of 2.0
3. See error.

Desktop (please complete the following information):

• OS: Windows 11 running in Parallels v.18.1.1 (53328)
  

Dependencies are outdated

[email protected] depends
node ./test/outdated-deps.js

Outdated Dependencies

Package	Current	Wanted	Latest	Location	Depended by
@babel/core	7.19.1	7.20.12	7.20.12	node_modules/@babel/core	FSG_Mod_Assistant
adm-zip	0.5.9	0.5.10	0.5.10	node_modules/adm-zip	FSG_Mod_Assistant
electron	20.2.0	20.3.9	22.0.2	node_modules/electron	FSG_Mod_Assistant
electron-builder	23.3.3	23.6.0	23.6.0	node_modules/electron-builder	FSG_Mod_Assistant
electron-updater	5.2.1	5.3.0	5.3.0	node_modules/electron-updater	FSG_Mod_Assistant
eslint	8.24.0	8.31.0	8.31.0	node_modules/eslint	FSG_Mod_Assistant
fast-xml-parser	4.0.11	4.0.13	4.0.13	node_modules/fast-xml-parser	FSG_Mod_Assistant
yargs	17.5.1	17.6.2	17.6.2	node_modules/yargs	FSG_Mod_Assistant

[FEATURE] Add a keyboard shortcut to activate the "Show…" and "Find…" buttons with several mods selected

Is your feature request related to a problem? Please describe.
-1:

-2: Maybe it makes sense to move the "language selection" to Settings? It is chosen, most often, no more than once) And the slightly overloaded interface of the main window will be cleared up a little.

-3:

[FEATURE] Nickname / Tagline for collections

It'd be nice to have a nickname or tagline field for each collection. To be displayed in small text just below the collection name, main screen only.

Been running into situations where I don't want to rename the folder, but the original name isn't as descriptive as it could / should be.

[FEATURE] Add Select Overwrite All

Is your feature request related to a problem? Please describe.
When copying a lot of files to another mod collection (e.g. when updating a mod collection I have not played for a while) it takes quite some time to manually select all the Overwrite ticks.

Describe the solution you'd like
A button that ticks all the Overwrite yes/no tick-boxes - so Overwrite all duplicate files.

Describe alternatives you've considered
Pushing TAB-key and then Space-key repeatedly somewhat speeds up the process, but is still time consuming. No further alternatives I could think of.

Additional context
Maybe also make a button for unticking all Overwrite yes/no tick-boxes - so Do not overwrite duplicate files (e.g. when accidentally ticked all files to overwrite) ?

[BUG] Phantom window remains when clicking "Yes" to update prompt

Describe the bug
When I launch mod assistant and there is a new version available, I get a phantom window that is unable to be closed that remains after the updater runs. Once the updater is finished, the normal mod assistant window loads and I have 2 windows.

To Reproduce
Steps to reproduce the behavior:

1. Open FSG FS22 Mod Assistant
2. Click Yes on prompt asking if you'd like to install the new version
3. Updater window launches, updates program, and relaunches program
4. Observe "shell" window remains and is unable to be closed

Expected behavior
Initial window fully closes, updater runs, and the new version opens in a normal window.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Edition
  Windows 11 Pro
  Version 22H2
  OS build 22621.1105
  Experience Windows Feature Experience Pack 1000.22638.1000.0

Additional context
Any window that I drag over the affected area is still able to be interacted with. So even though the phantom window appears to be on top of the active window, it does not prevent interacting with the active window. I've observed this on at least the last 2 upgrade notifications (possibly 3). The only way I've found to remove the phantom window is to do a complete PC restart.

[FEATURE] Context Menus

Right click context menus in the main screen would be nice.

[BUG] Download Mods From Dedicated Server Failing

Describe the bug
When attempting to download mods for my dedicated server, the "Downloading Mods" window just sits there spinning at 0/0 for a long time, and then fails.

To Reproduce
Steps to reproduce the behavior:

1. Set up a mod folder
2. Add the URL: http://---/mods.html for downloading mods from dedicated server
3. Click the download button on the folder list
4. Eventually it will error after a long long wait

Expected behavior
Mods will download

Screenshots
Screenshots forthcoming when it fails out for me again, I don't currently have the time to wait for it.

Desktop (please complete the following information):

• OS: Windows 11
• MA Version: 1.5.2 (has been happening since 1.4.1)

Additional context
N/A

[FEATURE] Log Viewer

Maybe an in-app log viewer to make it easier to find the log, maybe add some color to the game log for easier reading.

[FEATURE] New relase wersion

Hi I have a question for you. Could you convert your mod management program to the one that was under Fs 17/19 called mod manager ? which indicated errors in file descriptions that is xml entries errors in dds storage imiga files and so on ?

Two line text does not fit on the "Show in Explorer" button [BUG]

Describe the bug
In the title.

Screenshots

Desktop (please complete the following information):
Windows 10

[UPDATE] Can Mod Assistant create symLinks?

This is a pinned message to refer back to, but the short answer is: no

The longer answer is:

To create a symLink in windows 10+, one of the following needs to be true:
1.) You need to be a local admin with development mode turned on
2.) You need to edit the group policies to give yourself the symlink privilege.
3.) The entire program needs to run with elevated access (as Administrator)

As we don't like any of these ideas, the decision has been made to not include this functionality at this time. Should these requirements change in the future, this will be reconsidered.

Dependencies are outdated

[email protected] depends
node ./test/outdated-deps.js

Outdated Dependencies

Package	Current	Wanted	Latest	Location	Depended by
electron	22.0.2	22.0.3	22.0.3	node_modules/electron	FSG_Mod_Assistant

[FEATURE] Devel Mode

Add a checkbox somewhere to enable dev mode in FS.

JSON error[BUG]

On loading the MMA it does it check of mods then will not load any folders. I have cleared the cache and still have this error

• OS: Windows 11

Mod Processing on App Start up

Can processing mods be made configurable? Having many mod folders and unzipped mods the application takes too long to start up. Right now I only have 3 mod folders in the configuration (of out of about 25) with currently only ~1000 mods, the application takes over 30 mins to process the mods and when I want to just quickly switch folders I can't. Can this feature only process mods when you "open / expand" a different Mod folder than currently selected? or have a way to see what has been processed and what is new but not interrogate every mod each time. Maybe have a "dirty" flag that can be then triggered by the user to run a mod update? I love this app, but it's becoming unusable. :( I hesitate to add the rest of my mod folders in or I won't be able to switch and play the game. Not sure if this is causing problems, but all of my mod folders are on OneDrive and sync between 2 different machines, a dev machine and my gaming machine. Also, when an update runs the whole process starts over again.

Thanks,
Scooter

[BUG] Javascript Unhandled/Uncaught Exception Error

When clicking the "3 dots" button next to the "Launch FS2022" button, a Javascript unhandled exception occurs. Clearing the error popup lets the program work normally, except that the bottom half of the settings screen has no text. Exiting the preferences screen and re-opening it reproduces the popup.

Attached to this report are the screencaps of what I see when this occurs.

[FEATURE] Allow filtering by Tag.

I would like to be able to filter "Broken" or "Folder" or by any tag and only show those mods that fit the criteria.

[FEATURE] Remember the last location

When adding folders with mods, each time the program returns to "Quick Access" instead of staying in the last folder from which the folder with mods was loaded. With adding 10+ such folders it is a bit of a pain to enter the same location every time.

[DOCS] Need a "first time set up" part of README.md

Need an initial setup doc

Log file location

After the 1.10.2 update, the process mods screen will not complete and closes the application. I have no error message popup so I'm wondering if there is a log file location that I can see what actually happened and if it's a mod that causes or something else that I should report.

[BUG] Incorrect detection of "crosplay" mods

I have the map 'Ostseeküste 22' in the crossplay version but the program claims that I have the "PC only" version although the link redirects to the correct version.

PC only: https://www.farming-simulator.com/mod.php?mod_id=259109
Crossplay: https://www.farming-simulator.com/mod.php?mod_id=260397

EDIT:
I noticed that in the description of the mod it appears that it contains 1 script, which is not true.

Dependencies are outdated

[email protected] depends
node ./test/outdated-deps.js

Outdated Dependencies

Package	Current	Wanted	Latest	Location	Depended by
@babel/core	7.19.1	7.20.12	7.20.12	node_modules/@babel/core	FSG_Mod_Assistant
adm-zip	0.5.9	0.5.10	0.5.10	node_modules/adm-zip	FSG_Mod_Assistant
electron	20.2.0	20.3.9	22.0.2	node_modules/electron	FSG_Mod_Assistant
electron-builder	23.3.3	23.6.0	23.6.0	node_modules/electron-builder	FSG_Mod_Assistant
electron-updater	5.2.1	5.3.0	5.3.0	node_modules/electron-updater	FSG_Mod_Assistant
eslint	8.24.0	8.31.0	8.31.0	node_modules/eslint	FSG_Mod_Assistant
fast-xml-parser	4.0.11	4.0.13	4.0.13	node_modules/fast-xml-parser	FSG_Mod_Assistant
yargs	17.5.1	17.6.2	17.6.2	node_modules/yargs	FSG_Mod_Assistant

[BUG] Folder removal (sometimes) fails

No idea why, but sometimes removing an unzipped mod fails to remove all the files and folders inside it.

[FEATURE] Select 'UNUSED' or 'INACTIVE' from savegame comparison screen

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

The ability to check your save game for inactive mods is awesome.

Describe the solution you'd like

Even more awesome would be a delete all located inactive mods from the folder button maybe after you've run the comparison to a save game.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

I mean you can select and delete the mods by searching for them. But I think a select all button would be useful.

Or from the main window you could then filter by inactive. But I presume you need to run it against a save file to work out whether it's active or not hence the select all/ delete all button being within the compare save game to mod folder screen

Additional context

I think there's space on the save game check window next to the icon on the left.

Dependencies are outdated

[email protected] depends
node ./test/outdated-deps.js

Outdated Dependencies

Package	Current	Wanted	Latest	Location	Depended by
adm-zip	MISSING	0.5.10	0.5.10	-	FSG_Mod_Assistant
decode-dxt	MISSING	1.0.1	1.0.1	-	FSG_Mod_Assistant
electron-store	MISSING	8.1.0	8.1.0	-	FSG_Mod_Assistant
electron-updater	MISSING	5.3.0	5.3.0	-	FSG_Mod_Assistant
fast-xml-parser	MISSING	4.0.13	4.0.13	-	FSG_Mod_Assistant
glob	MISSING	8.0.3	8.0.3	-	FSG_Mod_Assistant
parse-dds	MISSING	1.2.1	1.2.1	-	FSG_Mod_Assistant
pngjs	MISSING	6.0.0	6.0.0	-	FSG_Mod_Assistant
semver	MISSING	7.3.8	7.3.8	-	FSG_Mod_Assistant
unzip-stream	MISSING	0.3.1	0.3.1	-	FSG_Mod_Assistant
windows	MISSING	0.1.2	0.1.2	-	FSG_Mod_Assistant
xml2js	MISSING	0.4.23	0.4.23	-	FSG_Mod_Assistant
yargs	MISSING	17.6.2	17.6.2	-	FSG_Mod_Assistant

[BREAKING] v1.6.0 will not launch now that newer is available

Describe the bug
When I try and launch the program, it just immediately pops up a crash dialog behind the loading dialog. Pulling that out where I can interact with it, and clicking okay, just brings up a further series of error dialogs and eventually exits the program.

To Reproduce
Steps to reproduce the behavior:

1. Have 1.6.0 installed
2. Attempt to launch it
3. See error

Expected behavior
Program launches or offers update

Desktop (please complete the following information):

• OS: Windows 11
• Version 1.6.0

Additional context
Log file attached
crash.log

Dependencies are outdated

[email protected] depends
node ./test/outdated-deps.js

Outdated Dependencies

Package	Current	Wanted	Latest	Location	Depended by
eslint	8.32.0	8.33.0	8.33.0	node_modules/eslint	FSG_Mod_Assistant

[FEATURE] Launch Button - warn if active is not selected

When clicking the launch button, warn if the "active collection" in the dropdown is not the collection the game is set to use.

Dependencies are outdated

[email protected] depends
node ./test/outdated-deps.js

Outdated Dependencies

Package	Current	Wanted	Latest	Location	Depended by
eslint	8.31.0	8.32.0	8.32.0	node_modules/eslint	FSG_Mod_Assistant
glob	8.0.3	8.1.0	8.1.0	node_modules/glob	FSG_Mod_Assistant

[BUG] Symlinks support? ma doesnt pick up all mods

Describe the bug
Isn't loading all mods

I have 236 mods in my Silverrun folder when i add the folder it reads and test 236 but only then displays 8

Could this be something to do with the fact that the mods are symlinks though it is picking up some of those mods?

Adding my main mod folder (where i keep one version of all the zip files and sym link from to other folders works as expected so unsure if this is a bug or just the programme doesnt work with symlinks?

To Reproduce
Steps to reproduce the behavior:

1. use link shell extension to create a symlink in a map mod folder
2. Click on add folder select the symlink folder (with symlinked mods inside)
3. MA Processes mods
4. only 8 mods are then loaded in to MA

Expected behavior
all mods should load

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Windows 10

Additional context
Add any other context about the problem here.
assist.log

[BREAKING] What happened to Windows 7/8/8.1 support? (v2.2.x+)

v2.1.x will be the last Windows 7, 8, and 8.1 compatible version

What Happened?

Windows 7, 8, and 8.1 are no longer supported

If you need to still run under one of those OS's, you can use the portable version from version v2.1.4 which will not auto update.

Why - Short Version

Beginning with Electron v23, electron will ship with a version of chrome that no longer supports windows 7, 8, and 8.1

Why - Long Version

For an in-depth article about why, you can read this: https://www.electronjs.org/blog/windows-7-to-8-1-deprecation-notice

Dependencies are outdated

[email protected] depends
node ./test/outdated-deps.js

Outdated Dependencies

Package	Current	Wanted	Latest	Location	Depended by
@babel/core	7.19.1	7.20.12	7.20.12	node_modules/@babel/core	FSG_Mod_Assistant
adm-zip	0.5.9	0.5.10	0.5.10	node_modules/adm-zip	FSG_Mod_Assistant
electron	20.2.0	20.3.9	22.0.2	node_modules/electron	FSG_Mod_Assistant
electron-builder	23.3.3	23.6.0	23.6.0	node_modules/electron-builder	FSG_Mod_Assistant
electron-updater	5.2.1	5.3.0	5.3.0	node_modules/electron-updater	FSG_Mod_Assistant
eslint	8.24.0	8.31.0	8.31.0	node_modules/eslint	FSG_Mod_Assistant
fast-xml-parser	4.0.11	4.0.13	4.0.13	node_modules/fast-xml-parser	FSG_Mod_Assistant
yargs	17.5.1	17.6.2	17.6.2	node_modules/yargs	FSG_Mod_Assistant

[FEATURE] Enhanced Scroll Bar

Screenshots

Desktop (please complete the following information):

• OS: [e.g. Windows 10]

Additional context
https://farming-simulator.com/mod.php?lang=en&country=gb&mod_id=261585

Button Texts will not show up since V1.4 or so...

Describe the bug
Everytime I start the program OR do any action the button texts will not show up. Please view the attached screenshot:
https://i.ibb.co/r797NSN/Unbenannt.png

If I go then to settings, change the language (for example to english, then german again), the buttons appear again BUT as soon, as I do any action - for example delete a mod or anything else - the buttons "disappear" again.

This behaviour first appeared in V1.4 or so and stayed since then through all updates.

Using Windows 10 x64.

PS: Amazing Tool anyway! ;-)

[FEATURE] BC7 Support

There are some BC7 icons out there in mod land. They are not supported by the modHub, but if possible, Mod Assitant should read them

In 1.3.3 "Load Save Folder" does not work[BUG]

Describe the bug
In the title

Expected behavior
When I select a save folder and try to open it, nothing happens.

Desktop (please complete the following information):
. Windows 10

[BUG] No-internet startup slow

App startup can be very slow when started without an internet connection. Check on it.

Feature Request - Sticky Filters

    > …

P. P. S.
When scrolling through the list of mods, I would very much like, if not difficult, that the bar with the Search and the very necessary "none" button would not be hidden. Now: select a mod at the top of the list - see information about it - scroll, select another mod and ... the "Find on ModHub" button is not active - scroll (without a scrollbar, (it's good that it's not there - superfluous)) remove all selections - return to middle of the list.

Forgive my laziness to create a new issue. )

Originally posted by @vitalii2011 in #6 (comment)

[FEATURE] Find All - Additional Selection Functions

Wanted: a way to move/copy mods directly from the Find All window

Is it possible to show the ~icon that the mod's key combination is used in other mods/scripts?

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

• Now you can understand that the assigned key combination "repeated = conflicts" is possible only when some function does not start / stops working. If it is not displayed in the Help menu (F1) - it is immediately clear that there is a repetition in another mod, and sometimes it is displayed, but does not work. If repeated combinations are already in the keyboard shortcut settings, then you can find out with which particular "intersection" mod only by trying to reassign the already used combination and only then it is shown where it is already used.

Describe the solution you'd like
A clear and concise description of what you want to happen.

• An icon in a utility or mod for a game with information about conflicting combinations.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

• For a more or less convenient search for conflicts in inputBinding.xml, I use https://ef7q5.csb.app/ https://codesandbox.io/s/ef7q5

Additional context
Add any other context or screenshots about the feature request here.

[BUG] Need to throw an error if gameSettings.xml not found

If gameSettings isn't found, need to throw an error.

Crashes When Changing Detail Window Size [BUG]

Describe the bug
When attempting to change the default detail window size in the user preferences an exception is raised and the program closes upon acceptance.

To Reproduce
Steps to reproduce the behavior:

1. Go to user preferences
2. Attempt to change "Window Width" to 1000
3. Tab or click away from the text box
4. See error

Expected behavior
The program should accept the value and also allow the Window Height to be changed.

Screenshots
N/A

Desktop (please complete the following information):

• OS: Windows 10

Additional context
Main window default size was changed without issue.

Crash Log:
crash.log

[BUG] Update Notification Dialog - Multiple Issues With the Dialog

Describe the bug
The update dialog will pull you out of other apps, even full screen games, when it pops up. Focus grab is apparently set.
Additionally, it does not say anything about what app it is referring to, it just says the "app" is ready for update. See screenshot.

To Reproduce
Steps to reproduce the behavior:

1. Keep the app open
2. Play FS22
3. Have an update come in while you're performing step 2.
4. You will be pulled out of FS22, and it will be force minimized, by the focus grab of the dialog.
5. You'll be confused about what is requesting permission to update due to the lack of info on the dialog.

Expected behavior
Dialog is modal, but does not grab focus.
Dialog includes pertinent info.

Screenshots

Desktop (please complete the following information):

• OS: Windows 11

Additional context
N/A

[RELEASE-TRACK] 2.0.0 Bug List & Known Issues (v2.0.1 Changes)

Wow, that was fast. Known bugs in 2.0.0

• folder watchers might not be unbinding correctly (not always reproducible) 2bff688
• drag-and-drop file from app breaks subsequent drops to app. 6bcbc3d
• app fails to start if fs22 log not found #63 / log not opening 1ff39c2 26bfb33
• language selection fails e2a5325
• clicking on taskbar icon minimizes app to tray rather than taskbar 882d09e 9394d66
• footer display can go to two lines and look ugly. f3edec4
• keys tag can appear in both green and red. ee27bc9 4fb5d33

[FEATURE] Export Lists

Give an option to export a folder of mods to a text file, complete with modhub links (where appropriate)

[DOCS] Need Far Better Documentation

The documentation is terrible. Working on it. Master ISSUE to track all.

Topics

• Intro
• Initial Install Video
• Main Screen
• Folder Details Window
• Detail Window
• Import and Export
• Move and Copy and Delete and Copy Favorites
• Savegame Compare
• Version Check
• Edit Folders
• Search All Collections
• User Preferences
• FAQ