Coder Social home page Coder Social logo

comic-easel's People

Contributors

chrismaverick avatar egypturnash avatar frumph avatar jn-squire avatar kmhcreative avatar lunderberg avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

comic-easel's Issues

Can't use function return value in write context

My friend is getting the following error on her website using this plugin:

Fatal error: Can't use function return value in write context in /home1/creatrix/public_html/wp-content/plugins/comic-easel/comiceasel.php on line 609

I'm afraid I'm not very familiar with the functions in question but the examples in this article appear to be similar to the code in question:

https://mycyberuniverse.com/how-fix-cant-use-function-return-value-write-context.html

Link to comments in navigation does not show number for current page

In the Comic Easel config there is an option that I left activated:

Enable the comment link in the comic navigation?
When this is enabled, a link will appear in the navigation that lets you go to the comments section of the current post, it also shows how many comments there currently are.

Problem is, on each comic page of my site except the main page, the parenthesized number shows the total amount of comments I have received (2) on a different page, this one: http://emilyryan.se/gramarye/comic/the-roster-of-names/

Whether this is a bug or me setting up the URL:s wrong I can't say, but I thought I'd report it just in case.

TODO: Create image manager section in admin

Image manager needs to use $easel_dirs = wp_upload_dir(); to figure out the base url and basedir path to the uploads directory, then a comics folder under that.

The Image Manager will allow uploading of images either singularly or bulk. Let's you view thumbnails of the images (or smaller versions of), let's you select whatever you want to delete and regenerate thumbnails as necesary.

There is no create post when uploading and maintaining the comic images in this section, just straight image management and uploading.

  • Phil

Fatal error on activation

We have a number of blogs on a multisite install (http://umwblogs.org) that used the old ComicPress Manager; I'm trying to migrate them to Comic Easel using the CP2CE Migrator. When I try to activate Comic Easel, I get the message "Plugin could not be activated because it triggered a fatal error." However, there is no related error message in the PHP error log, and even turning on WordPress debugging gives me no information about what is happening. I've tried this on several different blogs so far, all with the same results.

I'm using WordPress 4.1.1 and Comic Easel 1.8.5. Any ideas for troubleshooting? Here's one of the blogs I'm trying to migrate: http://battlesnails.umwblogs.org/

landing page change in options

Set landing page in options to be seen by all, but with information on how to create a custom template for landing pages if its non-comicpress

Widget Logic, to include child chapters

Hello, I'd like to have widget logic work to check children chapters as well if you put in the single ID # of the chapter.

I have one chapter on my site that I create an infinite many numbers of child chapters for. It's becoming a pain to have to manually add every child chapter in the widgets in which I want them to appear.

Like the chapter I want this widget to apply to is called: "Scenes"
Currently there are no posts in Scenes, but there are multiple Child Chapters with posts in them inside of Scenes.
I want the widget to apply to everything in Scenes and its subchapters when I type ceo_is_chapter('scenes')

Wordpress 3.5 won't load with comic-easel

After upgrading to Wordpress 3.5 my website worked fine. After upgrading comic-easel to the new version, though, the site won't load. I have to remove the comic-easel folder from my plugins folder. The same thing happens when I install the package anew from the repository.

Conflict with W3 Total Cache in ceo_get_adjacent_chapter()

When calling ceo_get_adjacent_chapter() a second time in my chapter-oriented custom theme, current_chapter->menu_order is empty if W3 Total Cache's object caching is turned on.

This version of ceo_get_adjacent_chapter() fixes this by explicitly caching current_chapter->menu_order, and doesn't seem to have any side effects.

function ceo_get_adjacent_chapter($prev = false) {
    global $post;

    $current_chapter = get_the_terms($post->ID, 'chapters');
    if (is_array($current_chapter)) { $current_chapter = reset($current_chapter); } else { return; }

    // cache the calculation of the desired chapter to work around a weird intermittent bug with w3 total cache's object cache
    $current_order = wp_cache_get( 'ceo_current_order_'.$current_chapter->slug );
    if ( false === $current_order ) {
        $current_order = $current_chapter->menu_order;
        wp_cache_set( 'ceo_current_order_'.$current_chapter->slug, $current_order );
    } 

    $find_order = (bool)$prev ? $current_order - 1 : $current_order + 1;

    if (!$find_order) return false;
    $args = array(
            'orderby' => 'menu_order',
            'order' => 'DESC',
            'hide_empty' => 1,
            'menu_order' => $find_order
            );
    $all_chapters = get_terms( 'chapters', $args );
    if (!is_null($all_chapters)) {
        foreach($all_chapters as $chapter) {
            if ((int)$chapter->menu_order == $find_order) return $chapter;
        }
    }
    return false;
}

Make Comic Easel compatible with Loco Translate by merging comiceasel-en_US and en_US .po and .mo files

I got a lot of interest lately about Comic Easel from French comic authors, translators and readers, so I translated comiceasel-en_US PO and MO files with the best and most complete free tool I have on hand: Loco translate. (French is my native language)

The thing is, since the lang directory don't have any POT file, Loco Translate only dectect strings from comiceasel-en_US files, not the different ones put in the en_US files. As a result, it's currently impossible to translate fully the plugin in any language and publish comics to non-English readers with it! :(

For fixing this bug, and since, the POT file doesn't seem essential for Loco Translate, I suggest first to merge comiceasel-en_US and en-US PO and MO files.

"First in Chapter" navigation not working correctly

On my site I have two separate comic chapters ("Colour Wheel" and "Sketch Comics") running. I'm currently experiencing a minor problem with the navigation:

  1. The "first in chapter" link inevitably goes to the first comic chronologically, in the "Colour Wheel" chapter. This happens even when it is clicked from a "Sketch Comic" comic.
    http://colourwheelcomic.com/comic/phillr-kitteh/ <- This is the first comic in the "sketch comic" Chapter, but the "first (in chapter)" link still leads to the first "Colour Wheel" comic. The other "____ within chapter" nav links are functioning fine. I have tried both the default navigation and the widget and this problem persists in both cases.

As I am quite new to this and have very little programming experience, any help would be appreciated. My site is currently running the comicpress theme with the comic easel plugin.

Remove black border from Graphic Navigation

I spent most of the Sunday trying to remove this border around navigation. I have Inkblot with Comic Easel installed. I experimented with custom stylesheet, and I can "add" border, change bg colour, but I just can't find the way to remove it.

screen shot 2018-02-04 at 16 21 53

I'd appreciate your help!
Thanks

Custom Comic Thumbnail Upload

Joel Watson:
now what would be AMAZING, is it comic easel let me upload the featured image (comic) and a customer thumbnail right from the comic post page

Id like to crop a custom thumb from my original artwork so it can be a closeup on a character from a hi res file before it's exported for web

Philip M. Hofer:
ohh yeah actually I can do that, sinc ei'm going to be able to add a bonus panel image, I can have it make a custom-thumbnail thing as well, set a custom thumbnail

Joel Watson:
then just upload both images

Philip M. Hofer:
^ that goes in the issues list btw

According to GlotPress, CE is "not properly prepared for localization" (failed import)

So I discovered GlotPress and figured it would be much easier to create and maintain localizations of the plugin with this tool (for now). But it displays the following error:
image

The help page says "it usually means that something is wrong with the text domain" and talks about getting details through a Slack channel.

So in order to solve this bug, I suggest we get first the details of the failed import @Frumph : do you think you could do it? It would be really helpful.

Dropdown archive for individual comics

I was hoping for a dropdown archive listing individual comic posts for quick navigation.
Also, a dropdown listing all the comics only within the currently chapter would be a nice option as well.
Thanks!!

QuickEdit blanks the chapter for a comic page

I'm setting up a ComicEasel site right now, and I'm doing lots of editing of my pages. I have 6 chapters in my project, and all the pages I have input so far have a chapter assigned to them.

But... I've found that when I use QuickEdit, the Chapter radio buttons are BLANKED when the view is expanded to show the editing fields... this new blank state is saved along with everything else unless I re-select the chapter. Naturally this plays havoc with my archives, and leads to a lot of repeated work and extra clicks, etc.

Can you look into this? I am using the current version of ComicEasel, and editing in Safari.
--Jay

navigation code update reminder

$chapter_on_home = ''; $chapter_on_home = get_term_by( 'id', ceo_pluginfo('chapter_on_home'), 'chapters'); $chapter_on_home = (!is_wp_error($chapter_on_home) && !empty($chapter_on_home)) ? $chapter_on_home->slug : ''; $order = (ceo_pluginfo('display_first_comic_on_home_page')) ? 'asc' : 'desc'; $comic_args = array( 'showposts' => 1, 'posts_per_page' => 1, 'post_type' => 'comic', 'order' => $order, 'chapters' => $chapter_on_home ); $comicFrontpage = new WP_Query(); $comicFrontpage->query($comic_args); while ($comicFrontpage->have_posts()) : $comicFrontpage->the_post();
needs to replace whatever is there so that a single chapter can appear on home

next/prev chapter buttons inactive

Updated to the latest version. I can enable next/previous chapter buttons, but they are not clickable. Although I have 4 chapters and over 100 pages. I unchecked everything that seems to interfere with this in the config (I think).

Alt Text button for mobile devices

Per our conversation, here's the js I use on my site for this. The positioning and graphics are obviously specific to my site:



<script type="text/javascript">
jQuery(document).ready(function() {
    var cA = jQuery('#comic img').attr('alt');
    jQuery('<a id="checker"></a>').insertAfter('.comic_navi_wrapper').magnificPopup({
        items: {
            src: '<div class="alt-text-popup">'+cA+'</div>',
            type: 'inline'
        },
        removalDelay: 500,
        closeOnContentClick: true,
        closeBtnInside: true,
        mainClass: 'mfp-fade'
    });
});
</script>

<!--End Mobile Alt Text Button Code-->```

---

Note: the programmer that wrote this for me said it was using a style or a container that was specific to my theme and would need to be changed if I ever changed themes. Obviously it needs to be adjusted to be more universal. Maybe it could just overtake the comics div or something that you are guaranteed to have on every easel site. 

---

Here's the CSS if that helps: 

/\* Start Mobile Alt Text Styles */
# checker {

position:absolute;
width:125px;
height:41px;
background:url(http://hijinksensue.com/assets/misc/mobile-alt-text-button.png);
background-position:0 -40px;
display:inline-block;
bottom: 82px;
right: 25px;
cursor:pointer;


}
# checker:hover {

background-position:0 0;


}
@media (max-width:767px) {
    #checker {
        position: static;
    }
}
.alt-text-popup {
  position: relative;
  background: white;
  padding: 25px;
  width: auto;
  max-width: 600px;
  margin: 0 auto;
  font-size:20px;
  -webkit-border-radius: 14px;
  -moz-border-radius: 14px;
  border-radius: 14px;
}
# comic-wrap {

position: relative;


}
/\* End Mobile Alt Text Styles */

Comment button doesn't work.

Dear all,
I'm a wordpress newbie and I'm trying to use the comic-easel plugin in my blog. I thought that I installed it correctly, because I posted some images without any problem and the next and previous buttons work properly, but the comment button doesn't work. When you press it, nothing happens... I tried all the possible options in the wp-admin page, enable and disable all the checkboxes relative to the comments, but it changes nothing.
Do you have some solutions or advices?
Wordpress version is 3.9.1 and comic easel version is 1.7.4
Thanks
Best regards

wp_rewrite changes/additions

Looking to have the permalink return as for each post.

Current: /comic/post_slug

Want: /comic/chapter_slug/post_slug

current: /feed/

  • works as intended - has both in it (with pre_get_posts parser) however ?post_type=comic&chapter=tubular&feed=rss2 will contain both as well.
    Want: /comic/feed/
  • only the feed for that specific post type - currently returns to the current page
  • bug in my post type registering, I'm guessing

current: /2012/05/25/?post_type=comic

  • for archive
    want: /comic/2012/05/25/
  • or any combination for dates of the archives, just don't want ?post_type=comic to be written out on the url line

want: Anything more productive then having the ?post_type=comic being written on the url line for normal operations

Current Rewrite Rules:

comic/[^/]+/attachment/([^/]+)/?$   index.php?attachment=$matches[1]    
comic/[^/]+/attachment/([^/]+)/trackback/?$ index.php?attachment=$matches[1]&tb=1   
comic/[^/]+/attachment/([^/]+)/feed/(feed|rdf|rss|rss2|atom)/?$ index.php?attachment=$matches[1]&feed=$matches[2]   
comic/[^/]+/attachment/([^/]+)/(feed|rdf|rss|rss2|atom)/?$  index.php?attachment=$matches[1]&feed=$matches[2]   
comic/[^/]+/attachment/([^/]+)/comment-page-([0-9]{1,})/?$  index.php?attachment=$matches[1]&cpage=$matches[2]  
comic/([^/]+)/trackback/?$  index.php?comic=$matches[1]&tb=1    
comic/([^/]+)/feed/(feed|rdf|rss|rss2|atom)/?$  index.php?comic=$matches[1]&feed=$matches[2]    
comic/([^/]+)/(feed|rdf|rss|rss2|atom)/?$   index.php?comic=$matches[1]&feed=$matches[2]    
comic/([^/]+)/page/?([0-9]{1,})/?$  index.php?comic=$matches[1]&paged=$matches[2]   
comic/([^/]+)/comment-page-([0-9]{1,})/?$   index.php?comic=$matches[1]&cpage=$matches[2]   
comic/([^/]+)(/[0-9]+)?/?$  index.php?comic=$matches[1]&page=$matches[2]    
comic/[^/]+/([^/]+)/?$  index.php?attachment=$matches[1]    
comic/[^/]+/([^/]+)/trackback/?$    index.php?attachment=$matches[1]&tb=1   
comic/[^/]+/([^/]+)/feed/(feed|rdf|rss|rss2|atom)/?$    index.php?attachment=$matches[1]&feed=$matches[2]   
comic/[^/]+/([^/]+)/(feed|rdf|rss|rss2|atom)/?$ index.php?attachment=$matches[1]&feed=$matches[2]   
comic/[^/]+/([^/]+)/comment-page-([0-9]{1,})/?$ index.php?attachment=$matches[1]&cpage=$matches[2]  

As reported by rewrite rules inspector.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.