froonix / acme-dns-nc Goto Github PK

https://ccp.netcup.net/run/webservice/servers/endpoint.php?JSON

After upgrading to PHP 8.2 this script throws an error. It gives a possible solution but as I don't know php I cannot create a patch myself:

Cert is due for renewal, auto-renewing...
Plugins selected: Authenticator manual, Installer None
Renewing an existing certificate
Performing the following challenges:
dns-01 challenge for ronnylindner.de
Running manual-auth-hook command: acme-dns-nc/scripts/certbot-nc-auth
Error output from manual-auth-hook command certbot-nc-auth:
PHP Fatal error: Uncaught ErrorException: SoapClient::__construct(): The "ssl_method" option is deprecated. Use "ssl" stream context options instead in acme-dns-nc/scripts/acme-dns-nc:253
Stack trace:
#0 [internal function]: error_handler()
#1 acme-dns-nc/scripts/acme-dns-nc(253): SoapClient->__construct()
#2 acme-dns-nc/scripts/acme-dns-nc(120): NCCCP->__construct()
#3 {main}
thrown in acme-dns-nc/scripts/acme-dns-nc on line 253

Waiting for verification...
Challenge failed for domain DOMAIN
dns-01 challenge for DOMAIN
Cleaning up challenges
Running manual-cleanup-hook command: acme-dns-nc/scripts/certbot-nc-cleanup
manual-cleanup-hook command "acme-dns-nc/scripts/certbot-nc-cleanup" returned error code 255
Error output from manual-cleanup-hook command certbot-nc-cleanup:
PHP Fatal error: Uncaught ErrorException: SoapClient::__construct(): The "ssl_method" option is deprecated. Use "ssl" stream context options instead in acme-dns-nc/scripts/acme-dns-nc:253
Stack trace:
#0 [internal function]: error_handler()
#1 acme-dns-nc/scripts/acme-dns-nc(253): SoapClient->__construct()
#2 acme-dns-nc/scripts/acme-dns-nc(120): NCCCP->__construct()
#3 {main}
thrown in acme-dns-nc/scripts/acme-dns-nc on line 253
Attempting to renew cert (DOMAIN) from renewal/DOMAIN.conf produced an unexpected error: Some challenges have failed.. Skipping.

Hi,

Your acme-dns-nc is working just fine, but the documentation to integrate it into acme.sh is wrong.

dns_fnx_nc.sh should look something like this:

#!/usr/bin/env sh

dns_fnx_nc_add() {
  fulldomain=$1
  txtvalue=$2
  _info "Using myapi"
  _debug fulldomain "$fulldomain"
  _debug txtvalue "$txtvalue"
  /usr/local/sbin/acme-dns-nc "$fulldomain" "$txtvalue"
  return $?
}

#Usage: fulldomain txtvalue
#Remove the txt record after validation.
dns_fnx_nc_rm() {
  fulldomain=$1
  txtvalue=$2
  _info "Using myapi"
  _debug fulldomain "$fulldomain"
  _debug txtvalue "$txtvalue"
  /usr/local/sbin/acme-dns-nc "$fulldomain"
  return $?
}

acme.sh expects it to be a shell script and have these two functions in it.

Regards,
thorus

Convert $domain at all doRequest calls:

function idn_to_ascii_wrapper($domain)
{
	if(defined('INTL_IDNA_VARIANT_UTS46'))
	{
		return idn_to_ascii($domain, IDNA_DEFAULT, INTL_IDNA_VARIANT_UTS46);
	}

	return idn_to_ascii($domain);
}

Don't forget extension_loaded('intl') requirement check!

--
Reference: fnx-dns-tool

• 299c3de4f53544b824e908ec137f0e10c290479c
• 5ec4573771f56fa15578817caae43686ae26c6da
• 765bc5650fe796f4e35e07bbe4734995746259a7

(Multiple TXT records per host!)