Comments (2)
Nanahara
commented on May 10, 2024
In Subscription class (subscription.py) following lines have been removed in publish_callback function in PR #45
ack = ua.SubscriptionAcknowledgement()
ack.SubscriptionId = self.subscription_id
ack.SequenceNumber = publishresult.NotificationMessage.SequenceNumber
await self.server.publish([ack])
If I restored this code, the datachange notifications from history subscription are correctly acknowledged.
What was the initial purpose of removing the server.publish call in publish_callback ?
from opcua-asyncio.
cbergmiller
commented on May 10, 2024
Hi, thanks for investigating this issue!
The goal of #45 was to further decouple Subscrition, UaClient and InternalSession.
In case of the client, UaClient._publish_loop now takes care of sending the SubscriptionAcknowledgement.
I guess i didn't fully understand the importance of publishing the Ack on the server side.
This has probably to be done somewhere in InternalSubscription.
I will have to take some time to figure this out. A good first step would be to write a test to guard against a regression in the future.
from opcua-asyncio.
Related Issues (20)
- Cannot set final bit of signed integers using set_attr_bit
- Cannot set attribute bits for float or double values HOT 1
- Lower Certificate Error in Logs
- DataTypeEncoding object pointed by the "HasEncoding" links should have node class Object instead of ObjectType HOT 1
- Question regarding OperationsLimitsType HOT 1
- Issue importing nested UA extension data types from XML (HasSubType) HOT 1
- OPC-UA datatype Float interpreted as Double by server HOT 3
- Setting publishing interval of subscription doesn't change behaviour HOT 11
- CNC nodeset cannot compile SiOME HOT 1
- Generic Exceptions HOT 2
- RuntimeError: Unknown datatype for field: StructureField HOT 2
- Question: How to filter events on subscription with where_clause HOT 2
- Discrepancy Between _current_connections and CurrentSessionCount in OPC UA Server Implementation HOT 1
- Connect to Kepware KEPServerEX 6.15 via asyncua HOT 2
- The following references could not be imported and are probably broken. HOT 6
- Node Id refers to a node that does not exists in the server address space.(BadNodeIdUnknown) HOT 2
- 1.1.0/(1.0.7) HOT 3
- Intendet way for comparing values of two nodes HOT 2
- Connecting to a real PLC: UASocketProtocol:ServiceFault, BadSessionNotActivated
- Encryption with username/password (not certificate) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opcua-asyncio.