freecodecamp / pantry-for-good

An open source food bank logistics and inventory management tool

This repository is for the Pantry-for-Good application designed by Open Source for Good Contributors at freeCodeCamp. For deployment instructions see the deployment guide.

If you'd like to contribute, the contributing guide explains the git workflow and the developers guide gives an overview of how the app works. The open issues are a good place to start, or you can try the app and add your own issues. If you get stuck or need help with something, feel free to leave a comment.

Some issues are quite large, don't feel like you have to finish them, it's ok. Little bits help too! Start slow!

There's a demo app hosted at https://pantry-for-good.herokuapp.com, though it might be a bit behind the current version.

Installation

---

Local installation summary:

1. Install Node.js and MongoDB
2. Start MongoDB
3. git clone https://github.com/freeCodeCamp/Pantry-for-Good.git
4. cd Pantry-for-Good
5. Make sure you're on the 'staging' branch (git branch), otherwise run git checkout staging
6. npm install
7. npm run dev
8. Open http://localhost:8080 in your web browser
9. Login with username [email protected] password password

---

Detailed local development installation steps

You'll need to have a Node.js version >= 6 installed. Either use your OS's package manager or follow the installation instructions on the official website.

This app uses MongoDB as its database engine. Follow these instructions to install it locally and start the MongoDB server on your machine.

Install git if it is not already installed. To clone this repository to your local machine, open a command line interface and navigate to the directory where you would like to install the app. Then run git clone https://github.com/freeCodeCamp/Pantry-for-Good.git

Move to the Pantry-for-Good directory and run the npm install command to install the application dependencies.

Type npm run dev to start the application in development mode. If all goes well, it will be available at http://localhost:8080. The application is pre-populated with an administrator account with [email protected] as username and password as password.

---

Installing API keys

To use all the features of this application you will need to obtain API keys and install them in the application. After following the instructions below to obtain API Keys, put your keys in the file server/config/env/secrets.js.

1. gmapsApiKey

Google Maps API key for the deliveries feature. Currently, this key needs to be entered in the general settings page of your local instance of the application.

2. oauth

Google+ API for allowing users to register/login with google.

3. sendgrid

Sendgrid email API for sending emails.

• Register for a trial account or deploy the app and get the username/password from the heroku config vars
• Go to Settings > API Keys and create a key
• Paste the key in secrets.js or the SENDGRID_API_KEY config var of your deployed app.

pantry-for-good's Issues

Food dependency not working

schedule.client.controller.js and packing.client.controller.js are causing an injector Unknown Provider error. I think it is because it cannot resolve the Food dependency.

As a user, the app should notify me when the client information needs to be updated.

As an Admin, I should be able to specify a home city for driver assignment.

As a user, I should be able to see a live preview of the questionnaire as I edit it.

Customizable table columns

It could be nice to have a dropdown to choose which columns you want to see for each table, and have the preferences saved to the user.

As a user, I should be able to upload and attach documents to a client record.

remove hashbangs from URL

By default, Angular adds #!/ to the app's URL string. This looks unprofessional. Removing the hashbang would require adding appropriate routes on the server.

Continue the work

Hello Pete.
Why are you close all issues.
Are you close the project or the work will continue.
I was taking a break in working with food-bank-app to learn more about angularjs and when i have some progress i find that all the issues are closed.

angular-google-maps is unmaintained

Implement alternative

As a donor, I should be able to use the application to see previous donations and generate a tax receipt at the end of the year.

fix broken tests

When you run grunt test, you get pages full of errors. The tests were written for a previous version of the app and no longer work. It should be possible to fix them, however.

Password reset page does not give feedback

The password reset page needs to give the user feedback for success and errors in the same fashion as on the signup page. It should

• Indicate if the new passwords do not match
• disable the submit button if any fields are empty or if the new passwords do not match.
• If the server returns an error it should display the error
• If the server returns success it should display a success message and clear all the form fields

As a user, I should be able to view route directions in the app, on my mobile device.

Inventory menu item not working

When I am logged on as an admin and click on the Inventory menu item I get an error in the web browser console "Could not resolve 'root.foods' from state 'root'". It looks like the Inventory menu item is created in food.client.config.js and it indicates a route to root.foods but that route is not defined.

Need to get accountType before/after registering with oauth

Currently hard coded to create 'customer' users. Maybe easiest by having the first oauth buttons link to a simplified registration form with just the account type radio buttons and the real oauth buttons then send the account type with the google strategies passReqToCallback option.

As a user, I should be able to add, remove, and change fields that make up the client record.

UI does not update properly after deleting a food

On the inventory page if you delete a food item, it still shows that food item but all the other items in that category do not show anymore. You must refresh or go to another page and back again for the correct food list.

Packing lists generated by the application should take into account the number of people in the household.

signing out can take multiple tries to work.

I'm not sure how to reproduce this, but sometimes choosing "sign out" from the dropdown in the upper right hand corner just causes the screen to refresh with the same user still signed in.

Questionnaire editor: Implement dynamic row fields for dependants

MAF27 available for background and discussion.

multiple css warnings when loading page.

Find out why this is, and report here.

Driver isn't authorized to mark deliveries

Currently when you login with a driver and click "Mark delivered" under "Route Assignment" you get a 403 error. This is happening because the client is requesting that the server update the customer objects involved, but only admins are authorized to do so.

Volunteers should have access to packing page. Inventory too?

Not sure about inventory, but presumable the volunteers are going to be packing. Maybe we need another role so certain volunteers can be authorized to manage the inventory.

Also drivers need to be able to access their route

As a client, I should be able to shop online for the items I want delivered.

validation dialogs don't work in Safari.

Do we need to worry about having the app work in Safari?
Implement shim to correct.

fix vulnerabilities found by snyk.io

Overlapping definition of 'roles' and 'accountType' for users

It seems that roles and accountType evolved side by side as the app grew, with overlaps and unclear division of labor between them. Roles can be 'user', 'customer', 'volunteer', 'driver', 'donor', or 'admin’. accountType can be 'volunteer', 'donor', 'customer', or ’admin’.

The two should be separated, using roles for authentication (valid roles being ‘user’ or ‘admin’) and accountType for differentiating between clients, donors and volunteers.

Make an App component to load the app

As a user, I should be able to generate the most efficient delivery route.

Route Assignment generates error for driver when no deliveries are pending.

If you log in as a driver and go to the Route Assignment screen, you'll get an error about trying to reduce an empty list if you don't have any deliveries to make.

Bug in inventory page where it gets stuck in infinite recursion when loading

Implement TLS

Some browsers require a secure connection to use the geolocation feature, which is needed by the google maps plugin. In addition, some users might prefer to access the app using https.

Using TLS would require the user to obtain a certificate from a certificate authority. The app should default to http, with https being activated by an environment variable setting.

swig npm package is no longer maintained.

Implement alternative

As a user, I should be able to generate a packing list preview for the next week for each client, taking into account food bank inventory and client preferences.

As a user, I should be able to generate a report of the current food inventory.

remove dependence on ngInject

There are a number of cases in the Angular code where dependencies are injected implicitly through function parameter names. Inline array notation would remove the need for dependency annotation, and remove an unnecessary step in the build process. See here for more information.

Page should re-direct after deleting a customer

When logged on as an admin if you view a customer and click the Delete button it deletes the customer but it still stays on the same page. It should go back to the customer list or show some indication that the customer has been deleted.

Confirm navigation on page/questionnaire editors if changed and unsaved

Most pages with forms should confirm navigation/refresh if form is dirty. Page and questionnaire editors only hold one page/questionnaire in state, so also need to confirm navigation if another tab is clicked.

Assigning an inactive user as a driver then as active revokes his driver status.

In fact, due to the way this is handled on the server, setting him as a driver again won't work. A highly undesirable situation!

As an admin I should be able to add clients, volunteers, donors to the database without creating user accounts for each.

Currently the only way to add new users to the database (aside from running the "createAdminUser.js" script) is to log out of the app and go through the "sign up" process. The admin user should have a way to add new users to the database from the admin panel without logging out.

As a user, I should be able to use the app to notify the client that food has been delivered.

As a user, I should be able to scan a bar code and add the item to my pantry inventory.

As a user, I should be able to generate a report showing client details (income, number in the household, food preferences, etc.).

enable account disabling to prevent brute force attacks?

disable account after x number of login failures

Title is blank in the HTML

In the file app/views/layout.server.view.html line #5 the {{title}} variable is not set when the template is rendered.

tables don't print in Safari.

Packing list can be too long to print in Firefox.
Replace printing library?

Only show sidebar to admins, use top navigation otherwise

The sidebar looks a bit bare with only 1 or 2 links

Implement session timeout

Implement automatic session expiration, in accordance with OWASP. See https://www.owasp.org/index.php/Session_Management_Cheat_Sheet#Session_Expiration

clicking on "drivers and route assignment" for the first time causes it to bounce.

Sometimes have to click twice to get it to open.

When I am not logged in as an admin, I can still navigate to some admin routes instead of getting redirect to the login patge

/#!/admin/volunteers
/#!/admin/donors
/#!/admin/questionnaires