francodacosta / caparica Goto Github PK

The latest 1.0 tag is very confusing. I see commits with the addition of the ClientProviderInterface and several concretes for Array/Yaml/Doctrine providers (all very good). But the RequestValidator class has commits that actually remove clientProvider support from the service.

From my understanding, usage of the caparica package should be something like:

Configure a ClientProvider (basically a hash secrete lookup service).
Instantiate a RequestValidator , injecting a client provider.
Validate a request specifying a client code/id, request parameters and the signature.

The anticipated RequestValidator API:
RequestValidator::construct(ClientProvider, RequestSigner)
RequestValidator::validate(clientId, signature, params);

However with the current commit state, RequestValidator expects you to pass a client instance to validate.

The current RequestValidator API
RequestValidator::construct(RequestSigner)
RequestValidator::validate(Client, signature, params);

It all seems very backwards. I suggest RequestValidator be reverted back to requiring a clientProvider.