Coder Social home page Coder Social logo

dapp-frontend's People

Contributors

0xtekgrinder avatar alexsnipes avatar aliangm avatar amritkumarj avatar boyin0x avatar cryptnotiq avatar cupojoseph avatar deeayeen avatar drhongos avatar earth2travis avatar ervindimitri avatar freakofficedev avatar gmsteuart avatar mackbowes avatar metafraction avatar naftalimurgor avatar nickcaputo avatar nottotis avatar sdmg15 avatar sunguru98 avatar trungtin avatar vthonte avatar zerquix18 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

dapp-frontend's Issues

Add Transfer Button

URL: https://testnet.fraktal.io

Current: No easy way to transfer Full NFTs or Fraktions from the marketplace UI. Requires using etherscan or a third party site like opensea.

Desired: Add in a transfer option directly on the marketplace UI under my NFTs.

Design: Do it just like opensea with the .... menu dropdown in the top left or right corner of both the full NFTs and the Fraktions.

Screen Shot 2021-09-04 at 09 18 39

Which then brings to transfer page which shows NFT Image, Choose Amount (if fractionalised, if full NFT has 1 input and not changeable), and destination address

Screen Shot 2021-09-04 at 09 20 53

Notification System

Notification pop-ups (or email option) for any actions that have happened or required to do:

  1. New Offer (buy-out) = Vote
  2. Offer Accepted/Rejected (buy-out_
  3. Fraktions Sold
  4. Revenue Received

Auto Trigger Metamask on Mint and List

On https://testnet.fraktal.io/list-nft Having to manually trigger each tx intead of them auto-populating is bad UX for web3, bc if you leave the page then you lose the process…
-Also when not not listing on market it still shows all 4 steps when minting even though they aren’t required.

As transactions are submitted and confirmed should update box colours.

Add Unit Information in Purchase Block

Screen Shot 2021-12-07 at 12 54 19

In the box where user inputs # of fraktions to buy, put units. i.e Fraktions in light gray text so it is more clear.

Do the same with buyout offer by putting ETH in light gray text within the box.

Claim All Revenue

On individual NFT page, each deposit revenue tx has to be claimed individually. There should be a button to claim all in a single tx.

Make Fees Apply to All Transactions (Smart Contracts)

a 5% Fee is taken from marketplace txs to the Fraktal DAO. This amount can be adjusted via a proposal by the Fraktal DAO.

In addition, all transactions on Fraktal should incorporate this fee model such as:
-Distributing Revenue
-Buy-out
-Auction Format (in addition to fixed price: current)

FRAK button on Portoflio Page

In a previous version there was a button on each card under "your NFTs" on portfolio page that said FRAK IT (to fractionalise the NFT). Please add this back.

Add Decimals

In the initial scope of the contracts there was 18 decimals. In the implementation there are no decimals. This is a problem.

  1. Does not scale. If over 10k participants are in an auction, the contracts break bc they cannot issue fraktions.
  2. It does not work efficiently for auction format. i.e you receive fraktions based on (your eth contributed/total eth contributed). Without decimals it requires min. investment amount, rounding down fraktions, and withdrawing excess ETH. This increases gas costs bc of excess logic and requires additional txs (claim excess ETH). And overall is just messy and inefficient.

solution: add 18 decimals as originally defined.

Fix UI Bug for Fractional NFTs

On My NFTs section https://testnet.fraktal.io/my-nfts

Current State: Your Fraktions only shows Fractional NFTs which are listed on the marketplace.
Desired State: Show all fractional NFTs (listed on market or unlisted)

Testing:

  1. Go to https://testnet.fraktal.io/list-nft and mint an NFT without listing on the market.
  2. Go to my NFTs https://testnet.fraktal.io/my-nfts and click on NFT you just minted.
  3. Under NFT Image click the fractionalise it button. This converts the 1/1 into 10,000 ERC1155 units.
    After this stage, the NFT should move from the Your NFTs section to the Your Fraktions section

Arbitrum UX

break these down into specific issues when we get to this stage.

Arbitrum bridge and arbitrum usability UX (I.e buttons for add network, Migrate tokens, Migrate NFT)

Claim all ETH across multiple NFTs

On the portfolio page ETH from all Fraktions sold can be claimed. there should also be a function to claim all revenue across multiple NFTs.

Update UI for Existing Listings

When you go to https://testnet.fraktal.io/my-nfts#yourFraktions and click the sell fraktions button, it takes you to a page like this for the specific NFT https://testnet.fraktal.io/nft/0x11b669ba0f4a9f7cbd9a0a813e077e31a5e96483/list-item

If you already have fraktions for sale the current state looks like this:
Screen Shot 2021-12-12 at 21 57 21

Desired State:
-Remove left column inputs (for listing)
-Change "List properties" to "You currently have [n] Fraktions for sale" Total ETH = [total value for sale : should be same value as currently]
-keep unlist button underneath

If there are no fraktions for sale the list page should look like this: https://testnet.fraktal.io/nft/0x622bf966330ec546ccb7297d7a08d70287e65957/details
Screen Shot 2021-12-12 at 22 21 04

File Size Limits

What are the file size limits for uploads? i.e MP4 this becomes critical. We need to define this and add to UI.

Remove Manual Claim of ETH for Sold Fraktions

When fraktions are sold, the profits need to be manually claimed from the portfolio page. We should automate this like opensea so proceeds are automatically received in users wallets without having to manually claim anything.

Open for discussion.

Don't allow text in Total Price input

"Total Amount" do not allow text as input, so why should "total price" allow it?
image

The same in details
image

Although text would not work, there is no need to allow the user to enter text

Offer Still shows after being removed

When an offer to buy-out is taken out, it still shows in the UI

Screen Shot 2021-12-07 at 11 30 00

X

The desired state after an offer is removed is to have offer value show the value that was initially offered instead of NA & for the button to be removed and the status to say "cancelled" where the button currently is. Additionally the state could also display Accepted or Rejected there depending on the outcome of the buy-out offer voting.

Perpetual NFT Minting Block

Screen Shot 2021-12-07 at 12 20 53

On portofolio page, the NFT is minting status block is perpetually there even when nothing is being minted.

Load Screens & Auto-Refresh

Need load screens on any core action such as:
Minting NFT
Listing NFT on Market
Depositing Revenue
Buying Fraktions
Claiming Revenue/Fraktion Sales
Voting on Buy-outs
Offering Buy-out
Claiming Buy-out

Designs: https://www.figma.com/file/6OfufepTAGK2z1mF0zvaZK/Untitled?node-id=0%3A1

Pop-up should include load animation/image, message with action being completed, link to etherscan transaction.

User can close confirmation pop-up and continue using app; but if waits till it is completed, then button becomes active and triggers a page refresh when clicked (seems to be as close as we can get to an auto-refresh experience in web3)

Remove Refresh NFT Button

This is totally unecessary and confusing to users. If there is a bug that requires a manual refresh, fix the bug instead of cluttering the UI.

Auction Format

Task: Current marketplace format is fixed. i.e sell a certain amount of Fraktions for a set price.

There has been demand for an uncapped auction format with a reserve price. (almost ICO-like style for NFTs)

How it would work:

Choose % of NFT to sell (i.e 7,000 fraktions, 70%)
Choose reserve price (i.e 1 ETH)
Auction lasts 10 days and everyone receives a % proportionate to their ETH contributed divided by total ETH (i.e 10 eth total received, user puts in 1 eth = user gets 1/10 = 10% (of avail fraktions being sold, in this example 70% so 10% of 70% = 7% total of NFT. If reserve is not met, then eth is refunded and no fraktions are distributed.

Requires Update to UI & Smart Contracts. Create new Contract logic, do not change already audited contract logic.

Incorrect Path configuration

When submitting PRs, vercel is generating preview links to user-fraktaldapp.vercel.app instead of testnet.fraktal.io which makes it impossible to accurately test before merging bc the incorrect path causes errors.

Sell Button on Portfolio Page

In a previous version, on each card on the portfolio page under your Fraktions, there was a DeFrak button. This is fine to be on the individual asset page; however, please add a button that says "Sell Fraktions" on each card that takes to the list on marketplace screen.

Import Button Text inconsistency

Screen Shot 2021-12-07 at 12 32 52

One button says import to market while others just say import.

Does this just import to a Fractional NFT? Or does it import to a 1/1 Fraktal NFT? And what should next steps be after importing i.e List on Market or what?

Sell Fraktions (formerly List NFT) Button on Marketplace wrong-redirect

When you click Sell Fraktions (formerly List NFT) from the marketplace, it takes to portfolio page and then there is literally nothing that shows users what to do to list something. so it's broken UX.

Desired: Automatically scrolls down on portfolio page to Your Fraktions section where button is added from issue #56 so UX is clear.

marketplace load error

Screen Shot 2021-12-07 at 12 46 01

sometimes marketplace loads fine, othertimes it says no NFTs for sale, and requires a manual page refresh. This needs to be fixed.

Remove Import NFT Button

On portfolio page, each NFT in your wallet has an import button below it. The Import button on the top corner of the section does nothing. so remove it.

Missing Total Purchase Value

Screen Shot 2021-12-07 at 12 54 19

When buying an amount of Fraktions it shows you ownership % and all details but misses how much (in ETH) the total purchase costs until metamask is triggered, and that's bad UX. Can be added next to % ownership underneath. For example: equals n% ownership for n ETH

View Portfolio Next to Address

In a previous version of the UI, we had the text "View Portfolio" next to the address in the top right corner. Please add this back.

Audio File (MP3) Error - No Player

No option to add cover image for MP3 which causes error loadin
Screen Shot 2021-12-07 at 13 07 21
g

See issue #79 for more details on fix for this

and No Player is there to play the MP3 from the individual NFT screen
Screen Shot 2021-12-07 at 13 08 03
.

Marketplace Sort Filter Dropdown

Currently has: Availability (no idea what that means), Popular (?), Newly Listed.

Desired:
Lowest Price
Highest Price
Newly Listed
Popular (# of investors)

Default state should be popular

Plug Auction Contract into FE and Update UI

Part 1 (Update Listing Process)

https://testnet.fraktal.io/list-nft

There are now 2 listing types: Fixed Price and Auction

To solve for this. Update the List NFT Screen as follows:
Add a Dropdown or Tabs for Choose Listing Type directly under "List your Fraktion NFT for sale"

  1. Fixed Price
  2. Auction

Then only thing that changes underneath for the input boxes is if Auction is selected instead of Total Price, it is Reserve Price.
Screen Shot 2021-12-13 at 10 22 50

Part 2) Update Marketplace Page

Add a Filter Dropdown Menu next to sort that has the following options:

  1. All Listings
  2. Fixed Price
  3. Auctions

Part 3) Update Individual NFT Blocks
-Keep % available the same
-Instead of Total Price on bottom right, have a countdown timer with how much time left (starting at 10 days: hours: Min) -> could also go down to seconds if that is better UX.

Part 4) Update NFT Listing Details Page
-Available change to "For Sale"
-Price change to "Reserve Price" and remove 'per fraktion' text underneath
-Change Buy Fraktions block to "Contribute ETH", placeholder value from Fraktions to ETH, Buy Button to "Contribute"

Part 5) Claiming (excess ETH + Fraktions) after auction ends
These can probably be added on my NFTs page https://testnet.fraktal.io/my-nfts either as NFT Blocks or following how marketplace profit works.
-Need button to claim any leftover ETH, or if reserve price not met.
-Need button to claim Fraktions awarded.

Mint Process for Non Image Files

As seen in issues #76 and #78 there are issues for uploading non-image files.

A proposed solution to this is adding categories for the mint process which result in different minting flows:

For example: Choose between Image, Audio, Video

Image = same flow as current
Audio/Video = same flow but additional upload option to add cover image in addition to audio/video file.

This can then be applied to marketplace in issue #80

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.