fp12 / achallonge

Asynchronous Challonge library for Python 3.5+

Hi there 👋

Interests: C++ / Unreal Engine / Python

Tech blog

Reach out to me on LinkedIn!

achallonge's Issues

dependency on deprecated aiohttp package

The package is unable to run with current versions of aiohttp

Tournament.get_final_ranking() appears to not work

  File "/home/luci/Purah-Cogs/tournaments/tournaments.py", line 889, in end_to
urnament                                                                        
    ranking = await tournament.get_final_ranking()  # type: dict                
  File "/home/luci/purahenv/lib/python3.7/site-packages/challonge/tournament.p
y", line 783, in get_final_ranking                                              
    return OrderedDict(sorted(ranking.items(), key=lambda t: t[0]))             
TypeError: '<' not supported between instances of 'NoneType' and 'int'

No clue what I'm doing wrong. This is after I called Tournament.finalize(), and it worked (and I ignored the challonge.APIException, see #5 for details on that), and I made sure it worked by checking on Challonge.

Tournament.finalize() is broken

Calling this method will always raise a challonge.APIException, even if it actually worked. I'd expect it to return None if it worked.

report_winner function doesn't work inside a group stage

report_winner function seems not to work correctly while being used for matches inside a group stage. The associated group_player_ids for a player inside a group is not understanted by the function report_winner(..). This function expects a player with the id attribute equals to group_player_ids but get a player with his original id (outsite group stage) and crash.

example, with 2 objects player and match :

In [68]: player
Out[68]: <challonge.participant.Participant at 0x23866bb9c40>

In [69]: player.id
Out[69]: 152547829
In [70]: player.group_player_ids
Out[70]: [17666281] 

In [72]: match.player1_id
Out[72]: 17666281

await match.report_winner(player,score)

Error call : `APIException: ({'errors': ['Winner ID must be one of the player/participant IDs']}, 422, 'Unprocessable Entity', 'tournaments/10145851/matches/247328813', [('match[scores_csv]', '1-0'), ('match[winner_id]', '152547845')])

Can't connect to host.

I tried making a bot for Discord using your library. Though when i did everything that was mentioned here I just get [Errno 101] Cannot connect to host api.challonge.com:443 ssl:True [Can not connect to api.challonge.com:443 [Network is unreachable]]. Any ideas on what's wrong?