foundobjects / pve-nag-buster Goto Github PK

Per title

re: #3 (comment)

I installed this onto Proxmox 8.2.2 and the Web UI login system is now malfunctioning. When I browse to the Web UI from a browser that doesn't have a valid login cookie (e.g. an incognito window, or different computers) and enter valid credentials, I get a "Login Failed" message - though I see the VMs/CTs displayed behind the login window. If I then refresh the browser, it logs me in successfully.

This happened after running this script. I have tried uninstalling it with # bash install.sh --uninstall but the issue persists, even after a reboot. Any ideas what may be going on, and how to fix them?

Just wanted to update you that it stopped working in 6.2-15

Has this been abandoned or is a Proxmox 8.0 update being looked at? cheers

hey @cptsk1ttles
FYI, it's not work on pve-manager 7.2-11/b76d3178 with proxmox-widget-toolkit 3.5.1. CHANGE pve-nag-buster.sh at line 22 and 28-32 OR create new maybe will fixing this issue on pve-manager 7.2-11/b76d3178 with proxmox-widget-toolkit 3.5.1 :

Change pve-nag-buster.sh at lines (22 and 28-32) :

NAGTOKEN="data.status.toLowerCase() !== 'active'"
                <--slice-->
if grep -qs "$NAGTOKEN" "$NAGFILE" > /dev/null 2>&1; then
  echo "$SCRIPT: Removing Nag ..."
  sed -i.orig "s/$NAGTOKEN/false/g" "$NAGFILE"
  systemctl restart pveproxy.service
fi

To :

1. sed -i '22s/^/# /' pve-nag-buster.sh to change line 22

2. following this to change lines 28-32 :

:<<'comment'
if grep -qs "$NAGTOKEN" "$NAGFILE" > /dev/null 2>&1; then
  echo "$SCRIPT: Removing Nag ..."
  sed -i.orig "s/$NAGTOKEN/false/g" "$NAGFILE"
  systemctl restart pveproxy.service
fi
comment
if grep '^//.*\({\|res\)$' "${NAGFILE}" >> /dev/null 2>&1; then
   printf "[INFO] %s has been modified. exiting ...\n\n" "${NAGFILE##*/}"
else
   printf "\n[INFO] starting %s to Removing Nag ...\n" "${0##*/}"
   mapfile -t ar_num < <(grep -PnA1 -B1 '^\t.*.toLowerCase.*{$' "${NAGFILE}" | awk -F'-|:' '{print $1}')
   x="${ar_num[0]}"; y="${ar_num[1]}"; z="${ar_num[2]}"
   sed -i.dpkg-dist "${x},${y}s/^/\/\//;${z} i \\\t\t\tif (false) {" "${NAGFILE}"
   printf "[INFO] %s has been modified at line %s-%s\n" "${NAGFILE##*/}" "${x}" "${z}"
   printf "[HINT] please check: ~ nano +%s %s\n" "${x}" "${NAGFILE}"
   printf "[INFO] restarting pveproxy.service ...\n"
   systemctl restart pveproxy.service
   printf "[DONE] please try login to %s\n\n" "$(hostname -I | sed 's/ $/:8006/')"
   unset -v ar_num
fi

Or change target:

use /usr/share/perl5/PVE/API2/Subscription.pm instead of /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js via apt invocation :

~# echo "DPkg::Post-Invoke { \"sed -i 's/notfound/active/' /usr/share/perl5/PVE/API2/Subscription.pm\"; }" \
| tee -a /etc/apt/apt.conf.d/99pve-API2Subs-hook
DPkg::Post-Invoke { "sed -i 's/notfound/active/' /usr/share/perl5/PVE/API2/Subscription.pm"; }
~# sed -i '1i \/\/ remove naging proxmox subscription message' /etc/apt/apt.conf.d/99pve-API2Subs-hook
~# apt install --reinstall proxmox-widget-toolkit
~# apt-config dump | grep notfound
DPkg::Post-Invoke:: "sed -i 's/notfound/active/' /usr/share/perl5/PVE/API2/Subscription.pm";

Or :

completly replace pve-nag-buster.sh with this one

regards,
ngadmini

Does the script work for Proxmox VE 7.0?

When running the install script, I get an infinite loop

root@vidar:~# bash install.sh 
Creating PVE no-subscription repo list ...
Creating dpkg hooks in /etc/apt/apt.conf.d ...
Installing hook script as /usr/share/pve-nag-buster.sh
Running patch script
Creating PVE no-subscription repo list ...
Creating dpkg hooks in /etc/apt/apt.conf.d ...
Installing hook script as /usr/share/pve-nag-buster.sh
Running patch script
...

I'm running pve-manager/7.3-6/723bb6ec

As title. Just wondering if install.sh is needed after the initial run. As far as I can read from the source code, it looks like… yes?

If so, maybe consider including rm install.sh in the instructions.

Does this still work with Proxmox 6.x?

TODO, see title.

When doing a proxmox update from web gui, at the end of update, shell loose connection with pve-nag-buster message on screen.
So I can not see proxmox finished update message.
Is this normal? Seems kind of not acceptable.

The current install method in the README uses wget and I'm sure works just fine, but curl seems much easier to me.
curl -s https://raw.githubusercontent.com/foundObjects/pve-nag-buster/master/install.sh | bash

That said, my install is quite old and maybe I installed curl. Someone should verify it exists on a vanilla install.

Err:6 https://enterprise.proxmox.com/debian/ceph-quincy bookworm InRelease
401 Unauthorized [IP: 144.217.225.162 443]
Reading package lists... Done
E: Failed to fetch https://enterprise.proxmox.com/debian/ceph-quincy/dists/bookworm/InRelease 401 Unauthorized [IP: 144.217.225.162 443]
E: The repository 'https://enterprise.proxmox.com/debian/ceph-quincy bookworm InRelease' is not signed.

Seems like the script does not comment out the correct repositories for 8.0.