fossasia / susi_ios Goto Github PK

Actual Behaviour

Query "multi3". The sever response contains 3 action types but only result of first is displayed.
Also for map type only first action type is used.

Expected Behaviour

"actions": [
      {
        "type": "answer",
        "expression": "Singapore is a place with a population of 3547809. Here is a map: https://www.openstreetmap.org/#map=13/1.2896698812440377/103.85006683126556"
      },
      {
        "type": "anchor",
        "link": "https://www.openstreetmap.org/#map=13/1.2896698812440377/103.85006683126556",
        "text": "Link to Openstreetmap: Singapore"
      },
      {
        "type": "map",
        "latitude": "1.2896698812440377",
        "longitude": "103.85006683126556",
        "zoom": "13"
      }
    ]

If response is of this type, then the client should loop through all the actions and display result one after other with delay provided in the response. So, ideally the result of this response should be :

• 1st message : Singapore is a place with a population of 3547809. Here is a map: https://www.openstreetmap.org/#map=13/1.2896698812440377/103.85006683126556
• 2nd message after 0 delay : Link to Openstreetmap: Singapore
• 3rd message after 0 delay: A map displaying the given coordinates and zoom level

For response this

"actions": [
      {
        "type": "answer",
        "expression": "Line 1"
      },
      {
        "type": "answer",
        "delay": 400,
        "expression": "Line 2"
      },
      {
        "type": "answer",
        "delay": 1000,
        "expression": "Line 3"
      }
    ]

Response should be

• 1st message Line 1
• 2nd message after 0.4 seconds of 1st message : Line 2
• 3rd message after 1 second of 1st message : Line 3

Actual Behaviour

The chat field does not resize

Expected Behaviour

The Chat text field should grow in size as a new line is added

Steps to reproduce it

Type a long message and see

Screenshots of the issue

Would you like to work on the issue?

Yes

@mariobehling can we enable this for the repo?

Here is the link: https://material.io/components/ios/

The pods directory can be removed from the repository. Since there is a podfile, anyone developing this can just install from it.

Also, add a proper gitignore. Start at https://github.com/github/gitignore/blob/master/Swift.gitignore

Use Keychain or UserDefaults for saving user preferences

• UI/UX for in-app navigation
• Make use of Google APIs

Last chat bubble upon scroll starts is always hidden beneath the chat field.

Actual Behaviour

The result shows a single result

Expected Behaviour

Multiple results should be shown.

Steps to reproduce it

Query some random stuff which returns a websearch action.

Would you like to work on the issue?

Yes.

Forgot password button is not working in the app.

UI Issues:
1.Susi logo and email field spacing gets abrupt on smaller devices like iPhone 5s. - Login Screen
2.Password invalid texts gets overlapped with confirm password field. - Signup Screen.
3.Keyboard return does not hide the keyboard. - Login, SignUp Screen.
4.Tapping on empty space to hide keyboard - Login, SignUp Screen.

Solution:
1.Change constraints of the UI elements in Login, SignUp Controller
2.Add gesture for tap, and dismiss keyboard on tap gesture.
3.Add keyboard return button functionality to dismiss keyboard.

I would like to fix this issue.

Issues mentioned here: https://www.codacy.com/app/mb/susi_iOS/issues

For this we will need to:

• Include Pods folder, since it's going to remain the same unless versions updates
• Removing test and clean from the build script, they are not required

Thoughts @mariobehling @niranjan94 ?

Code signing being turned on sometimes causes Travis build failures

Please create an ipa branch and add the app here regularly.

Actual Behaviour

On giving play video command some random video start playing but susi reply side remain blank. Currently in Android part susi reply side show text playing video.

Expected Behaviour

Some text should be shown. In Android part I am trying to change it in thumbnail image or some url text.

Steps to reproduce it

Give Play video command.

LogCat for the issue

Provide logs for the crash here

Screenshots of the issue

Would you like to work on the issue?

@chashmeetsingh

Enabling this feature would help reduce the build time.

https://developers.google.com/youtube/v3/docs/search/list
Can be used for fetching results and for UI:
https://github.com/chashmeetsingh/Youtube-iOS

There are instructions how to get this started here: https://github.com/fastlane/fastlane/tree/master/gym

Please ensure the history of ipas is not kept. Get in touch with the Open Event Android guys if you are not sure, how to do this.

Change the commit message guidelines. ref issue PR . Also add screenshots of app in the docs(if possible).

Actual Behaviour

Code base looks messy right now.

Expected Behaviour

It can be made more modular extracting code to classes and reducing the LOC for each file.

Would you like to work on the issue?

Yes

Ask for user location and send it in the API request. Needs to be done inside MainViewController.swift

Should look like:
http://api.asksusi.com/susi/chat.json?latitude={latitude}&longitude={longitude}&....

Actual Behaviour

App is crashing when user send message like below heaven, slow speed where susi reply is websearch type.

Expected Behaviour

App should not crash.

Steps to reproduce it

Start susi iOS app and send messages like below heaven, slow speed where reply is websearch type but app is not able to find something on web.

LogCat for the issue

@chashmeetsingh can you provide logcat? I can't do this.

Screenshots of the issue

Would you like to work on the issue?

@chashmeetsingh try to solve it.

• Make use of Speech framework
• Update Chat UI/UX

Actual Behaviour

Video is played checking the if the query contains play substring.

Expected Behaviour

All action types need to be fetched from server.

Steps to reproduce it

try play {any_query}

Would you like to work on the issue?

Yes.

There are a number of guides for best practices of iOS projects.

E.g. please watch this talk: https://www.cocoanetics.com/2014/10/best-practices-running-an-ios-open-source-project-on-github/

Please add info on best practices for this project into the Readme.md.

Actual Behaviour

Nothing happens as of now.

Expected Behaviour

Display a horizontal collection view with results.

Would you like to work on the issue?

Yes.

Actual Behaviour

Folder structure used in Xcode does not show up on Github.

Expected Behaviour

Folder structure should show up.

Steps to reproduce it

This can be verified here: https://github.com/fossasia/susi_iOS/tree/master/Susi

Would you like to work on the issue?

Yes.

Actual Behaviour

No time stamps are present in the UI.

Expected Behaviour

Time stamps should be present for each message.

Would you like to work on the issue?

Yes.

Need to add hotword detection capability which runs continuously when the app in is foreground so that capabilities can be used hands free.

Actual Behaviour

When calling the /susi/chat.json api of susi_server, no language information is transmitted

Expected Behaviour

The configured language (not the country code) shall be send to the server.

Please add a query attribute language and fill it with the currently configured language using the ISO 639-1 standard (a lowercase two-letter code), see https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes

Add badge so that users can easily test the app online

Currently, clicking on wallpaper setting doesn't do anything.

Actual Behaviour

Fails to find IPA branch

Expected Behaviour

Upload IPA script should upload IPA to the ipa branch

Steps to reproduce it

Check logs: https://travis-ci.org/fossasia/susi_iOS/builds/237965854 (at the end)

Would you like to work on the issue?

Yes

The Readme.md only has some screenshots at the moment. Please add info following other FOSSASIA projects.

In Android projects the application is usually in a folder /app. I assume it is the same with iOS apps.

Screenshots and additional documents should go into a docs folder:

• /docs additional documentation
• /docs/img/ all images into this folder

Please also research and implement other iOS projects and start fo follow best practices.

We have switched on travis for this repo. Please check what tests you can implement and how to integrate travis. Cheers.

Please provide instructions to compile and run the app.

Currently the LaunchScreen.storyboard is an empty view. Populate it with the same UIColor as in the app with the logo in the middle.

Also, to provide a better UI/UX experience add an animation where the logo in the middle animates to the top and then the text fields appear.

Actual Behaviour

App crashes on login.

Expected Behaviour

User should be able to login to start chatting.

Steps to reproduce it

Run the app and try logging in.

Would you like to work on the issue?

Yes.

Add custom url support similar to android app. ref issue PR. Add option to either select susi default server or custom server. If user chooses custom server, ask for Base url of the server.
Also add an option to change server in settings. In that option simply log out the user. Check screenshot in the referred PR for more details.

The Readme.md is not super long. Therefore for now we can keep all the current documentation here. Please add set up instructions into the main Readme.md.

Secondly, please change the link to the mailing list to https://groups.google.com/forum/#!forum/opntec-dev

This repository should follow basic templates like other fossasia's repositories
Sending a PR for this.

Make the UI compatible for iPad